New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 870111 link

Starred by 0 users
Status: WontFix
Owner: ----
Closed: Aug 29
Cc:
█ elizabethchiu@chromium.org
█ jlklein@chromium.org
shibasheikh@chromium.org
jessejames@chromium.org
█ lesliewatkins@chromium.org
khorimoto@chromium.org
█ jordynass@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 871552


Sign in to add a comment

UI polish on setup flow

Project Member Reported by khorimoto@chromium.org, Aug 2 
Should match mocks: https://docs.google.com/presentation/d/1hloC0CmSxtuwHbVLbKSaq1HWpxyYt4EDTTxMuPu0wHc/edit#slide=id.g3d18ebb7a8_17_62

Some things I notice off the top of my head:
(1) Dialog has a title, but mocks do not.
(2) Button placement/text/styling need to be updated.
(3) Icons need to be added to "start setup" page.
(4) Animations need to be added to "start setup" and "setup completed" pages.
(5) Fonts, margins, etc. need to be updated.

...but there are probably more.

Comment 1 by khorimoto@chromium.org, Aug 7

Blockedon: 871552

Comment 2 by jlklein@chromium.org, Aug 16

Owner: khorimoto@chromium.org
Status: Assigned (was: Available)

Comment 3 by khorimoto@chromium.org, Aug 21 

As part of issue 870098, I added the password page but did not style it. It also needs the following:

(1) Profile photo of signed-in user.
(2) E-mail address of signed-in user.
(3) Various styling changes.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1187cef2ee1869f61a23e314f03e722cdc7c0110

commit 1187cef2ee1869f61a23e314f03e722cdc7c0110
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Aug 22 02:40:12 2018

[CrOS MultiDevice] Add assets to MultiDevice setup flow.

This CL adds:
(1) Four .png files (two icons in both 1x and 2x sizes).
(2) Three .svg files.

Bug:  870111 , 824568
Change-Id: I39f2a24f128a63ee081629eaa755b9fbea1ef4db
Reviewed-on: https://chromium-review.googlesource.com/1184332
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584950}
[modify] https://crrev.com/1187cef2ee1869f61a23e314f03e722cdc7c0110/chrome/browser/resources/chromeos/multidevice_setup/icons.html
[modify] https://crrev.com/1187cef2ee1869f61a23e314f03e722cdc7c0110/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_resources.grd
[add] https://crrev.com/1187cef2ee1869f61a23e314f03e722cdc7c0110/chrome/browser/resources/chromeos/multidevice_setup/setup_succeeded_icon_1x.png
[add] https://crrev.com/1187cef2ee1869f61a23e314f03e722cdc7c0110/chrome/browser/resources/chromeos/multidevice_setup/setup_succeeded_icon_2x.png
[modify] https://crrev.com/1187cef2ee1869f61a23e314f03e722cdc7c0110/chrome/browser/resources/chromeos/multidevice_setup/setup_succeeded_page.html
[add] https://crrev.com/1187cef2ee1869f61a23e314f03e722cdc7c0110/chrome/browser/resources/chromeos/multidevice_setup/start_setup_icon_1x.png
[add] https://crrev.com/1187cef2ee1869f61a23e314f03e722cdc7c0110/chrome/browser/resources/chromeos/multidevice_setup/start_setup_icon_2x.png
[modify] https://crrev.com/1187cef2ee1869f61a23e314f03e722cdc7c0110/chrome/browser/resources/chromeos/multidevice_setup/start_setup_page.html
[modify] https://crrev.com/1187cef2ee1869f61a23e314f03e722cdc7c0110/chrome/browser/resources/chromeos/multidevice_setup/ui_page.js
[modify] https://crrev.com/1187cef2ee1869f61a23e314f03e722cdc7c0110/tools/gritsettings/resource_ids

Comment 5 by khorimoto@chromium.org, Aug 22

Owner: ----
Status: Available (was: Assigned)
Landed the main assets, but there is still a lot of polish work to go.

Comment 6 by khorimoto@chromium.org, Aug 29

Status: WontFix (was: Available)
I'm closing this bug out in favor of more granular bugs:
  * Password page: Issue 878643
  * Start setup page: Issue 878644
  * Setup succeeded page:  Issue 878646
►

Sign in to add a comment