UI polish on settings page |
||||||||
Issue descriptionShould match mocks: https://docs.google.com/presentation/d/1hloC0CmSxtuwHbVLbKSaq1HWpxyYt4EDTTxMuPu0wHc/edit#slide=id.g3d18ebb7a8_17_85 Some things I notice off the top of my head: (1) "Better Together is on/off" text is not indented by the right amount. (2) Main toggle (for entire suite) is not aligned with feature toggles. ...but there are probably more.
,
Aug 24
Another thing to do: currently, no enterprise icon is shown for features prohibited by policy.
,
Aug 24
Issue 877335 has been merged into this issue.
,
Aug 28
Should be P1 - must be cleaned up by launch.
,
Aug 28
This bug is too coarse to mark as a blocker bug. We really need someone to triage all outstanding polish issues, file the issues in crbug, and mark the most egregious as P1, but that list should be very short. Most polish issues are not launch-blocking.
,
Aug 28
,
Aug 29
Thanks for the feedback, James. Shiba/Elizabeth are looking over the design and coming up with more granular bugs. Once they do, I'll close out this bug (like I did with issue 870111 ).
,
Sep 11
,
Sep 11
,
Sep 11
I've chatted with Shiba/Elizabeth, and they said that they have no more polish issues for the settings page except for the two issues I raised in the original post. I'll no longer be splitting this bug up into more granular bugs.
,
Sep 11
,
Sep 17
As per our conversation the other day, Namrata wanted both the 'Better together is on/off' and the 'forget device' to be aligned with the 'back' arrow at the top. In other words, the 'better together is on/off' is aligned correctly in HEAD but 'forget device' should be unindented. Also the text in the mocks for the 'waiting on verification/server' case is 'Waiting for verification' with a 'verify' button.
,
Sep 17
For the first issue, sure. That sounds ok. Please follow the string doc by Jon Ann as source of truth.
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ee2146359b024525f5f3bca50592a70817e90e8 commit 3ee2146359b024525f5f3bca50592a70817e90e8 Author: Jordy Greenblatt <jordynass@chromium.org> Date: Tue Sep 18 02:25:18 2018 [CrOS MultiDevice]: Settings UI subpage aesthetic and string fixes Changes in this CL: -Unindent 'forget device' line -Get rid of coloration of 'Better together is on' -When waiting for verification/server, show text for that instead of 'better together is on/off' -When waiting for verification/server, show and verify button instead of suite toggle Bug: 884390 870103 Change-Id: I0c8fb9519d52c8a016f90eba32b26dda97bd449b Reviewed-on: https://chromium-review.googlesource.com/1228935 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#591919} [modify] https://crrev.com/3ee2146359b024525f5f3bca50592a70817e90e8/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.html [modify] https://crrev.com/3ee2146359b024525f5f3bca50592a70817e90e8/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.js
,
Sep 18
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jlklein@chromium.org
, Aug 16