New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870097 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Pass correct device name to "existing user, host switched" notification

Project Member Reported by khorimoto@chromium.org, Aug 1

Issue description

Notification message: IDS_ASH_MULTI_DEVICE_SETUP_EXISTING_USER_HOST_SWITCHED_TITLE

Currently, no name is passed to it, so "$1" is displayed instead.
 
Cc: jessejames@chromium.org shibasheikh@chromium.org elizabethchiu@chromium.org
Owner: jordynass@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Status: Assigned (was: Started)
Owner: ----
Status: Available (was: Assigned)
Owner: khorimoto@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4e60824b8f0ede9b108df23bcd1e49f929ecb5e

commit d4e60824b8f0ede9b108df23bcd1e49f929ecb5e
Author: Kyle Horimoto <khorimoto@google.com>
Date: Tue Aug 28 21:54:10 2018

[CrOS MultiDevice] Include device name in "new host phone" notification.

The "new host phone" notification's title includes a placeholder for the
name of the new host device. However, nothing was actually passed to
this placeholder, so it simply displayed "$1" as part of the string.

This CL passes the name of the new host when notifying the delegate.

Bug:  870097 , 824568
Change-Id: Ieab2c9f34ee7e92f5d256707f0544637fc30a449
Reviewed-on: https://chromium-review.googlesource.com/1194295
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586868}
[modify] https://crrev.com/d4e60824b8f0ede9b108df23bcd1e49f929ecb5e/ash/multi_device_setup/multi_device_notification_presenter.cc
[modify] https://crrev.com/d4e60824b8f0ede9b108df23bcd1e49f929ecb5e/ash/multi_device_setup/multi_device_notification_presenter.h
[modify] https://crrev.com/d4e60824b8f0ede9b108df23bcd1e49f929ecb5e/ash/multi_device_setup/multi_device_notification_presenter_unittest.cc
[modify] https://crrev.com/d4e60824b8f0ede9b108df23bcd1e49f929ecb5e/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl.cc
[modify] https://crrev.com/d4e60824b8f0ede9b108df23bcd1e49f929ecb5e/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl.h
[modify] https://crrev.com/d4e60824b8f0ede9b108df23bcd1e49f929ecb5e/chromeos/services/multidevice_setup/fake_account_status_change_delegate.cc
[modify] https://crrev.com/d4e60824b8f0ede9b108df23bcd1e49f929ecb5e/chromeos/services/multidevice_setup/fake_account_status_change_delegate.h
[modify] https://crrev.com/d4e60824b8f0ede9b108df23bcd1e49f929ecb5e/chromeos/services/multidevice_setup/multidevice_setup_impl.cc
[modify] https://crrev.com/d4e60824b8f0ede9b108df23bcd1e49f929ecb5e/chromeos/services/multidevice_setup/public/mojom/multidevice_setup.mojom

Status: Fixed (was: Started)

Sign in to add a comment