New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870072 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit 25 days ago
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Instant Tethering device are not always available after setup flow

Project Member Reported by khorimoto@chromium.org, Aug 1

Issue description

TetherHostFetcher uses "MAGIC_TETHER_HOST == kSupported" to determine if a device is eligible. However, it should allow supported OR enabled. See [1].

Additionally, we probably should no longer show the "Supports mobile hotspot" field within chrome://proximity-auth, since it is confusing now that it is not inspected with the flag enabled.

[1] https://cs.chromium.org/chromium/src/chromeos/components/tether/tether_host_fetcher_impl.cc?l=93
 
Cc: jessejames@chromium.org baileyberro@chromium.org
Owner: khorimoto@chromium.org
Status: Started (was: Available)
Why shouldn't TetherHostFetcher use just "MAGIC_TETHER_HOST == kEnabled"?
Description: Show this description
Re: comment #3: Essentially, it should use that. However, this should be encapsulated by the upcoming MultiDeviceSetup API, so I'm waiting on implementing this fix.
Owner: jlklein@chromium.org
Status: Assigned (was: Started)
Jeremy's going to take this bug over while I work on another task.

What needs to be done:
(1) TetherService already has access to MultiDeviceSetupClient. When it creates TetherHostFetcher, pass MultiDeviceSetupClient to its constructor.
(2) Within TetherHostFetcherImpl::CacheCurrentTetherHosts(), use MultiDeviceSetupClient::GetHostStatus() to grab the current host.
(3) If there is no current host, make |current_remote_device_list_| an empty list.
(3) If there is a current host, set |current_remote_device_list_| to be that one host (only one host is possible per account with the new flag on).
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e84dd0eb5823863e459e1defc06204ad72fb55c

commit 5e84dd0eb5823863e459e1defc06204ad72fb55c
Author: Jeremy Klein <jlklein@google.com>
Date: Tue Aug 21 03:41:36 2018

Always append sms experiment params to flag-passed urls.

The PWA install API always needs the experiment URL params for now,
but the service worker logic can never have those or stuff breaks.
This change resolves that discrepancy.

Also switch the staging url to point to one that doesn't require
uberproxy because the PWA install API doesn't play well with URLs
that have redirects. This still points to the same actual Messages
code, though.

R=azeemarshad@chromium.org

Bug:  870072 
Change-Id: I23f6f0c4d375f2301cfd1b8efb94d36bf88581cf
Reviewed-on: https://chromium-review.googlesource.com/1182868
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584639}
[modify] https://crrev.com/5e84dd0eb5823863e459e1defc06204ad72fb55c/chrome/browser/chromeos/android_sms/android_sms_urls.cc

Obviously that last CL was tied to the wrong bug. Please ignore it :-p.
Status: Fixed (was: Started)

Sign in to add a comment