Add "forget phone" option in settings |
||||||||
Issue descriptionThis would allow users to disable Better Together on the laptop side.
,
Aug 2
,
Aug 8
,
Aug 8
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3bcc35abee4821a76ec946d96efedfaa83976e2 commit e3bcc35abee4821a76ec946d96efedfaa83976e2 Author: Jordy Greenblatt <jordynass@chromium.org> Date: Mon Aug 13 20:04:53 2018 [CrOS MultiDevice] Basic forget device item in settings UI subpage This CL adds the forget device line in the subpage that has no functionality yet. Bug: 870069 , 824568 Change-Id: Id85730eccd456d3a80516cc5c7d156fd86174d09 Reviewed-on: https://chromium-review.googlesource.com/1166334 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#582680} [modify] https://crrev.com/e3bcc35abee4821a76ec946d96efedfaa83976e2/chrome/browser/resources/settings/multidevice_page/multidevice_feature_item.html [modify] https://crrev.com/e3bcc35abee4821a76ec946d96efedfaa83976e2/chrome/browser/resources/settings/multidevice_page/multidevice_page.html [modify] https://crrev.com/e3bcc35abee4821a76ec946d96efedfaa83976e2/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.html [modify] https://crrev.com/e3bcc35abee4821a76ec946d96efedfaa83976e2/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.js [modify] https://crrev.com/e3bcc35abee4821a76ec946d96efedfaa83976e2/chrome/test/data/webui/settings/multidevice_subpage_tests.js
,
Aug 13
Tasks remaining: (1) Add "forget device" dialog. When the "forget device" row is clicked, show the dialog. (2) Add BrowserProxy integration; when "confirm" button of the dialog is clicked, make the call to the service to remove the current host, then close the dialog.
,
Aug 16
,
Aug 24
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1543d070959e45d46554c8bb616ffb60cb04427 commit f1543d070959e45d46554c8bb616ffb60cb04427 Author: Kyle Horimoto <khorimoto@google.com> Date: Mon Aug 27 21:30:59 2018 [CrOS MultiDevice] Add ability to remove a multi-device host. This CL: (1) Displays a confirmation dialog when users request that the host device be removed. (2) Actually removes the device as a host if the user confirms their intention to forget the current device. Note: As part of this change, I've moved some strings from chromeos_strings.grdp to settings_strings.grdp, since the strings are displayed in the settings page. Bug: 870069 , 824568 Change-Id: Ifd9fb275fa385d4fcc45cd4d8000c4534cd3c14b Reviewed-on: https://chromium-review.googlesource.com/1191523 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#586421} [modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/app/settings_strings.grdp [modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/resources/settings/multidevice_page/multidevice_browser_proxy.js [modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/resources/settings/multidevice_page/multidevice_page.js [modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.html [modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.js [modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc [modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.h [modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/ui/webui/settings/chromeos/multidevice_handler_unittest.cc [modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/584682e4a91134bd74ad691d4c1b68f65c7da401 commit 584682e4a91134bd74ad691d4c1b68f65c7da401 Author: Kyle Horimoto <khorimoto@google.com> Date: Tue Aug 28 17:28:20 2018 [CrOS MultiDevice] Fix two bugs related to removing the host device. (1) HostVerifierImpl::IsHostVerified() returned true if the device had previously been verified but was pending removal. If a device is pending removal, the user has explicitly requested that it be removed as the host device, so it should not be considered verified. (2) RemoteDeviceCache::SetRemoteDevices() skipped overwriting device metadata if that data was not newer than the previously-stored data. However, there is currently a bug on the CryptAuth back-end which does not update the device metadata update time when a feature has been changed from supported to enabled or vice versa. Thus, this check has been temporarily removed until the back-end bug has been fixed. Bug: 870069 , 824568 Change-Id: Ie748e5d662a9ea00cf1b5e6a42fc8354c986d61e Reviewed-on: https://chromium-review.googlesource.com/1192417 Reviewed-by: James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#586767} [modify] https://crrev.com/584682e4a91134bd74ad691d4c1b68f65c7da401/chromeos/services/multidevice_setup/host_verifier_impl.cc [modify] https://crrev.com/584682e4a91134bd74ad691d4c1b68f65c7da401/chromeos/services/multidevice_setup/host_verifier_impl_unittest.cc [modify] https://crrev.com/584682e4a91134bd74ad691d4c1b68f65c7da401/components/cryptauth/remote_device_cache.cc [modify] https://crrev.com/584682e4a91134bd74ad691d4c1b68f65c7da401/components/cryptauth/remote_device_cache_unittest.cc
,
Aug 28
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by khorimoto@chromium.org
, Aug 1