New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870069 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add "forget phone" option in settings

Project Member Reported by khorimoto@chromium.org, Aug 1

Issue description

This would allow users to disable Better Together on the laptop side.

 
Cc: jessejames@chromium.org shibasheikh@chromium.org elizabethchiu@chromium.org
Labels: OS-Chrome
Status: Started (was: Available)
Owner: jordynass@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 13

Owner: ----
Status: Available (was: Started)
Tasks remaining:
(1) Add "forget device" dialog. When the "forget device" row is clicked, show the dialog.
(2) Add BrowserProxy integration; when "confirm" button of the dialog is clicked, make the call to the service to remove the current host, then close the dialog.
Owner: khorimoto@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1543d070959e45d46554c8bb616ffb60cb04427

commit f1543d070959e45d46554c8bb616ffb60cb04427
Author: Kyle Horimoto <khorimoto@google.com>
Date: Mon Aug 27 21:30:59 2018

[CrOS MultiDevice] Add ability to remove a multi-device host.

This CL:
(1) Displays a confirmation dialog when users request that the host
    device be removed.
(2) Actually removes the device as a host if the user confirms their
    intention to forget the current device.

Note: As part of this change, I've moved some strings from
chromeos_strings.grdp to settings_strings.grdp, since the strings are
displayed in the settings page.

Bug:  870069 , 824568
Change-Id: Ifd9fb275fa385d4fcc45cd4d8000c4534cd3c14b
Reviewed-on: https://chromium-review.googlesource.com/1191523
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586421}
[modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/app/settings_strings.grdp
[modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/resources/settings/multidevice_page/multidevice_browser_proxy.js
[modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/resources/settings/multidevice_page/multidevice_page.js
[modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.html
[modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.js
[modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc
[modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.h
[modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/ui/webui/settings/chromeos/multidevice_handler_unittest.cc
[modify] https://crrev.com/f1543d070959e45d46554c8bb616ffb60cb04427/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/584682e4a91134bd74ad691d4c1b68f65c7da401

commit 584682e4a91134bd74ad691d4c1b68f65c7da401
Author: Kyle Horimoto <khorimoto@google.com>
Date: Tue Aug 28 17:28:20 2018

[CrOS MultiDevice] Fix two bugs related to removing the host device.

(1) HostVerifierImpl::IsHostVerified() returned true if the device had
    previously been verified but was pending removal. If a device is
    pending removal, the user has explicitly requested that it be
    removed as the host device, so it should not be considered verified.
(2) RemoteDeviceCache::SetRemoteDevices() skipped overwriting device
    metadata if that data was not newer than the previously-stored data.
    However, there is currently a bug on the CryptAuth back-end which
    does not update the device metadata update time when a feature has
    been changed from supported to enabled or vice versa. Thus, this
    check has been temporarily removed until the back-end bug has been
    fixed.

Bug:  870069 , 824568
Change-Id: Ie748e5d662a9ea00cf1b5e6a42fc8354c986d61e
Reviewed-on: https://chromium-review.googlesource.com/1192417
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586767}
[modify] https://crrev.com/584682e4a91134bd74ad691d4c1b68f65c7da401/chromeos/services/multidevice_setup/host_verifier_impl.cc
[modify] https://crrev.com/584682e4a91134bd74ad691d4c1b68f65c7da401/chromeos/services/multidevice_setup/host_verifier_impl_unittest.cc
[modify] https://crrev.com/584682e4a91134bd74ad691d4c1b68f65c7da401/components/cryptauth/remote_device_cache.cc
[modify] https://crrev.com/584682e4a91134bd74ad691d4c1b68f65c7da401/components/cryptauth/remote_device_cache_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment