New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870064 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Setup Flow: "Settings" link does not work

Project Member Reported by khorimoto@chromium.org, Aug 1

Issue description

Shown on "setup completed" page.
 
Cc: jessejames@chromium.org shibasheikh@chromium.org elizabethchiu@chromium.org
Owner: jordynass@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a461b0056015659a36bf7b04b482a5f3e8cddaf

commit 1a461b0056015659a36bf7b04b482a5f3e8cddaf
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Thu Aug 30 02:34:52 2018

[CrOS MultiDevice]: Build handler to allow setup flow to open Settings

The MultiDevice setup flow's success page has a link that is supposed
to open the MultiDevice Features Settings UI subpage. Allowing the link
to do that involved adding a browserProxy to the setup flow folder
(chrome/browser/resources/chromeos/multidevice_setup). On the C++ side
this required a handler for the browserProxy's chrome.send call.

Bug:  870064 
Change-Id: I6d2e2ba8690759c0a6682dd57bc104743e940520
Reviewed-on: https://chromium-review.googlesource.com/1192210
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587425}
[modify] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/browser/resources/chromeos/multidevice_setup/BUILD.gn
[add] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_browser_proxy.html
[add] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_browser_proxy.js
[modify] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_resources.grd
[modify] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/browser/resources/chromeos/multidevice_setup/setup_succeeded_page.html
[modify] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/browser/resources/chromeos/multidevice_setup/setup_succeeded_page.js
[modify] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_dialog.cc
[add] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_handler.cc
[add] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_handler.h
[modify] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/common/webui_url_constants.h
[modify] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/test/data/webui/multidevice_setup/multidevice_setup_browsertest.js
[modify] https://crrev.com/1a461b0056015659a36bf7b04b482a5f3e8cddaf/chrome/test/data/webui/multidevice_setup/setup_succeeded_page_test.js

Status: Fixed (was: Started)

Sign in to add a comment