New issue
Advanced search Search tips

Issue 870062 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Show focus ring on readOnly elements

Project Member Reported by robdodson@chromium.org, Aug 1

Issue description

Chrome Version: 67.0.3396.99 (Official Build) (64-bit)
OS: Mac OS X

What steps will reproduce the problem?
(1) Tab through the elements in this jsbin: http://output.jsbin.com/cikozaliqu
(2) The readOnly <input> receives focus, but does not display a focus indicator of any kind.

What is the expected result?

The <input readOnly> should show a focus indicator. Otherwise, focus just seems to disappear.

What happens instead?

The element is focused, but the focus indicator disappears.
 
This is WAI according to this ancient WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=8705

Unfortunately the bug doesn't give any reasoning as to why this is intended behaviour.
Firefox also doesn't show a focus indicator.

data:text/html,<input/><input readonly/><input/>
andruud@ may I ask which version of Firefox you've tested with? 

Tested Firefox 61.0.2 (64-bit) and Firefox Nightly 63.0a1 (2018-08-26) (64-bit): both add the focus ring for readonly element.
#3 I don't see the focus ring in Firefox 61 or 63. Can you send screenshots of what you see?
ff61.png
45.4 KB View Download
ff63.png
27.7 KB View Download
Screen Shot 2018-08-28 at 8.10.00 PM.png
115 KB View Download
Screen Shot 2018-08-28 at 8.11.42 PM.png
116 KB View Download
Screen Shot 2018-08-28 at 8.13.28 PM.png
323 KB View Download
Screen Shot 2018-08-28 at 8.14.28 PM.png
326 KB View Download
Ok, you are on windows, and I'm on mac. Now, I test it on Windows and it matches with your observation.

Firefox behaviour on Windows and Mac is different.
Owner: dmazz...@chromium.org
Status: Started (was: Untriaged)
Let's just fix it.

https://chromium-review.googlesource.com/c/chromium/src/+/1213311

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31f68667f6fdc4a2b7667642cb1480d7f255bebb

commit 31f68667f6fdc4a2b7667642cb1480d7f255bebb
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Sep 10 20:31:47 2018

Show a focus ring when a readonly text field is focused.

The previous behavior was deliberate but dates back to this 2006
WebKit bug without any clear rationale:
https://bugs.webkit.org/show_bug.cgi?id=8705

In the absence of a strong argument in favor of this behavior,
we should do what's better for users and show the focus ring.

Bug:  870062 
Change-Id: I6c1c427d05270a69d4ded74f68704d78b78c3095
Reviewed-on: https://chromium-review.googlesource.com/1213311
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590043}
[add] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/fast/forms/text/input-readonly-focus-ring-expected.html
[add] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/fast/forms/text/input-readonly-focus-ring.html
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[delete] https://crrev.com/2614a046aeb1935f31b11491fe7e98c1df61733e/third_party/WebKit/LayoutTests/platform/linux/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/text/input-appearance-readonly-expected.png
[add] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/win/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-readonly-autoscroll-expected.png
[delete] https://crrev.com/2614a046aeb1935f31b11491fe7e98c1df61733e/third_party/WebKit/LayoutTests/platform/win7/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/31f68667f6fdc4a2b7667642cb1480d7f255bebb/third_party/blink/renderer/core/css/html.css

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/474b3cf607a32dcc703ffdd801f1b818c84954fc

commit 474b3cf607a32dcc703ffdd801f1b818c84954fc
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Sep 11 00:57:16 2018

Revert "Show a focus ring when a readonly text field is focused."

This reverts commit 31f68667f6fdc4a2b7667642cb1480d7f255bebb.

Reason for revert: Due to fast/forms/text/input-appearance-readonly.html failures on Mac10.13 Tests (dbg).
https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.13%20Tests%20%28dbg%29/builds/5205

Original change's description:
> Show a focus ring when a readonly text field is focused.
> 
> The previous behavior was deliberate but dates back to this 2006
> WebKit bug without any clear rationale:
> https://bugs.webkit.org/show_bug.cgi?id=8705
> 
> In the absence of a strong argument in favor of this behavior,
> we should do what's better for users and show the focus ring.
> 
> Bug:  870062 
> Change-Id: I6c1c427d05270a69d4ded74f68704d78b78c3095
> Reviewed-on: https://chromium-review.googlesource.com/1213311
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590043}

TBR=dmazzoni@chromium.org,alancutter@chromium.org

Change-Id: I4e4270d3d62350bf037b1103ebffd578e819474e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  870062 
Reviewed-on: https://chromium-review.googlesource.com/1217645
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590149}
[delete] https://crrev.com/88f04dadaa9dd87473e191f3ae8d3f6dbae2c212/third_party/WebKit/LayoutTests/fast/forms/text/input-readonly-focus-ring-expected.html
[delete] https://crrev.com/88f04dadaa9dd87473e191f3ae8d3f6dbae2c212/third_party/WebKit/LayoutTests/fast/forms/text/input-readonly-focus-ring.html
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[add] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/linux/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/text/input-appearance-readonly-expected.png
[delete] https://crrev.com/88f04dadaa9dd87473e191f3ae8d3f6dbae2c212/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/win/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-readonly-autoscroll-expected.png
[add] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/WebKit/LayoutTests/platform/win7/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/474b3cf607a32dcc703ffdd801f1b818c84954fc/third_party/blink/renderer/core/css/html.css

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dd105a12155a48bb58734c7add6c958533ee095

commit 0dd105a12155a48bb58734c7add6c958533ee095
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Sep 12 01:06:33 2018

Re-land: Show a focus ring when a readonly text field is focused.

Original: crrev.com/c/1213311
Revert: crrev.com/c/1217645

(Issue was just with a mac10.13 expectation)

The previous behavior was deliberate but dates back to this 2006
WebKit bug without any clear rationale:
https://bugs.webkit.org/show_bug.cgi?id=8705

In the absence of a strong argument in favor of this behavior,
we should do what's better for users and show the focus ring.

TBR=alancutter@chromium.org

Bug:  870062 
Change-Id: I2d413cec6cd94528f5f99852896a99ea68b4bdb7
Reviewed-on: https://chromium-review.googlesource.com/1220169
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590558}
[add] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/fast/forms/text/input-readonly-focus-ring-expected.html
[add] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/fast/forms/text/input-readonly-focus-ring.html
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[delete] https://crrev.com/f9e9e682ebb55a57f33f266817758f370418203a/third_party/WebKit/LayoutTests/platform/linux/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/text/input-appearance-readonly-expected.png
[add] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac-mac10.13/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-readonly-autoscroll-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/win/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-appearance-readonly-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-readonly-autoscroll-expected.png
[delete] https://crrev.com/f9e9e682ebb55a57f33f266817758f370418203a/third_party/WebKit/LayoutTests/platform/win7/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/0dd105a12155a48bb58734c7add6c958533ee095/third_party/blink/renderer/core/css/html.css

Sign in to add a comment