New issue
Advanced search Search tips

Issue 870036 link

Starred by 1 user
Status: Started
Owner:
m...@chromium.org
Cc:
mfo...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 810131



Sign in to add a comment

Clean-up/Refactor the GLHelper dumping ground into separate, reusable components

Project Member Reported by m...@chromium.org, Aug 1 
Over the years, GLHelper has become a dumping ground for a myriad of GL utility functions, in addition to rather large components like scaling, YUV conversion, and texture readback. Also, many of its methods are either: 1) no longer called by anything; 2) only used/useful by one specific caller. Furthermore, GLHelper has a very brittle memory-management model, where all objects it creates assume their GLHelper "parent" will outlive them (but in subtle cases, it does not!).

This bug is to track the major "sprucing-up" of GLHelper:

1. Remove dead code. Push-out trivial methods, or "one caller" methods that don't justify a central, shared location.
2. Update style, and improve/modernize readability.
3. Fix memory management/lifecycle issues so that clients "can't easily go wrong."
4. Factor-out scaling, YUV conversion, and readback into separate things.
5. Refactor/Improve unit testing, benchmarking, etc.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce16b97a0b795a64e8e145304cb9af82d2647e92

commit ce16b97a0b795a64e8e145304cb9af82d2647e92
Author: Yuri Wiitala <miu@chromium.org>
Date: Sat Aug 04 03:27:10 2018

Remove unhelpful things from GLHelper.

As part of the major clean-up/refactoring of the legacy GLHelper code,
this change addresses the "low-hanging fruit."

1. Removed dead code. Removed support for image formats that callers
never use, such as RGB565.

2. Moved-out trivial one-liners and most methods having only one caller
(where the justification for a centralized/shared utility method is
doubtful).

3. base::Callback → base::OnceCallback migration foo.

4. Deleted GLHelperReadbackSupport, and added some simple "GL_BGRA_EXT
preference" code (the only use case was internal gl_helper.cc code).

5. Removed several dependencies on GLHelper (mainly, in
content/browser/compositor) that were no longer needed.

Testing: Existing unit tests run through most of the code. Also,
manually tested the HTML Canvas Video Capture feature to double-check
BGRA readback code changes.

Bug: 870036
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I759f8cf342b30e151d121c2929ed5456185e73a3
Reviewed-on: https://chromium-review.googlesource.com/1159739
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580738}
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/common/BUILD.gn
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/common/gl_helper.cc
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/common/gl_helper.h
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/common/gl_helper_benchmark.cc
[delete] https://crrev.com/77b5c42d14ae45e36618a94bfe77a56c92ccef54/components/viz/common/gl_helper_readback_support.cc
[delete] https://crrev.com/77b5c42d14ae45e36618a94bfe77a56c92ccef54/components/viz/common/gl_helper_readback_support.h
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/common/gl_helper_scaling.cc
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/common/gl_helper_unittest.cc
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/service/display_embedder/buffer_queue.cc
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/service/display_embedder/buffer_queue.h
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/service/display_embedder/buffer_queue_unittest.cc
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/service/display_embedder/gl_output_surface_buffer_queue.cc
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/components/viz/service/display_embedder/gl_output_surface_buffer_queue.h
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/content/browser/compositor/image_transport_factory_browsertest.cc
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/content/browser/compositor/owned_mailbox.cc
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/content/browser/compositor/owned_mailbox.h
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/content/browser/compositor/reflector_texture.cc
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/content/browser/compositor/reflector_texture.h
[modify] https://crrev.com/ce16b97a0b795a64e8e145304cb9af82d2647e92/content/browser/webrtc/webrtc_video_capture_service_browsertest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cc04d3302503238bd6a70ac8f0402351e1916a1

commit 9cc04d3302503238bd6a70ac8f0402351e1916a1
Author: Yuri Wiitala <miu@chromium.org>
Date: Wed Aug 08 00:17:23 2018

Remove unused GLHelper from content::ImageTransportFactory

Removed GetGLHelper() from ImageTransportFactory now that nothing is
using it. Also, removed some gl_helper.h #includes from modules where
it's not being used.

Bug: 870036
Change-Id: Ie632ddfbf9e73fe00db6992499b9d54fe529f4af
Reviewed-on: https://chromium-review.googlesource.com/1166219
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581409}
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/compositor/image_transport_factory.h
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/compositor/image_transport_factory_browsertest.cc
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/compositor/test/test_image_transport_factory.cc
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/compositor/test/test_image_transport_factory.h
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/compositor/viz_process_transport_factory.cc
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/compositor/viz_process_transport_factory.h
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/renderer_host/media/video_capture_controller.cc
[modify] https://crrev.com/9cc04d3302503238bd6a70ac8f0402351e1916a1/content/browser/renderer_host/render_widget_host_view_aura.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35735c3d318b33b6b71102c2cd70c4775153955e

commit 35735c3d318b33b6b71102c2cd70c4775153955e
Author: Yuri Wiitala <miu@chromium.org>
Date: Fri Sep 07 21:47:05 2018

Introduce new GLScaler (API only) to replace GLHelper+GLHelperScaler.

Introduces the "outer shell" API to for GLScaler, with upcoming patches
coming soon to fill-in the rest of the implementation. This is a major
refactoring of GLHelper+GLHelperScaler to: 1) fix dangerous memory
management issues, 2) provide a cleaner interface for client-side code,
3) unblock performance and color management efforts.

Bug: 870036,758057
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ib8f0ed9b988bfe914bd8983940b089262543e8c7
Reviewed-on: https://chromium-review.googlesource.com/1194783
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589674}
[modify] https://crrev.com/35735c3d318b33b6b71102c2cd70c4775153955e/components/viz/common/BUILD.gn
[modify] https://crrev.com/35735c3d318b33b6b71102c2cd70c4775153955e/components/viz/common/DEPS
[add] https://crrev.com/35735c3d318b33b6b71102c2cd70c4775153955e/components/viz/common/gl_scaler.cc
[add] https://crrev.com/35735c3d318b33b6b71102c2cd70c4775153955e/components/viz/common/gl_scaler.h
[add] https://crrev.com/35735c3d318b33b6b71102c2cd70c4775153955e/components/viz/common/gl_scaler_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f30893706ce652e0ef959165a5d7f173142bb6e

commit 0f30893706ce652e0ef959165a5d7f173142bb6e
Author: Yuri Wiitala <miu@chromium.org>
Date: Thu Sep 13 19:45:22 2018

GLScaler: Add shader programs and tests.

Refactors and cleans-up the code related to the GLHelperScalar shader
programs and adds it to GLScaler. Also, unit testing of the shader
programs was non-existent (only higher-level integration testing was
being done), so much of this CL is about adding testing for each of
them to confirm correct behaviors.

Bug: 870036
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I7714b7cf6ebef2cd2778ba146728e6d225b1467a
Reviewed-on: https://chromium-review.googlesource.com/1214662
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591118}
[modify] https://crrev.com/0f30893706ce652e0ef959165a5d7f173142bb6e/components/viz/common/BUILD.gn
[modify] https://crrev.com/0f30893706ce652e0ef959165a5d7f173142bb6e/components/viz/common/DEPS
[modify] https://crrev.com/0f30893706ce652e0ef959165a5d7f173142bb6e/components/viz/common/gl_scaler.cc
[modify] https://crrev.com/0f30893706ce652e0ef959165a5d7f173142bb6e/components/viz/common/gl_scaler.h
[add] https://crrev.com/0f30893706ce652e0ef959165a5d7f173142bb6e/components/viz/common/gl_scaler_shader_pixeltest.cc
[add] https://crrev.com/0f30893706ce652e0ef959165a5d7f173142bb6e/components/viz/common/gl_scaler_test_util.cc
[add] https://crrev.com/0f30893706ce652e0ef959165a5d7f173142bb6e/components/viz/common/gl_scaler_test_util.h

Comment 5 by m...@chromium.org, Oct 17

Blocking: 810131
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be20a16ab6bfe13733285f06980fb5fc7ca4d1ba

commit be20a16ab6bfe13733285f06980fb5fc7ca4d1ba
Author: Yuri Wiitala <miu@chromium.org>
Date: Fri Oct 19 22:59:14 2018

GLScaler: Add scaler stages and overscan pixel tests.

Refactors and cleans-up code, transforming GLHelperScaling's internal
"ScalerImpl" class into a GLScaler::ScalerStage class. A ScalerStage
chains together with other ScalerStages to perform each step from the
source input to ultimate scaled output. (A future change will provide
the logic for deciding how to create/configure ScalerStages and chain
them together.)

A major change other than the refactoring: The math that calculates each
shader's "overscan" padding has been revisited and corrected. New math
is included in this change, along with pixel tests that confirm it is
correct (i.e., tests the math, but also runs the shader programs to
prove the numbers jive).

Bug: 870036
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I3dbbbb8f8cca45006895faed6d7501ceab5cc1cb
Reviewed-on: https://chromium-review.googlesource.com/c/1285328
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601341}
[modify] https://crrev.com/be20a16ab6bfe13733285f06980fb5fc7ca4d1ba/components/viz/common/BUILD.gn
[modify] https://crrev.com/be20a16ab6bfe13733285f06980fb5fc7ca4d1ba/components/viz/common/gl_scaler.cc
[modify] https://crrev.com/be20a16ab6bfe13733285f06980fb5fc7ca4d1ba/components/viz/common/gl_scaler.h
[add] https://crrev.com/be20a16ab6bfe13733285f06980fb5fc7ca4d1ba/components/viz/common/gl_scaler_overscan_pixeltest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/917e3cae73cb6156ef6adc760f5d224fa6b349fb

commit 917e3cae73cb6156ef6adc760f5d224fa6b349fb
Author: Yuri Wiitala <miu@chromium.org>
Date: Fri Oct 26 22:53:13 2018

GLScaler: Fix detection and use of half-floats.

Fixes GLScaler::SupportsPreciseColorManagement() by using GL extension
strings to detect the required GLES2 extensions. Also, use of half-
floats in textures is governed by the "type" argument to glTexImage2d(),
and not the "internal format" argument.

Bug: 870036
Change-Id: I67e90cbadeb0b185025bce01c56b0f9e89e70a71
Reviewed-on: https://chromium-review.googlesource.com/c/1298643
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603236}
[modify] https://crrev.com/917e3cae73cb6156ef6adc760f5d224fa6b349fb/components/viz/common/gl_scaler.cc
[modify] https://crrev.com/917e3cae73cb6156ef6adc760f5d224fa6b349fb/components/viz/common/gl_scaler.h
[modify] https://crrev.com/917e3cae73cb6156ef6adc760f5d224fa6b349fb/components/viz/common/gl_scaler_overscan_pixeltest.cc
[modify] https://crrev.com/917e3cae73cb6156ef6adc760f5d224fa6b349fb/components/viz/common/gl_scaler_shader_pixeltest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f26763fc6f340f920646b819d305717c478a489b

commit f26763fc6f340f920646b819d305717c478a489b
Author: Yuri Wiitala <miu@chromium.org>
Date: Tue Oct 30 03:06:46 2018

GLScaler: Build ScalerStage chains and add pixel tests.

Adds the implementation that determines which shader programs to use,
and in what order, to execute scaling and format conversion. Also, adds
pixel tests to check all the various features provided by GLScaler (via
its Parameters).

Bug: 870036
Change-Id: I7cb1d64d6df79a3a6221c2ab6cdf4b504b26c5b1
Reviewed-on: https://chromium-review.googlesource.com/c/1298737
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603762}
[modify] https://crrev.com/f26763fc6f340f920646b819d305717c478a489b/components/viz/common/BUILD.gn
[modify] https://crrev.com/f26763fc6f340f920646b819d305717c478a489b/components/viz/common/gl_scaler.cc
[modify] https://crrev.com/f26763fc6f340f920646b819d305717c478a489b/components/viz/common/gl_scaler.h
[add] https://crrev.com/f26763fc6f340f920646b819d305717c478a489b/components/viz/common/gl_scaler_pixeltest.cc
[modify] https://crrev.com/f26763fc6f340f920646b819d305717c478a489b/components/viz/common/gl_scaler_shader_pixeltest.cc
[modify] https://crrev.com/f26763fc6f340f920646b819d305717c478a489b/components/viz/common/gl_scaler_test_util.cc
[modify] https://crrev.com/f26763fc6f340f920646b819d305717c478a489b/components/viz/common/gl_scaler_test_util.h
[modify] https://crrev.com/f26763fc6f340f920646b819d305717c478a489b/components/viz/common/gl_scaler_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bac8fb474b3b5d5b054350a1c2e28f5e78e6ecf

commit 8bac8fb474b3b5d5b054350a1c2e28f5e78e6ecf
Author: Yuri Wiitala <miu@chromium.org>
Date: Tue Oct 30 05:36:58 2018

GLScaler: Add gamma-aware scaling, for improved color accuracy.

Adds the implementation to support gamma-aware scaling: It uses half-
floats to increase the precision of the color values, and adds an
"import stage" to linearize the color values before any texture sampling
or scaling occurs.

Added a pixel test to prove the gamma-aware versus non-gamma-aware
configuration of GLScaler produces the expected results.

Bug: 870036,  810131 
Change-Id: Ie68121add789169dbda0a578f03a257d089d4f6c
Reviewed-on: https://chromium-review.googlesource.com/c/1297540
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603797}
[modify] https://crrev.com/8bac8fb474b3b5d5b054350a1c2e28f5e78e6ecf/components/viz/common/DEPS
[modify] https://crrev.com/8bac8fb474b3b5d5b054350a1c2e28f5e78e6ecf/components/viz/common/gl_scaler.cc
[modify] https://crrev.com/8bac8fb474b3b5d5b054350a1c2e28f5e78e6ecf/components/viz/common/gl_scaler_pixeltest.cc
[modify] https://crrev.com/8bac8fb474b3b5d5b054350a1c2e28f5e78e6ecf/components/viz/common/gl_scaler_test_util.cc
[modify] https://crrev.com/8bac8fb474b3b5d5b054350a1c2e28f5e78e6ecf/components/viz/common/gl_scaler_test_util.h
[add] https://crrev.com/8bac8fb474b3b5d5b054350a1c2e28f5e78e6ecf/components/viz/test/data/rasp-grayator-half.png
[add] https://crrev.com/8bac8fb474b3b5d5b054350a1c2e28f5e78e6ecf/components/viz/test/data/rasp-grayator.png
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bb8b5625a427f8953c18d829af14aae824e525a

commit 8bb8b5625a427f8953c18d829af14aae824e525a
Author: Yuri Wiitala <miu@chromium.org>
Date: Thu Nov 15 00:10:07 2018

Add GLI420Converter: Uses GLScaler to produce I420 video images.

This is the replacement for GLHelper::I420Converter. It uses the new
GLScaler to efficiently scale and re-format RGBA textures into I420
image planes. In a soon-upcoming CL, GLRendererCopier will be switched
over to use this.

Includes unit and pixel testing.

Bug: 870036,  810131 
Change-Id: I465eb933e7eadeb205676211432cced361a3739b
Reviewed-on: https://chromium-review.googlesource.com/c/1330830
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608182}
[modify] https://crrev.com/8bb8b5625a427f8953c18d829af14aae824e525a/components/viz/common/BUILD.gn
[add] https://crrev.com/8bb8b5625a427f8953c18d829af14aae824e525a/components/viz/common/gl_i420_converter.cc
[add] https://crrev.com/8bb8b5625a427f8953c18d829af14aae824e525a/components/viz/common/gl_i420_converter.h
[add] https://crrev.com/8bb8b5625a427f8953c18d829af14aae824e525a/components/viz/common/gl_i420_converter_pixeltest.cc
[add] https://crrev.com/8bb8b5625a427f8953c18d829af14aae824e525a/components/viz/common/gl_i420_converter_unittest.cc
[modify] https://crrev.com/8bb8b5625a427f8953c18d829af14aae824e525a/components/viz/common/gl_scaler.cc
[modify] https://crrev.com/8bb8b5625a427f8953c18d829af14aae824e525a/components/viz/common/gl_scaler.h
[modify] https://crrev.com/8bb8b5625a427f8953c18d829af14aae824e525a/components/viz/common/gl_scaler_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82751409267d5f4bfc718aebb728ae42f04e2ba6

commit 82751409267d5f4bfc718aebb728ae42f04e2ba6
Author: Yuri Wiitala <miu@chromium.org>
Date: Tue Nov 27 06:16:51 2018

GLRendererCopier: Replace use of GLHelper with GLScaler/GLI420Converter.

Switches-over GLRendererCopier to use the new GLScaler and
GLI420Converter when scaling and/or format-converting images for
CopyOutputRequests. This change also addresses:

1. Simpler handling of cached GL resources (used across copy requests
having the same requester). Rather than separate methods for each of the
possible cached resources (with some duplicated logic), there is now one
"ReusableThings" struct to hold them all (and is passed around on the
stack).

2. Simplified the I420 code around handling of "packed textures" and
"aligned rects".

3. Simplified the detection/execution of whether to byte-swizzle on the
CPU (after readback) or GPU (before readback). Simplified the RGBA
bitmap copy-from-pixel-buffer code (w.r.t. upside-down row-by-row copy
and byte-swizzling).

Testing: Confirmed existing unit and pixel tests are thoroughly-testing
all possible code paths in GLRendererCopier. Manually confirmed tab and
desktop capture (incl. CrOS), and screenshots work.

Performance improvement: A local run of performance_browser_tests, on a
machine with a high-end nVidia GPU, has shown a ~20% improvement in
capture latency (i.e., the interval of time from when copy request was
issued until an SkBitmap result is ready in system memory).
http://chromeperf.appspot.com/ will reveal how other platform
configurations are affected.

Bug: 870036, 810131 , 781986 ,758057
Binary-Size: Increase is temporary (linking in new impl, future CLs will switch-over other clients to stop using old impl).
Change-Id: Ibcb16c1382ea0cffb00bc7605e0594b1fe28356a
Reviewed-on: https://chromium-review.googlesource.com/c/1343247
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611027}
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/common/gl_scaler.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/common/gl_scaler_pixeltest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/service/display/copy_output_scaling_pixeltest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/service/display/gl_renderer_copier.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/service/display/gl_renderer_copier.h
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/service/display/gl_renderer_copier_pixeltest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/components/viz/service/display/gl_renderer_copier_unittest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/content/browser/media/capture/fake_video_capture_stack.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/content/browser/media/capture/frame_test_util.h
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/content/browser/media/capture/web_contents_video_capture_device_browsertest.cc
[modify] https://crrev.com/82751409267d5f4bfc718aebb728ae42f04e2ba6/content/browser/renderer_host/render_widget_host_view_browsertest.cc
►

Sign in to add a comment