New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870016 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

pre-upload.py yells about long lines in Python files after disabling pylint check

Project Member Reported by derat@chromium.org, Aug 1

Issue description

I got errors when trying to upload https://crrev.com/c/1146146 even after disabling the pylint line-too-long check:

        Errors:
            * Found lines longer than 80 characters (first 5 shown):
                * /usr/local/google/home/derat/chromeos/chromite/config/chromeos_config.py, line 2698, 83 chars
                * /usr/local/google/home/derat/chromeos/chromite/config/chromeos_config.py, line 2699, 88 chars
                * /usr/local/google/home/derat/chromeos/chromite/config/chromeos_config.py, line 2700, 97 chars
                * /usr/local/google/home/derat/chromeos/chromite/config/chromeos_config.py, line 2701, 91 chars
                * /usr/local/google/home/derat/chromeos/chromite/config/chromeos_config.py, line 2702, 97 chars

It looks like the check is being done by //src/repohooks/pre-upload.py. Can we disable this check, at least for Python and C++?
 
Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>Build
Status: Available (was: Untriaged)
yes, this is a sep "_check_no_long_lines" that pre-upload.py has that is independent of any other linter.

there is no guarantee we run `cros lint` in repos currently.  turning it on everywhere atm might not be good because there's no way to disable specific linters on a per-repo basis (e.g. cpplint or pylint).  so we're kind of in this in-between limbo situation.
Cc: cjmcdonald@chromium.org

Sign in to add a comment