New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 869978 link

Starred by 1 user
Status: Verified
Owner:
lijeffrey@chromium.org
Closed: Aug 2
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - user parent_mastername and parent_buildername when querying isolated target indexing service

Project Member Reported by lijeffrey@chromium.org, Aug 1 
IsolatedTarget uses a master/builder's parent_mastername and parent_buildername when storing fields. Those should be used when querying instead of the raw master_name and raw builder_name
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/530dae038f439c4a61cac655d6f642bb86fe9ea5

commit 530dae038f439c4a61cac655d6f642bb86fe9ea5
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed Aug 01 21:09:02 2018

[Findit] Flake Analyzer - Use parent_mastername/buildername when querying IsolatedTarget

IsolatedTarget stores parent_mastername and parent_buildername, not raw master_name/builder_name.
Querying by the wrong type of master/builder results in IsolatedTargets not being found.

Bug:  869978 
Change-Id: Ic295c9f70d95c6c1b75229189c32b9d1fde417a6
Reviewed-on: https://chromium-review.googlesource.com/1159177
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/530dae038f439c4a61cac655d6f642bb86fe9ea5/appengine/findit/pipelines/flake_failure/next_commit_position_pipeline.py
[modify] https://crrev.com/530dae038f439c4a61cac655d6f642bb86fe9ea5/appengine/findit/pipelines/flake_failure/test/get_isolate_sha_pipeline_test.py
[modify] https://crrev.com/530dae038f439c4a61cac655d6f642bb86fe9ea5/appengine/findit/pipelines/flake_failure/test/next_commit_position_pipeline_test.py
[modify] https://crrev.com/530dae038f439c4a61cac655d6f642bb86fe9ea5/appengine/findit/pipelines/flake_failure/get_isolate_sha_pipeline.py

Comment 2 by lijeffrey@chromium.org, Aug 2

Status: Verified (was: Assigned)
►

Sign in to add a comment