Simplify WebXR state machine and schedulling in VrShellGl |
|||||||
Issue description
The GvrSchedulerDelegate shouldn't shouldn't be handling the state of WebXrPresentationState. Examples include GvrSchedulerDelegate::{WebXrCancelProcessingFrameAfterTransfer,ScheduleOrCancelWebVrFrameTimeout}.
If these methods can be hosted in the WebXrPresentationState, they could be potentially be unittested.
,
Aug 1
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44042b68646ce12e216dde3164c743e22b6a7548 commit 44042b68646ce12e216dde3164c743e22b6a7548 Author: Aldo Culquicondor <acondor@chromium.org> Date: Thu Aug 02 18:43:27 2018 WebXR: Do deferred processing in the WebXR state machine Bug: 869975 Change-Id: I4c3cb4c46372caa64bea6bbc1126743aa27b64ca Reviewed-on: https://chromium-review.googlesource.com/1158971 Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#580265} [modify] https://crrev.com/44042b68646ce12e216dde3164c743e22b6a7548/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/44042b68646ce12e216dde3164c743e22b6a7548/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/44042b68646ce12e216dde3164c743e22b6a7548/chrome/browser/android/vr/web_xr_presentation_state.cc [modify] https://crrev.com/44042b68646ce12e216dde3164c743e22b6a7548/chrome/browser/android/vr/web_xr_presentation_state.h
,
Sep 25
This is no longer necessary to split the former VrShellGl
,
Sep 25
,
Oct 4
,
Oct 15
,
Jan 14
Not sure what's left to do here, given the comment above.
,
Jan 15
I was a placeholder bug to improve the encapsulation between the WebXR state machine and the SchedulerDelegate. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by acondor@chromium.org
, Aug 1