New issue
Advanced search Search tips

Issue 869973 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 840063
issue 871764
issue 873234
issue 874624
issue 875223
issue 875225
issue 875239
issue 875242

Blocking:
issue 866904



Sign in to add a comment

Add a memory waterfall win/asan bot and a matching trybot

Project Member Reported by thomasanderson@chromium.org, Aug 1

Issue description

On the CQ, there's no way to test for regressions on Win ASan Release:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20ASan%20Release

A trybot should be added for this config.
 
Cc: h...@chromium.org dpranke@chromium.org infe...@chromium.org r...@chromium.org
Win Asan Release is on the (misnamed) lkgr waterfall. We probably want to add a win/asan bot to the memory waterfall instead and add an (opt-in) trybot mirroring that.

dpranke, do I need anyone (you?) to approve adding a win/asan bot to chromium.memory? If adding it is fine, should the bot use a builder/tester split like the other memory bots, or just build and swarm on one machine? Probably the latter?
You are welcome to add bots to that waterfall. 

(You need OWNERS of //testing/buildbot and //infra/config to approve adding things, obviously. Mostly that's members of Infra>Client>Chrome or myself for ops-side approval. Sometimes you also need src-side, like kbr@ for .gpu or lexan folks for .clang. .memory doesn't really have any relevant stakeholders).

The reasons to do a builder/tester split are:

1) You need to build once but run the binaries on different os/hardware configs, and you want to see the results of each config as a separate builder

2) You want the slightly faster cycle times you get for pipelining build + test on two different builders

3) You want to be able to separate out compile failures from build failures more easily and potentially get smaller build ranges for compile failures.

I expect you don't really care about any of these, and so should stick with a single builder for simplicity.
Also, please follow bit.ly/chromium-build-naming if possible to pick the name, so something like 'win-asan-release' instead of 'Win ASan Release'.

The naming standards are flawed but we're trying to follow them where we can when adding new builders, even if that means that things on a given waterfall will be inconsistently named for a while.
Summary: Add a memory waterfall win/asan bot and a matching trybot (was: Add a trybot that corresponds to "Win ASan Release")
cool, retitling
Components: -Infra Infra>Client>Chrome
Owner: thakis@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/083e6337ca4b6fba1b6e198ac5ae75f04de15e9b

commit 083e6337ca4b6fba1b6e198ac5ae75f04de15e9b
Author: Nico Weber <thakis@chromium.org>
Date: Tue Aug 07 02:08:01 2018

Add a memory waterfall win/asan bot (and matching trybot), src/ side

While here, also slightly reorganize chromium.memory console layout:
- Consistently use OS as toplevel subcategory (so that we don't have
  the cros msan bots under "linux|cros" while the cros asan bots are under
  "asan|cros"
- Order OSs in the same order as the per-os waterfalls appear on
  build.chromium.org: win, mac, linux, cros.

In mb_config.pyl, remove obsolete 'x86' from win/asan config names,
and stop explicitly passing 'x64' (it's the default).

This adds the bot config, but it doesn't add any tests yet. I'll do this
in a follow-up so that I can send try jobs before adding tests. Before
tests are landed, the bot will do nothing.

Bug:  869973 
Change-Id: I68a1a401b3fef1532006e42ab7f0e80d1532aa94
Reviewed-on: https://chromium-review.googlesource.com/1163932
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581094}
[modify] https://crrev.com/083e6337ca4b6fba1b6e198ac5ae75f04de15e9b/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/083e6337ca4b6fba1b6e198ac5ae75f04de15e9b/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/083e6337ca4b6fba1b6e198ac5ae75f04de15e9b/infra/config/global/luci-scheduler.cfg
[modify] https://crrev.com/083e6337ca4b6fba1b6e198ac5ae75f04de15e9b/tools/mb/mb_config.pyl

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a80e26da02c4bbfed468eda43ce913d50087cd16

commit a80e26da02c4bbfed468eda43ce913d50087cd16
Author: Nico Weber <thakis@chromium.org>
Date: Tue Aug 07 03:16:44 2018

Add a dummy testing/buildbot entry for the new win-asan bot.

TBR=dpranke

Bug:  869973 
Change-Id: I768bbb4ae73c52d5fbd9d91960add069eefa5fac
Reviewed-on: https://chromium-review.googlesource.com/1164642
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581116}
[modify] https://crrev.com/a80e26da02c4bbfed468eda43ce913d50087cd16/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/a80e26da02c4bbfed468eda43ce913d50087cd16/testing/buildbot/waterfalls.pyl

Blockedon: 871764
Issue 871761 has been merged into this issue.
FYI, issue 871761 - the bot probably shouldn't have been added to the main console until fully debugged, as it's confusing to sheriffs.

If you're following instructions from some LUCI / Infra doc, it would help to get it updated to avoid this issue in the future. Thanks!
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9e4ac62d69147aaff1e635925aa9d2b06968a33

commit c9e4ac62d69147aaff1e635925aa9d2b06968a33
Author: Nico Weber <thakis@chromium.org>
Date: Tue Aug 07 17:12:25 2018

Add win-asan bot in more places.

Fixes a few things I got wrong in https://chromium-review.googlesource.com/1163932

- Also add win-asan to the chromium.memory standalone console. Main waterfall
  and sub-waterfall consoles are apparently completely independent, so do the
  same bot reordering I did in the above CL here too.

- Also add win-asan to the luci.chromium.try bucket

Bug:  869973 
Change-Id: I9e32f15b2869b0adafb4f291e9e4147184baa84a
Reviewed-on: https://chromium-review.googlesource.com/1164645
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581263}
[modify] https://crrev.com/c9e4ac62d69147aaff1e635925aa9d2b06968a33/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/c9e4ac62d69147aaff1e635925aa9d2b06968a33/infra/config/global/luci-milo.cfg

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2d1eb2a4661ce48348cea64b165e8384ed0909ed

commit 2d1eb2a4661ce48348cea64b165e8384ed0909ed
Author: Nico Weber <thakis@chromium.org>
Date: Tue Aug 07 17:47:21 2018

Remove some unused GYP_DEFINE settings from recipes.

Some GYP_DEFINES are read by the recipes code and a few scripts in
src.git, but in general GYP_DEFINES should be unused now that all
waterfalls have moved off gyp. This stops setting a handful of
them that look safe to remove.

(All but the libyuv waterfalls are using mb and don't need recipe-side
gn_args either, but that's for a different day.)

Bug:  869973 
Change-Id: I05a0c12741717db4b1e9b9e81aaa42ac9f879e0e
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/1163923
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_win_with_revision.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_experimental.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_translation_unit_fail.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_forced.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_win_delete_generated_files_fail.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_compile_fail.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_generate_compile_database_fail.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/runhooks_failure_ng.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/chromium_tests/tests/api/prepare_checkout.expected/disable_tests.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_tsan2.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/findit/chromium/test.expected/none_swarming_tests.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/chromium_tests/tests/api/deapply_patch.expected/basic.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_msan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/clobber_analyze.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/findit/chromium/test.expected/compile_skipped.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android_with_revision.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/runhooks_failure.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/chromium_tests/tests/api/archive_build.expected/cf_archive_build.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_linux_test_experimental.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/findit/chromium/test.expected/nonexistent_test_step_skipped.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/chromium/config.py
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_win_delete_generated_files_fail.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/findit/chromium/test.expected/test_without_targets_not_skipped.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_win7.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks__with_patch__failure.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_asan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_win_more_configs.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_libfuzzer_clang_tot.expected/full_chromium_fyi_ClangToTLinuxASanLibfuzzer.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/update_clang.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_asan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_msan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_ubsan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/script_test_with_overridden_compile_targets.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/compile_failure_with_component_rev.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_MSan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/compile_failure_ng.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac_asan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_clang_coverage_tot.expected/full_chromium_clang_ToTMacCoverage.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_deterministic.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium.expected/dynamic_gtest_win.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot_compile_failure.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_experimental.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile_no_source.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_win.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_linux_test_basic.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_win_test_experimental.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/swarming/staging.expected/windows.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/chromium_tests/tests/api/archive_build.expected/archive_build.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan_vptr.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_gn_upload.expected/full_luci_infra_internal_prod_gn_builder_linux.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/findit/chromium/test.expected/all_test_passed.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_ubsan_vptr.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/analyze_compile_mode.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_gn_upload.expected/full_luci_infra_internal_prod_gn_builder_win.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_deterministic_fail.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gcc_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium.expected/tsan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_with_revision.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_tsan_v2.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__stable_.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_with_revision.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_rel.json
[modify] https://crrev.com/2d1eb2a4661ce48348cea64b165e8384ed0909ed/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_deappl
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7acc0647ed93242409817da664922469f3bf71f1

commit 7acc0647ed93242409817da664922469f3bf71f1
Author: Nico Weber <thakis@chromium.org>
Date: Wed Aug 08 00:05:24 2018

Remove win-asan from console view again for a bit.

Getting bots for the builder is taking longer than expected, and having a
perma-purple bot on the main waterfall isn't so great.

I'll revert this again once hardware for the builder has been allocated and
configured.

Bug:  869973 
Change-Id: I702c4694eb13cc39cc07bc01f19a6f7871e9f47c
Reviewed-on: https://chromium-review.googlesource.com/1166170
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581400}
[modify] https://crrev.com/7acc0647ed93242409817da664922469f3bf71f1/infra/config/global/luci-milo.cfg

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee0e8e41412bb95e36fc000ef91c149a16c03b9e

commit ee0e8e41412bb95e36fc000ef91c149a16c03b9e
Author: Nico Weber <thakis@chromium.org>
Date: Wed Aug 08 02:51:28 2018

Revert "Add a dummy testing/buildbot entry for the new win-asan bot."

This reverts commit a80e26da02c4bbfed468eda43ce913d50087cd16.

Reason for revert: caused  https://crbug.com/872089  via https://chromium-review.googlesource.com/c/chromium/src/+/1166170

Original change's description:
> Add a dummy testing/buildbot entry for the new win-asan bot.
> 
> TBR=dpranke
> 
> Bug:  869973 
> Change-Id: I768bbb4ae73c52d5fbd9d91960add069eefa5fac
> Reviewed-on: https://chromium-review.googlesource.com/1164642
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581116}

TBR=thakis@chromium.org,dpranke@chromium.org

Change-Id: I70e245d67eb05a2f6312ce480a0a12118da31db5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  869973 
Reviewed-on: https://chromium-review.googlesource.com/1166642
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581449}
[modify] https://crrev.com/ee0e8e41412bb95e36fc000ef91c149a16c03b9e/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/ee0e8e41412bb95e36fc000ef91c149a16c03b9e/testing/buildbot/waterfalls.pyl

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b64ee579be9b9f2dfa0af6fa611514bf3116423c

commit b64ee579be9b9f2dfa0af6fa611514bf3116423c
Author: Nico Weber <thakis@chromium.org>
Date: Wed Aug 08 19:23:24 2018

Delete some code that's dead after https://chromium-review.googlesource.com/c/chromium/tools/build/+/1163923

Bug:  869973 
Change-Id: I36efa683a6344aa4e0cd2c5e5aa91d5101d7f38a
Reviewed-on: https://chromium-review.googlesource.com/1166173
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/libyuv/builders.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/chromium_tests/chromium_lkgr.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/chromium/config.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/chromium/tests/configs.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/README.recipes.md
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/chromium_tests/chromium_clang.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipes/chromium_gn_upload.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipes/chromium_libfuzzer.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipes/blink_downstream.py
[modify] https://crrev.com/b64ee579be9b9f2dfa0af6fa611514bf3116423c/scripts/slave/recipe_modules/chromium_tests/chromium.py

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/ff5c495bb2e9d8bf9dc6ddf0d44504a822282e5f

commit ff5c495bb2e9d8bf9dc6ddf0d44504a822282e5f
Author: Nico Weber <thakis@chromium.org>
Date: Fri Aug 10 16:13:18 2018

First runs with actual bots backing the builder:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/914
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win-asan/3 (this failure will go away once the bot is in waterfalls.pyl, which is blocked on adding them to luci-milo.cfg, which is blocked on the non-trybot being consistently green)
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4ba43ad875387fe19f41a2965724a3c77208899

commit c4ba43ad875387fe19f41a2965724a3c77208899
Author: Nico Weber <thakis@chromium.org>
Date: Wed Aug 15 22:01:32 2018

Let win/asan bot set use_goma=true

Currently, the builder is configured to use goma on the recipe side but
not in mb, causing it to build with -j500 but doing local builds. The bot
running the build does not appreciate that.

Bug:  869973 
Change-Id: Id27616762caff158ad660b2b6f2d8ed42a29a41b
Reviewed-on: https://chromium-review.googlesource.com/1176269
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583412}
[modify] https://crrev.com/c4ba43ad875387fe19f41a2965724a3c77208899/tools/mb/mb_config.pyl

Blockedon: 874624
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2ffb36db9aae8cf07455bb774f0e5a805684556

commit b2ffb36db9aae8cf07455bb774f0e5a805684556
Author: Nico Weber <thakis@chromium.org>
Date: Thu Aug 16 23:34:40 2018

Revert "Remove win-asan from console view again for a bit."

This reverts commit 7acc0647ed93242409817da664922469f3bf71f1.

Reason for revert: The builder seems to work now. (Note: It currently
only compiles everything and doesn't run any tests yet.)

Original change's description:
> Remove win-asan from console view again for a bit.
> 
> Getting bots for the builder is taking longer than expected, and having a
> perma-purple bot on the main waterfall isn't so great.
> 
> I'll revert this again once hardware for the builder has been allocated and
> configured.
> 
> Bug:  869973 
> Change-Id: I702c4694eb13cc39cc07bc01f19a6f7871e9f47c
> Reviewed-on: https://chromium-review.googlesource.com/1166170
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581400}

TBR=thakis@chromium.org,dpranke@chromium.org,sergeyberezin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  869973 
Change-Id: Id4498b0cb964a22d33e5b7f76b135c8d560a7291
Reviewed-on: https://chromium-review.googlesource.com/1179001
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583883}
[modify] https://crrev.com/b2ffb36db9aae8cf07455bb774f0e5a805684556/infra/config/global/luci-milo.cfg

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9ff08ebc7c043ec4e05bc83e199f6bf876f5cef

commit a9ff08ebc7c043ec4e05bc83e199f6bf876f5cef
Author: Nico Weber <thakis@chromium.org>
Date: Fri Aug 17 02:42:28 2018

mb_config.pyl: Add win-asan bot entry for tryserver.chromium.win too.

Needed to be able to send try jobs for win-asan.

Bug:  869973 
Change-Id: I8635fb79b298596de0b4488b911f98db320b66fc
Reviewed-on: https://chromium-review.googlesource.com/1179090
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583946}
[modify] https://crrev.com/a9ff08ebc7c043ec4e05bc83e199f6bf876f5cef/tools/mb/mb_config.pyl

Blockedon: 875223
Blockedon: 875225
Status:

- There's a win-asan bot on chromium.memory and on the memory subconsole on the main waterfall

- There's a matching win-asan bot that does the same thing

- Right now, these only build and don't run tests. https://chromium-review.googlesource.com/c/chromium/src/+/1179087 tries to add them, but atm a bunch of tests are red. I'm adding blockers for these
Blockedon: 875239
Blockedon: 875242
Blockedon: 856169
Blockedon: 873234
Project Member

Comment 32 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d86e2c717780c8f629253df140e45379fd59f16f

commit d86e2c717780c8f629253df140e45379fd59f16f
Author: Nico Weber <thakis@chromium.org>
Date: Fri Aug 17 19:11:53 2018

Make win/asan main waterfall bot run tests.

Also make notification_helper_unittests run on the CrWinAsan* bots since
they now run tests on Win10 and that suite only has issues on Win7.

Some tests currently fail under asan. I'm for now not running the
suites containing these tests at all. I'll fix (or disable individual
tests) and gradually add the missing test suites:

- cc_unittests fails LayerTreeHostBlendingPixelTest,  https://crbug.com/875223 
- install_static_unittests fails GetSandboxSidPrefix,  https://crbug.com/875225 
- sbox_integration_tests fails TestAddressSanitizer,  https://crbug.com/875242 
- browser_tests (and viz_browser_tests and network_service_browser_tests)
  fail PictureInPicture ( https://crbug.com/873234 ), MouseLeave (https://crbug.com/856169)
- sync_integration_tests fails MC_MergeDifferentBMModelsModeratelyComplex,
   https://crbug.com/875239 

Bug:  869973 
Change-Id: I5173419ac0a9ed4879dcfc91614ffc335d749b04
Reviewed-on: https://chromium-review.googlesource.com/1179087
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584144}
[modify] https://crrev.com/d86e2c717780c8f629253df140e45379fd59f16f/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/d86e2c717780c8f629253df140e45379fd59f16f/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/d86e2c717780c8f629253df140e45379fd59f16f/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/d86e2c717780c8f629253df140e45379fd59f16f/testing/buildbot/waterfalls.pyl

Blockedon: 840063
Project Member

Comment 34 by bugdroid1@chromium.org, Aug 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8

commit f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8
Author: Nico Weber <thakis@chromium.org>
Date: Sun Aug 19 23:40:47 2018

Run browser_tests (and viz_browser_tests) on win/asan bot.

- PlatformAppBrowserTest.PictureInPicture consistently fails with a
  (apparently windows-only) use-after-free on win/asan. That code is new,
  so just revert it (see below),  https://crbug.com/873234 

- PDFExtensionHitTestTest.MouseLeave flakes fairly often on win/asan, so
  disable the test in that config, https://crbug.com/856169

- SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0
  fails fairly consistenly on win/asan (and elsewhere) in
  network_service_browser_tests, so don't enable that suite on the win/asan
  bot just yet (https://crbug.com/840063).

Bug:  869973 

Revert "Enable Picture-in-Picture for chrome apps."

This reverts commit e031e566fb77330da96a1415a3d08a908cc43a6e.

Reason for revert: Test has a use-after-free,  https://crbug.com/873234 

Original change's description:
> Enable Picture-in-Picture for chrome apps.
>
> This CL enables Picture-in-Picture in chrome apps by implementing
> EnterPictureInPicture and ExitPictureInPicture in AppDelegate.
>
> Bug:  863309 
> Change-Id: Ib35e83b03373abe864b3a0674ab1e0b341ce291b
> Reviewed-on: https://chromium-review.googlesource.com/1156513
> Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580497}

TBR=beaufort.francois@gmail.com,rdevlin.cronin@chromium.org,jochen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  863309 
Change-Id: Ib6eda55a3b0889646c43ea3e7bfccdb590cea0b2
Reviewed-on: https://chromium-review.googlesource.com/1180763
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584347}
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/chrome/browser/apps/platform_apps/app_browsertest.cc
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/chrome/browser/ui/apps/chrome_app_delegate.cc
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/chrome/browser/ui/apps/chrome_app_delegate.h
[delete] https://crrev.com/66d7422952a234bc2a822ca9150241b8fe6d90a4/chrome/test/data/extensions/platform_apps/picture_in_picture/bear.webm
[delete] https://crrev.com/66d7422952a234bc2a822ca9150241b8fe6d90a4/chrome/test/data/extensions/platform_apps/picture_in_picture/main.html
[delete] https://crrev.com/66d7422952a234bc2a822ca9150241b8fe6d90a4/chrome/test/data/extensions/platform_apps/picture_in_picture/main.js
[delete] https://crrev.com/66d7422952a234bc2a822ca9150241b8fe6d90a4/chrome/test/data/extensions/platform_apps/picture_in_picture/manifest.json
[delete] https://crrev.com/66d7422952a234bc2a822ca9150241b8fe6d90a4/chrome/test/data/extensions/platform_apps/picture_in_picture/test.js
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/extensions/browser/app_window/app_delegate.h
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/extensions/browser/app_window/app_window.h
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/extensions/shell/browser/shell_app_delegate.cc
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/extensions/shell/browser/shell_app_delegate.h
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/testing/buildbot/test_suite_exceptions.pyl

Status: Fixed (was: Assigned)
The bot now exists and runs all test suites that all the other win bots run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/1038
That's the main waterfall asan bot, visible on build.chromium.org and on the chromium.memory waterfall. There's a matching win-asan trybot at https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win-asan that can be triggered through the usual CHOOSE TRYBOTS gerrit ui, or via `it cl try -B luci.chromium.try -b win-asan`. (It's backed by a single bot, so if lots of people use it maybe we'll have to give it more hardware.)
Blockedon: -856169
Blocking: 866904
Cc: siggi@chromium.org kcc@chromium.org jbudorick@chromium.org
 Issue 838553  has been merged into this issue.

Sign in to add a comment