New issue
Advanced search Search tips

Issue 869966 link

Starred by 1 user
Status: Started
Owner:
schenney@chromium.org
Cc:
sadrul@chromium.org
futhark@chromium.org
tdres...@chromium.org
rmcilroy@chromium.org
chrishtr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task



Sign in to add a comment

Add Metrics for percentage of main frame time spent in document lifecycle activities

Project Member Reported by schenney@chromium.org, Aug 1 
We currently have metrics for the absolute time spent in Style and Layout, PrePaint, Paint, Intersection Observer and Blink Compositing, but we don't know what portion of the main frame time this represents.

In addition, we do not track layouts due to JS requests outside of the document lifecycle, nor the time spend in JS as part of the main frame.

The goal is to determine which sub-system is most worthy of engineering effort, and how different sites stress different portions of the system.

Concrete proposals:
- Report lifecycle update times as percentages of total frame time
- Add metrics for script execution times due to events and RAF
- Add metrics for layout driven by script, outside of document lifecycle updates
- Add a distinct metric set for page load up to first contentful paint.
- Maybe switch to a sampling base approach to understand the distributions of work across different frames.

Comment 1 by chrishtr@chromium.org, Aug 1

Cc: rmcilroy@chromium.org

Comment 2 by schenney@chromium.org, Aug 7 

Try to separate layer update actions so that we can isolate the costs of lots of layers, and avoid counting that as part of layout.

Also account for style distinct from layout.

Also deal with new CompositorCommit metrics.

Comment 3 by sadrul@chromium.org, Sep 17

Cc: sadrul@chromium.org

Comment 4 by futhark@chromium.org, Sep 24

Cc: futhark@chromium.org
FYI, I added UMA metrics for style invalidation, style recalc, and layout tree building as:

Style.InvalidationTime
Style.RecalcTime
Style.RebuildLayoutTreeTime

They measure all such updates, lifecycle related and js forced ones.

Comment 5 by schenney@chromium.org, Sep 24 

I'll look at when these trigger and see how to integrate them with the other new metrics.

UMA is way easier to add than UKM.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18c7186d821de890abcc39dfd8cc8ad5bbb28e08

commit 18c7186d821de890abcc39dfd8cc8ad5bbb28e08
Author: Stephen Chenney <schenney@chromium.org>
Date: Tue Sep 25 21:34:55 2018

Adding UKM and UMA tracking main frame task breakdown

The paint team has no insight into what proportion of the
Blink complete main frame time is spent in Blink lifecycle
operations vs. script required updates vs. other tasks.
This CL adds metrics that will allow for identifying the
proprtion of main frame time taken by various operations.

Bug: 869966
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idc73dc6efd1aef5e65df647bc48de84384dba0c8
Reviewed-on: https://chromium-review.googlesource.com/1179995
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594114}
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/cc/test/layer_tree_test.cc
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/cc/test/stub_layer_tree_host_client.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/cc/trees/layer_tree_host.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/cc/trees/layer_tree_host_client.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/cc/trees/proxy_main.cc
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/content/renderer/gpu/layer_tree_view.cc
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/content/renderer/gpu/layer_tree_view.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/content/renderer/gpu/layer_tree_view_delegate.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/content/renderer/render_widget.cc
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/content/renderer/render_widget.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/content/test/stub_layer_tree_view_delegate.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/public/web/web_widget.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/renderer/core/frame/BUILD.gn
[add] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc
[add] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/renderer/core/frame/web_view_frame_widget.cc
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/renderer/core/frame/web_view_frame_widget.h
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/tools/metrics/ukm/ukm.xml
[modify] https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08/ui/compositor/compositor.h
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0f170713d67d02d230b346d29e803a9d44aae15

commit c0f170713d67d02d230b346d29e803a9d44aae15
Author: Keishi Hattori <keishi@chromium.org>
Date: Wed Sep 26 02:28:17 2018

Revert "Adding UKM and UMA tracking main frame task breakdown"

This reverts commit 18c7186d821de890abcc39dfd8cc8ad5bbb28e08.

Reason for revert: Find-it says this caused MSAN bot failure
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/11801

Original change's description:
> Adding UKM and UMA tracking main frame task breakdown
> 
> The paint team has no insight into what proportion of the
> Blink complete main frame time is spent in Blink lifecycle
> operations vs. script required updates vs. other tasks.
> This CL adds metrics that will allow for identifying the
> proprtion of main frame time taken by various operations.
> 
> Bug: 869966
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Idc73dc6efd1aef5e65df647bc48de84384dba0c8
> Reviewed-on: https://chromium-review.googlesource.com/1179995
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Commit-Queue: Stephen Chenney <schenney@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594114}

TBR=sadrul@chromium.org,sky@chromium.org,vmpstr@chromium.org,rkaplow@chromium.org,chrishtr@chromium.org,fsamuel@chromium.org,holte@chromium.org,schenney@chromium.org

Change-Id: I1a391af1e942bc4f4c5e993b9afcbbae67ff3905
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 869966
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1243875
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594190}
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/cc/test/layer_tree_test.cc
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/cc/test/stub_layer_tree_host_client.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/cc/trees/layer_tree_host.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/cc/trees/layer_tree_host_client.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/cc/trees/proxy_main.cc
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/content/renderer/gpu/layer_tree_view.cc
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/content/renderer/gpu/layer_tree_view.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/content/renderer/gpu/layer_tree_view_delegate.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/content/renderer/render_widget.cc
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/content/renderer/render_widget.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/content/test/stub_layer_tree_view_delegate.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/third_party/blink/public/web/web_widget.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/third_party/blink/renderer/core/frame/BUILD.gn
[delete] https://crrev.com/671f7913d06e13402de1498fb6d83ef5ccc32cab/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc
[delete] https://crrev.com/671f7913d06e13402de1498fb6d83ef5ccc32cab/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/third_party/blink/renderer/core/frame/web_view_frame_widget.cc
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/third_party/blink/renderer/core/frame/web_view_frame_widget.h
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/tools/metrics/ukm/ukm.xml
[modify] https://crrev.com/c0f170713d67d02d230b346d29e803a9d44aae15/ui/compositor/compositor.h
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9879a5c7fab8f313ef9411eb4da0fb66f045c591

commit 9879a5c7fab8f313ef9411eb4da0fb66f045c591
Author: Stephen Chenney <schenney@chromium.org>
Date: Wed Sep 26 14:21:42 2018

Reland: Adding UKM and UMA tracking main frame task breakdown

The paint team has no insight into what proportion of the
Blink complete main frame time is spent in Blink lifecycle
operations vs. script required updates vs. other tasks.
This CL adds metrics that will allow for identifying the
proportion of main frame time taken by various operations.

The relanded patch fixes uninitialized variable issues.

Original review and discussion at
https://chromium-review.googlesource.com/1179995

Original patch landed at
https://crrev.com/18c7186d821de890abcc39dfd8cc8ad5bbb28e08

TBR: vmpstr@chromium.org
TBR: rkaplow@chromium.org
TBR: sadrul@chromium.org
TBR: sky@chromium.org
Bug: 869966
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0606d1075100a2fce5829e2ca0829b11fa20d62c
Reviewed-on: https://chromium-review.googlesource.com/1245922
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594304}
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/cc/test/layer_tree_test.cc
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/cc/test/stub_layer_tree_host_client.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/cc/trees/layer_tree_host.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/cc/trees/layer_tree_host_client.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/cc/trees/proxy_main.cc
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/content/renderer/gpu/layer_tree_view.cc
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/content/renderer/gpu/layer_tree_view.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/content/renderer/gpu/layer_tree_view_delegate.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/content/renderer/render_widget.cc
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/content/renderer/render_widget.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/content/test/stub_layer_tree_view_delegate.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/public/web/web_widget.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/renderer/core/frame/BUILD.gn
[add] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc
[add] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/renderer/core/frame/web_view_frame_widget.cc
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/renderer/core/frame/web_view_frame_widget.h
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/tools/metrics/ukm/ukm.xml
[modify] https://crrev.com/9879a5c7fab8f313ef9411eb4da0fb66f045c591/ui/compositor/compositor.h
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe7f8c3cc9889e4a1fd18742691d621982b2c171

commit fe7f8c3cc9889e4a1fd18742691d621982b2c171
Author: Stephen Chenney <schenney@chromium.org>
Date: Thu Sep 27 17:36:04 2018

Add UMA and UKM for forced layouts

JS calls force layout when they require layout-dependent state. This
happens outside of the document lifecycle, and is not captured by our
existing metrics. Add a new ForcedLayout metric for UMA and UKM to
track the amount of time we spend doing layouts outside of the
document lifecycle.

R=eae@chromium.org,vpmstr@chromium.org

Bug: 869966
Change-Id: I3868e1483a32163666343453204c81b9c9bbd452
Reviewed-on: https://chromium-review.googlesource.com/1228855
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594769}
[modify] https://crrev.com/fe7f8c3cc9889e4a1fd18742691d621982b2c171/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/fe7f8c3cc9889e4a1fd18742691d621982b2c171/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.h
[modify] https://crrev.com/fe7f8c3cc9889e4a1fd18742691d621982b2c171/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/fe7f8c3cc9889e4a1fd18742691d621982b2c171/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/fe7f8c3cc9889e4a1fd18742691d621982b2c171/third_party/blink/renderer/platform/ukm_time_aggregator.h
[modify] https://crrev.com/fe7f8c3cc9889e4a1fd18742691d621982b2c171/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/fe7f8c3cc9889e4a1fd18742691d621982b2c171/tools/metrics/ukm/ukm.xml
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36b96a425296231133c5228ed5ec1fea9a76fab6

commit 36b96a425296231133c5228ed5ec1fea9a76fab6
Author: Stephen Chenney <schenney@chromium.org>
Date: Fri Oct 12 20:12:24 2018

Delay UMA submission until end of lifecycle

We were submitting UMA every time we recorded a update time measurement,
but some metric, particularly ForcedStyleAndLayout, may run multiple
times per frame. In such cases we want the per lifecycle time, to make
it comparable to UKM data and to avoid considering lots of small updates
to be less bad than one big update.

R=vmpstr@chromium.org
BUG=869966

Only report UMA once per lifecycle update

Change-Id: If4eebd782b4d109b18a608ece2a351226bb74732
Reviewed-on: https://chromium-review.googlesource.com/c/1277549
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599332}
[modify] https://crrev.com/36b96a425296231133c5228ed5ec1fea9a76fab6/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/543f0bc306ba3dd2bda3162828d2b3476b63675c

commit 543f0bc306ba3dd2bda3162828d2b3476b63675c
Author: Stephen Chenney <schenney@chromium.org>
Date: Tue Oct 16 17:05:37 2018

Revert "Delay UMA submission until end of lifecycle"

This reverts commit 36b96a425296231133c5228ed5ec1fea9a76fab6.

Reason for revert: The change blew up the UMA metrics because apparently multiple lifecycle updates occur within on BeginMainFrame execution. Will reland once the problem issue is resolved, or in a different form.

Original change's description:
> Delay UMA submission until end of lifecycle
> 
> We were submitting UMA every time we recorded a update time measurement,
> but some metric, particularly ForcedStyleAndLayout, may run multiple
> times per frame. In such cases we want the per lifecycle time, to make
> it comparable to UKM data and to avoid considering lots of small updates
> to be less bad than one big update.
> 
> R=​vmpstr@chromium.org
> BUG=869966
> 
> Only report UMA once per lifecycle update
> 
> Change-Id: If4eebd782b4d109b18a608ece2a351226bb74732
> Reviewed-on: https://chromium-review.googlesource.com/c/1277549
> Commit-Queue: Stephen Chenney <schenney@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599332}

TBR=vmpstr@chromium.org,schenney@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 869966
Change-Id: I12c182fd48f4807af61dbb9a77d097fb665216ed
Reviewed-on: https://chromium-review.googlesource.com/c/1283550
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600019}
[modify] https://crrev.com/543f0bc306ba3dd2bda3162828d2b3476b63675c/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc

Comment 12 by schenney@chromium.org, Jan 17 (5 days ago)

Status: Started (was: Assigned)

Comment 13 by schenney@chromium.org, Jan 17 (5 days ago) 

Forced Layout Ratios were broken by https://chromium.googlesource.com/chromium/src/+/ec431261dbbbeccd6056339ba49c476867e3d59f

An upcoming patch will fix that, probably.
►

Sign in to add a comment