New issue
Advanced search Search tips

Issue 869958 link

Starred by 2 users
Status: Verified
Owner:
nicolaso@chromium.org
Closed: Aug 24
Cc:
pastarmovj@chromium.org
georgesak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 914423



Sign in to add a comment

Add mechanism to map extension policies to Chrome prefs

Project Member Reported by nicolaso@chromium.org, Aug 1 
We are in the process of deprecating some of our Enterprise-related extensions and baking them into Chrome.

There should be a way to map the deprecated extension policies to Chrome prefs, so that we can use them as a fallback. That way, we don't break most existing installs.

Comment 1 by pastarmovj@chromium.org, Aug 2 

It would be good to write a short one-pager about the plan and the reason behind that.

Also to make this a little less scary for the uninformed reader "deprecating" is not quite the term but rather "baking-in Chrome" :)

Comment 2 by nicolaso@chromium.org, Aug 2

Cc: georgesak@chromium.org
Good idea to have a one-pager for this. You can view it with your Chromium account:

https://docs.google.com/document/d/1_ZxQ4Rc7RIGT4NOfjhdaJJ2gSJCZIHgcwCOumjYD0Cs/edit
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f

commit a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Fri Aug 24 06:14:00 2018

Add ExtensionPolicyMigrator

It lets us migrate policies from an extension domain to the Chrome
domain. ExtensionPolicyMigrator is a callback that can be attached to a
ConfigurationPolicyProvider. It is run after the policies are refreshed, but
before OnUpdatePolicy() is triggered, and it can modify the PolicyBundle to
migrate the policies to their new domain.

See:
https://docs.google.com/document/d/1_ZxQ4Rc7RIGT4NOfjhdaJJ2gSJCZIHgcwCOumjYD0Cs/edit

Bug:  869958 
Change-Id: I2da6cf08720e73ca3589cfeaac5094d9df2d8b5c
Reviewed-on: https://chromium-review.googlesource.com/1158968
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Pam Greene (Please send IM for reviews) <pam@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585722}
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/chrome/browser/policy/chrome_browser_policy_connector.cc
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/chrome/browser/policy/policy_conversions.cc
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/chrome/browser/resources/policy.css
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/chrome/browser/resources/policy.html
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/BUILD.gn
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/configuration_policy_provider.cc
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/configuration_policy_provider.h
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/configuration_policy_provider_test.cc
[add] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/extension_policy_migrator.cc
[add] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/extension_policy_migrator.h
[add] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/extension_policy_migrator_unittest.cc
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/policy_map.cc
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/policy_map.h
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/policy_map_unittest.cc
[modify] https://crrev.com/a192e9d1ae7d6102774b0f33cdbd7330a8d5a35f/components/policy/core/common/policy_proto_decoders.cc

Comment 4 by nicolaso@chromium.org, Aug 24

Status: Verified (was: Untriaged)
►

Sign in to add a comment