New issue
Advanced search Search tips

Issue 869942 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 871301



Sign in to add a comment

Roll libaddressinput dep

Project Member Reported by rouslan@chromium.org, Aug 1

Issue description

Roll libaddressinput dep and migrate the JP profiles affected by the new version. The separate locality field was removed from JP. The value should go into the street address lines.
 
Blocking: 871301
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d53916d729f0706adf6bc55f48a92b454a4ff14c

commit d53916d729f0706adf6bc55f48a92b454a4ff14c
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Wed Aug 08 14:47:14 2018

Roll libaddressinput dep.

Roll libaddressinput dep from:
d955c63ec7048d59dffd20af25eeec23da878d27
To:
d7ed8e2f3f35ce9a3aafdfdc48745ceab66e7229

The new version of libaddressinput does not have the locality (e.g.,
city) field for JP, so the existing autofill profiles are being migrated
to merge the existing locality field into the street address line.

TBR=vitaliii

Bug:  869942 
Change-Id: I1e5859c49408490c9816840917c4b648b664a975
Reviewed-on: https://chromium-review.googlesource.com/1152068
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581558}
[modify] https://crrev.com/d53916d729f0706adf6bc55f48a92b454a4ff14c/DEPS
[modify] https://crrev.com/d53916d729f0706adf6bc55f48a92b454a4ff14c/components/autofill/core/browser/autofill_profile_unittest.cc
[modify] https://crrev.com/d53916d729f0706adf6bc55f48a92b454a4ff14c/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/d53916d729f0706adf6bc55f48a92b454a4ff14c/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/d53916d729f0706adf6bc55f48a92b454a4ff14c/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/d53916d729f0706adf6bc55f48a92b454a4ff14c/components/autofill/core/common/autofill_prefs.cc
[modify] https://crrev.com/d53916d729f0706adf6bc55f48a92b454a4ff14c/components/autofill/core/common/autofill_prefs.h
[modify] https://crrev.com/d53916d729f0706adf6bc55f48a92b454a4ff14c/components/browser_sync/profile_sync_service_autofill_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment