Issue metadata
Sign in to add a comment
|
ChromeVox touch: corner pass through not working |
||||||||||||||||||||||||
Issue descriptionGoogle Chrome 69.0.3494.0 (Official Build) dev (64-bit), Firmware Version Google_Eve. 9584.160.0 Steps to reproduce: # Flip convertible ChromeVox into tablet mode # Turn on ChromeVox by holding both hardware volume keys for 5 seconds # Hold upper left corner of the screen to invoke "pass through" mode Expected: earcon or some indication that this mode is invoked Actual: no indication, this instead highlights the ChromeVox menu button # Attempt to use feature anyway, hold down upper left corner of the screen and use two fingers to scroll up and down on a page Expected: able to scroll Actual: nothing happens
,
Aug 2
Corner pass through should be bottom left corner and bottom right corner. This feature never got any kind of review/testing before launch. I would like to remove it. It also conflicts with the real possibility that UI is in the corner(s) making it impossible to touch explore them.
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd98e27d135a2c693b7988113e40f67002c40a63 commit dd98e27d135a2c693b7988113e40f67002c40a63 Author: David Tseng <dtseng@chromium.org> Date: Fri Aug 03 22:05:36 2018 Remove touch exploration corner pass through and screen enter/exit earcons Bug: 869921 , 854321 , 869955 Change-Id: I9d9ae5aa5c590cf0200e6953054dff1833fc7b76 Reviewed-on: https://chromium-review.googlesource.com/1161176 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580666} [modify] https://crrev.com/dd98e27d135a2c693b7988113e40f67002c40a63/ash/accessibility/touch_exploration_controller.cc [modify] https://crrev.com/dd98e27d135a2c693b7988113e40f67002c40a63/ash/accessibility/touch_exploration_controller.h [modify] https://crrev.com/dd98e27d135a2c693b7988113e40f67002c40a63/ash/accessibility/touch_exploration_controller_unittest.cc
,
Aug 7
,
Aug 8
Corner passthrough was removed.
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b85205da20b52bc353f896a02b3c8d2e6e263c3 commit 7b85205da20b52bc353f896a02b3c8d2e6e263c3 Author: Kevin Schoedel <kpschoedel@chromium.org> Date: Fri Aug 10 11:54:44 2018 [chromecast] Remove touch exploration corner pass through Ports the ash version change from crrev.com/580666 Bug: 869921 , internal b/112073644 Test: manual Change-Id: I85e68b53f13ff190d1f90f39f96f85f43699f20a Reviewed-on: https://chromium-review.googlesource.com/1167651 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#582119} [modify] https://crrev.com/7b85205da20b52bc353f896a02b3c8d2e6e263c3/chromecast/browser/accessibility/touch_exploration_controller.cc [modify] https://crrev.com/7b85205da20b52bc353f896a02b3c8d2e6e263c3/chromecast/browser/accessibility/touch_exploration_controller.h [modify] https://crrev.com/7b85205da20b52bc353f896a02b3c8d2e6e263c3/chromecast/browser/accessibility/touch_exploration_controller_unittest.cc
,
Oct 4
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by leberly@chromium.org
, Aug 1