New issue
Advanced search Search tips

Issue 869919 link

Starred by 4 users
Status: Assigned
Owner:
nzolghadr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 689158
issue 877517


Sign in to add a comment

Send click event even when the targets of down and up are different and across different interactive elements

Project Member Reported by nzolghadr@chromium.org, Aug 1 
Based on the ui events spec the click must be sent to the nearest common ancestor of down and up events and it doesn't talk about the interactive elements at all.

related bugs:  issue 163854  and  issue 310263 

However, back then it caused some regressions (e.g.  issue 328304  and  issue 329136 ) so we never went beyond an interactive element boundary to find the common parent to match IE11 behavior. Nowadays, it seems both Edge and WebKit are firing click events to the nearest common parent irrespective of interactive elements. So it might be the time for Chrome to also change and follow the spec.
FF is also looking to follow the same behavior here.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a48b88b4c702885da8eae04906f2f0f7fbe33744

commit a48b88b4c702885da8eae04906f2f0f7fbe33744
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Fri Aug 03 15:22:25 2018

Send click event to the nearest common ancestor

Send click event even when the targets of down and up
are different and across different interactive elements.

Bug: 869919
Change-Id: Ie90c2d7c7dbb1b873f2a0f8b8ef489ee951489fe
Reviewed-on: https://chromium-review.googlesource.com/1161164
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580554}
[rename] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/WebKit/LayoutTests/external/wpt/uievents/click/auxclick_event-manual-expected.txt
[rename] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/WebKit/LayoutTests/external/wpt/uievents/click/auxclick_event-manual.html
[add] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/WebKit/LayoutTests/external/wpt/uievents/click/click_event_target-manual.html
[rename] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/WebKit/LayoutTests/external/wpt_automation/uievents/click/auxclick_event-manual-automation.js
[add] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/WebKit/LayoutTests/external/wpt_automation/uievents/click/click_event_target-manual-automation.js
[modify] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/WebKit/LayoutTests/fast/dom/shadow/select-in-shadowdom-expected.txt
[modify] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/WebKit/LayoutTests/fast/dom/shadow/select-in-shadowdom.html
[modify] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/WebKit/LayoutTests/fast/events/click-over-descendant-elements-expected.txt
[modify] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/WebKit/LayoutTests/fast/events/click-over-descendant-elements.html
[modify] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/blink/renderer/core/input/event_handling_util.cc
[modify] https://crrev.com/a48b88b4c702885da8eae04906f2f0f7fbe33744/third_party/blink/renderer/core/input/mouse_event_manager.cc

Comment 2 by nzolghadr@chromium.org, Aug 3

Status: Fixed (was: Assigned)

Comment 3 by nzolghadr@chromium.org, Oct 2

Blockedon: 689158
Status: Assigned (was: Fixed)
This change was reverted due to another  issue 890711 . We need to first fix issue 689158 to be able to have this landed as well.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c9478fffb43e0411078a846fc10f9f455d8a432

commit 6c9478fffb43e0411078a846fc10f9f455d8a432
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Tue Oct 02 18:52:32 2018

Revert of 'Send click event to the nearest common ancestor'

This is a partial revert of the click target calculation
CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1161164

which puts https://crbug.com/869919 back on the table.

It still keeps the wpt test though to make sure the test is
there for the final desired behavior.

Bug:  890711 , 869919
Change-Id: I3ea000a8f62b08b7222f91d27a6957d5a94e8388
Reviewed-on: https://chromium-review.googlesource.com/1256377
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595932}
[modify] https://crrev.com/6c9478fffb43e0411078a846fc10f9f455d8a432/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6c9478fffb43e0411078a846fc10f9f455d8a432/third_party/WebKit/LayoutTests/fast/dom/shadow/select-in-shadowdom-expected.txt
[modify] https://crrev.com/6c9478fffb43e0411078a846fc10f9f455d8a432/third_party/WebKit/LayoutTests/fast/dom/shadow/select-in-shadowdom.html
[modify] https://crrev.com/6c9478fffb43e0411078a846fc10f9f455d8a432/third_party/WebKit/LayoutTests/fast/events/click-over-descendant-elements-expected.txt
[modify] https://crrev.com/6c9478fffb43e0411078a846fc10f9f455d8a432/third_party/WebKit/LayoutTests/fast/events/click-over-descendant-elements.html
[modify] https://crrev.com/6c9478fffb43e0411078a846fc10f9f455d8a432/third_party/blink/renderer/core/input/event_handling_util.cc
[modify] https://crrev.com/6c9478fffb43e0411078a846fc10f9f455d8a432/third_party/blink/renderer/core/input/mouse_event_manager.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0276fa1a88e6ca061ac6f7a7379475fdfac55b07

commit 0276fa1a88e6ca061ac6f7a7379475fdfac55b07
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Tue Oct 09 13:15:06 2018

Revert of 'Send click event to the nearest common ancestor'

This is a partial revert of the click target calculation
CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1161164

which puts https://crbug.com/869919 back on the table.

It still keeps the wpt test though to make sure the test is
there for the final desired behavior.

Bug:  890711 , 869919
Change-Id: I3ea000a8f62b08b7222f91d27a6957d5a94e8388
Reviewed-on: https://chromium-review.googlesource.com/1256377
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#595932}(cherry picked from commit 6c9478fffb43e0411078a846fc10f9f455d8a432)
Reviewed-on: https://chromium-review.googlesource.com/c/1270526
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#915}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/0276fa1a88e6ca061ac6f7a7379475fdfac55b07/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0276fa1a88e6ca061ac6f7a7379475fdfac55b07/third_party/WebKit/LayoutTests/fast/dom/shadow/select-in-shadowdom-expected.txt
[modify] https://crrev.com/0276fa1a88e6ca061ac6f7a7379475fdfac55b07/third_party/WebKit/LayoutTests/fast/dom/shadow/select-in-shadowdom.html
[modify] https://crrev.com/0276fa1a88e6ca061ac6f7a7379475fdfac55b07/third_party/WebKit/LayoutTests/fast/events/click-over-descendant-elements-expected.txt
[modify] https://crrev.com/0276fa1a88e6ca061ac6f7a7379475fdfac55b07/third_party/WebKit/LayoutTests/fast/events/click-over-descendant-elements.html
[modify] https://crrev.com/0276fa1a88e6ca061ac6f7a7379475fdfac55b07/third_party/blink/renderer/core/input/event_handling_util.cc
[modify] https://crrev.com/0276fa1a88e6ca061ac6f7a7379475fdfac55b07/third_party/blink/renderer/core/input/mouse_event_manager.cc

Comment 6 by nzolghadr@chromium.org, Jan 15

Labels: -Pri-3 Pri-2

Comment 7 by nzolghadr@google.com, Jan 18 (4 days ago)

Blockedon: 877517
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cf0c4de8143be150844d9eb7f840fc652dd76c5

commit 6cf0c4de8143be150844d9eb7f840fc652dd76c5
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Fri Jan 18 22:14:24 2019

Send click event to the nearest common ancestor

Send click event even when the targets of down and up
are different and across different interactive elements.

This is another try to land this change and hopefully the
previous regressions are now fixed.

Bug: 869919
Change-Id: I6161f734cb1c0513b11d82c635ea9af5c3eeee3a
Reviewed-on: https://chromium-review.googlesource.com/c/1413232
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624315}
[modify] https://crrev.com/6cf0c4de8143be150844d9eb7f840fc652dd76c5/third_party/blink/renderer/core/input/event_handling_util.cc
[modify] https://crrev.com/6cf0c4de8143be150844d9eb7f840fc652dd76c5/third_party/blink/renderer/core/input/mouse_event_manager.cc
[modify] https://crrev.com/6cf0c4de8143be150844d9eb7f840fc652dd76c5/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/6cf0c4de8143be150844d9eb7f840fc652dd76c5/third_party/blink/web_tests/fast/dom/shadow/select-in-shadowdom-expected.txt
[modify] https://crrev.com/6cf0c4de8143be150844d9eb7f840fc652dd76c5/third_party/blink/web_tests/fast/dom/shadow/select-in-shadowdom.html
[modify] https://crrev.com/6cf0c4de8143be150844d9eb7f840fc652dd76c5/third_party/blink/web_tests/fast/events/click-over-descendant-elements-expected.txt
[modify] https://crrev.com/6cf0c4de8143be150844d9eb7f840fc652dd76c5/third_party/blink/web_tests/fast/events/click-over-descendant-elements.html
►

Sign in to add a comment