This bug tracks the work to align internal interfaces with the Background Fetch spec after commits https://github.com/WICG/background-fetch/commit/86d9dd12327a07dc30dbac1f3438208e69a8a30d and https://github.com/WICG/background-fetch/commit/a2e199891180d2005dc3beac015e7019c69450f2.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6baa669dd005eba7e68b8ee4efcfd5c645a0ee1 commit a6baa669dd005eba7e68b8ee4efcfd5c645a0ee1 Author: Mugdha Lakhani <nator@chromium.org> Date: Mon Aug 13 14:12:02 2018 [Background Fetch] Implement BackgroundFetchRecord. This will be required to implement match() and matchAll() on BackgroundFetchRegistration in a follow-up CL. Bug: 869918 Change-Id: I9ed88076488a035f313b9d16e0f41b3c168a0a09 Reviewed-on: https://chromium-review.googlesource.com/1169465 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#582574} [modify] https://crrev.com/a6baa669dd005eba7e68b8ee4efcfd5c645a0ee1/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/a6baa669dd005eba7e68b8ee4efcfd5c645a0ee1/third_party/blink/renderer/modules/background_fetch/BUILD.gn [add] https://crrev.com/a6baa669dd005eba7e68b8ee4efcfd5c645a0ee1/third_party/blink/renderer/modules/background_fetch/background_fetch_record.cc [add] https://crrev.com/a6baa669dd005eba7e68b8ee4efcfd5c645a0ee1/third_party/blink/renderer/modules/background_fetch/background_fetch_record.h [add] https://crrev.com/a6baa669dd005eba7e68b8ee4efcfd5c645a0ee1/third_party/blink/renderer/modules/background_fetch/background_fetch_record.idl [modify] https://crrev.com/a6baa669dd005eba7e68b8ee4efcfd5c645a0ee1/third_party/blink/renderer/modules/modules_idl_files.gni [modify] https://crrev.com/a6baa669dd005eba7e68b8ee4efcfd5c645a0ee1/third_party/blink/renderer/platform/bindings/script_promise_properties.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28 commit dbeb0bab3b0350384e6fac086d7aaf9ee807ad28 Author: Mugdha Lakhani <nator@chromium.org> Date: Tue Aug 14 14:38:56 2018 [Background Fetch] Idl changes, to align with the spec. 1. backgroundfetchclick and backgroundfetchabort are of type BackgroundFetchEvent now. 2. BackgroundFetchEvent includes a BackgroundFetchRegistration object. 3. Temporarily (until match() and matchAll() have been implemented on BackgroundFetchRegistration), BackgroundFetchUpdateUIEvent also includes a BackgroundFetchSettledFetches object. 4. BackgroundFetchUpdateEvent --> BackgroundFetchUpdateUIEvent, and inherits from BackgroundFetchEvent. 5. backgroundfetched --> backgroundfetchsuccess. 6. backgroundfetchsuccess and backgroundfetchfail are of type BackgroundFetchUpdateUIEvent. 7. Update WPT tests accordingly. Bug: 869918 Change-Id: Ibb05087e692b39c2dd34c990baeff642627b6520 Reviewed-on: https://chromium-review.googlesource.com/1158835 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#582909} [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/chrome/test/data/background_fetch/background_fetch.js [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/chrome/test/data/background_fetch/sw.js [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/background_fetch/background_fetch_context.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/background_fetch/background_fetch_data_manager.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/background_fetch/background_fetch_event_dispatcher.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/background_fetch/background_fetch_event_dispatcher.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/background_fetch/background_fetch_service_unittest.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/service_worker/service_worker_metrics.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/browser/service_worker/service_worker_metrics.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/common/service_worker/service_worker.mojom [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.serviceworker-expected.txt [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw-update-ui.js [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw.js [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/WebKit/LayoutTests/external/wpt/background-fetch/update-ui.https.window.js [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/public/web/modules/service_worker/web_service_worker_context_client.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/bindings/modules/BUILD.gn [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/core/events/event_type_names.json5 [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/BUILD.gn [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_click_event.cc [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_click_event.h [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_click_event.idl [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_click_event_init.idl [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/background_fetch_event.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/background_fetch_event.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/background_fetch_event.idl [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/background_fetch_event_init.idl [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_fail_event.cc [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_fail_event.h [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_fail_event.idl [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event.cc [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event.h [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event.idl [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event_init.idl [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetch.h [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.cc [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.h [delete] https://crrev.com/9838087d847b41533d890d463d3b5988f80de958/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.idl [add] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.cc [add] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.h [add] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.idl [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/service_worker_global_scope_background_fetch.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/background_fetch/service_worker_global_scope_background_fetch.idl [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/modules_idl_files.gni [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/service_worker/wait_until_observer.cc [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/third_party/blink/renderer/modules/service_worker/wait_until_observer.h [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/tools/metrics/histograms/enums.xml [modify] https://crrev.com/dbeb0bab3b0350384e6fac086d7aaf9ee807ad28/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f378fd16aff08e8aceb551eaf471ec833a98ffc commit 0f378fd16aff08e8aceb551eaf471ec833a98ffc Author: Mugdha Lakhani <nator@chromium.org> Date: Fri Aug 24 14:43:03 2018 [Background Fetch] Part 1: Implement BackgroundFetchFailureReason. This is step 1, everything needed to support this on the browser side. Bug: 876691 , 869918 Change-Id: I4c161ae404e24caae9d09b7ea4709a6eb161a95e Reviewed-on: https://chromium-review.googlesource.com/1185006 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585835} [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch.proto [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_job_controller.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_job_controller.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_test_base.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_test_base.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/storage/create_metadata_task.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/storage/database_helpers.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/storage/database_helpers.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/storage/get_registration_task.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/common/background_fetch/background_fetch_struct_traits.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/common/background_fetch/background_fetch_struct_traits.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/common/background_fetch/background_fetch_struct_traits_unittest.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/common/background_fetch/background_fetch_types.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/common/background_fetch/background_fetch_types.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b9f6363f6383422923789ad72bce584e3f27470 commit 2b9f6363f6383422923789ad72bce584e3f27470 Author: Mugdha Lakhani <nator@chromium.org> Date: Fri Aug 24 15:27:01 2018 [BackgroundFetch] Part 1: Remove BackgroundFetchSettledFetches. This removes BackgroundFetchSettledFetches from blink, idl files, and the WPT tests. In a follow up CL I'll remove it from all the event dispatcher code on the browser side. This fix also makes cache_query_params optional in MatchRequests() in mojo. This is required because otherwise the mojo bindings logic crashes the renderer when we try to pass in a nullptr for cache_query_params from blink. Bug: 869918 , 863016 Change-Id: Ifa933451f98f82902d8455ba5401c629c8c24811 Reviewed-on: https://chromium-review.googlesource.com/1186735 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585847} [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw.js [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/BUILD.gn [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/background_fetch/BUILD.gn [delete] https://crrev.com/fcc71691d1795a8688b552b77dc6032293fdc39c/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.cc [delete] https://crrev.com/fcc71691d1795a8688b552b77dc6032293fdc39c/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.h [delete] https://crrev.com/fcc71691d1795a8688b552b77dc6032293fdc39c/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.idl [delete] https://crrev.com/fcc71691d1795a8688b552b77dc6032293fdc39c/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches_test.cc [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.cc [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.h [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.idl [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/modules_idl_files.gni [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce4238cadf8beec3f37b508d690c84ece793f720 commit ce4238cadf8beec3f37b508d690c84ece793f720 Author: Mugdha Lakhani <nator@chromium.org> Date: Fri Aug 24 16:13:53 2018 [Background Fetch] Update Background Fetch unit tests. Now that we're passing BackgroundFetchRegistration with all BackgroundFetch Events, the unit tests can be simplified. Bug: 876691 , 869918 Change-Id: I5137981b32666901cdc6f953b744372695b11d72 Reviewed-on: https://chromium-review.googlesource.com/1186722 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585861} [modify] https://crrev.com/ce4238cadf8beec3f37b508d690c84ece793f720/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/ce4238cadf8beec3f37b508d690c84ece793f720/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/ce4238cadf8beec3f37b508d690c84ece793f720/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/ce4238cadf8beec3f37b508d690c84ece793f720/content/browser/background_fetch/background_fetch_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9daf4f57c080e9835db640bb8ea532623782c1ac commit 9daf4f57c080e9835db640bb8ea532623782c1ac Author: Mugdha Lakhani <nator@chromium.org> Date: Fri Aug 24 18:08:35 2018 [BackgroundFetch] Part 2: Implement BackgroundFetchFailureReason. This is the second part, the plumbing on the blink side. Bug: 876691 , 869918 Change-Id: I62fe4aaf37f41b5ebd341ce4731f7fda1d486feb Reviewed-on: https://chromium-review.googlesource.com/1185015 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585906} [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/get.https.window.js [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.sharedworker-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.worker-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw-helpers.js [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw.js [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/blink/public/platform/modules/background_fetch/web_background_fetch_registration.h [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/blink/renderer/modules/background_fetch/background_fetch_type_converters.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d486be14ccd9bfa6f39e29b95bd417514f4f493 commit 7d486be14ccd9bfa6f39e29b95bd417514f4f493 Author: Mugdha Lakhani <nator@chromium.org> Date: Wed Aug 29 12:52:42 2018 [BackgroundFetch]: Part2: Remove BackgroundFetchSettledFetches. This removes the class from browser code, stops sending it across with various BackgroundFetch events, and also gets rid of WebBackgroundFetchSettledFetch in blink. Some converter fuctions can also be deleted. I've updated two unittests in background_fetch_service_unittest.cc to call MatchRequests() and check that all properties have been set on the settled fetches as expected. Bug: 869918 , 863016 Change-Id: I7e9729c3c120e70f2dfc70a493a900420e46e848 Reviewed-on: https://chromium-review.googlesource.com/1187101 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#587086} [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_event_dispatcher.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_event_dispatcher.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_service_unittest.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/common/service_worker/service_worker.mojom [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/third_party/blink/public/BUILD.gn [delete] https://crrev.com/374d0f6b15610eada09f473761de4615fdb64652/third_party/blink/public/platform/modules/background_fetch/web_background_fetch_settled_fetch.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
Comment 1 by bugdroid1@chromium.org
, Aug 13