New issue
Advanced search Search tips

Issue 869902 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Aug 7
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Visible jump in SideSwipe after rotation

Project Member Reported by gambard@chromium.org, Aug 1 
iPhone only

What steps will reproduce the problem?
(1) Open a web page in Chrome in landscape
(2) Use SideSwipe on the toolbar (no need to change tab, the important part is to trigger it)
(3) Rotate the phone
(4) Trigger SideSwipe

What is the expected result?
The SideSwipe should be smooth.

What happens instead?
There is a visible jump of 2pt.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/971b7ef9a9b023783d8ef6f4be3b3ab144854501

commit 971b7ef9a9b023783d8ef6f4be3b3ab144854501
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Aug 07 09:15:44 2018

[iOS] Fix SideSwipe jump after rotation

This CL updates the top margin of the SideSwipe image, which is
otherwise wrong after changing device orientation as the toolbar
height is different.

Bug:  869902 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I767ab0fa76fea9c538e4e2c4e1ad49bc86b0d652
Reviewed-on: https://chromium-review.googlesource.com/1158826
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581179}
[modify] https://crrev.com/971b7ef9a9b023783d8ef6f4be3b3ab144854501/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm

Comment 2 by gambard@chromium.org, Aug 7

Status: Fixed (was: Assigned)
►

Sign in to add a comment