Issue metadata
Sign in to add a comment
|
DCHECKs in HardwareDisplayPlaneManagerLegacy |
||||||||||||||||||||||
Issue descriptionOn the amd64-generic simplechrome CQ bot, we get: [2622:2634:0730/155118.629178:FATAL:hardware_display_plane_manager_legacy.cc(105)] Check failed: false. HardwareDisplayPlaneManagerLegacy doesn't support per plane CTM See https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=a4068c05476b786213ab26a80cf35e426fd54f44&as=chrome_20180730-155114 for the detail. dnicoara@chromium.org: you have been looking at this code recently? Can you take a look?
,
Aug 1
Should be fixed on ToT. The CrOS bots need to catch up.
,
Aug 3
I just saw this crash with TOT chrome: [15075:15089:0803/131402.995100:FATAL:hardware_display_plane_manager_legacy.cc(105)] Check failed: false. HardwareDisplayPlaneManagerLegacy doesn't support per plane CTM #0 0x55720cd2342c base::debug::StackTrace::StackTrace() #1 0x55720cc7c1d0 logging::LogMessage::~LogMessage() #2 0x557209fc14ad ui::HardwareDisplayPlaneManagerLegacy::SetColorCorrectionOnAllCrtcPlanes() #3 0x557209fbe0c8 ui::HardwareDisplayPlaneManager::SetColorMatrix() #4 0x557209fa03af ui::DrmDisplay::SetColorMatrix() #5 0x557209fa23e1 ui::DrmGpuDisplayManager::SetColorMatrix() #6 0x55720cd4611b base::debug::TaskAnnotator::RunTask() #7 0x55720cc84846 base::MessageLoop::RunTask() #8 0x55720cc84d52 base::MessageLoop::DoWork() #9 0x55720cd41bf9 base::MessagePumpLibevent::Run() #10 0x55720cc84211 base::MessageLoop::Run() #11 0x55720ccb1656 base::RunLoop::Run() #12 0x55720ccf43aa base::Thread::Run() #13 0x55720ccf4737 base::Thread::ThreadMain() #14 0x55720cd3545f base::(anonymous namespace)::ThreadFunc() #15 0x7de7ebd232b8 <unknown> #16 0x7de7eb1d4fad clone
,
Aug 3
From lsb-release: CHROMEOS_RELEASE_BUILDER_PATH=amd64-generic-full/R70-10932.0.0-rc1 chrome is TOT as of #580595, Fri Aug 3 18:03:33 2018 +0000
,
Aug 8
Woops, mistook the issues .. looking.
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfde49d0efe1527bf3e78d9bd28d7956e609c853 commit bfde49d0efe1527bf3e78d9bd28d7956e609c853 Author: Daniel Nicoara <dnicoara@chromium.org> Date: Thu Aug 09 22:14:10 2018 Fix check for PLANE_CTM on legacy Enable universal planes when initializing the DRM device in the browser process. This ensures all planes are exposed via DRM. If DRM reports 0 planes (on legacy this can happen) do not report support for PLANE_CTM otherwise the display configuration will try to set hardware CTM. Bug: 869901 Test: Compiled Change-Id: I3fd09e3628e198219d8bb0b1400afd156cb4bcbe Reviewed-on: https://chromium-review.googlesource.com/1167892 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#581911} [modify] https://crrev.com/bfde49d0efe1527bf3e78d9bd28d7956e609c853/ui/ozone/platform/drm/common/drm_util.cc [modify] https://crrev.com/bfde49d0efe1527bf3e78d9bd28d7956e609c853/ui/ozone/platform/drm/host/drm_device_handle.cc
,
Aug 9
,
Aug 13
Yup, can't see this crash any more - thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rjkroege@chromium.org
, Aug 1