New issue
Advanced search Search tips

Issue 869887 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

PaymentAppBrowserTest.CanMakePayment crashing flakily after r575974

Project Member Reported by keishi@chromium.org, Aug 1

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b87da49f5ebba4a2b56e25395b4c541098302413

commit b87da49f5ebba4a2b56e25395b4c541098302413
Author: Keishi Hattori <keishi@chromium.org>
Date: Fri Aug 03 03:23:12 2018

Wrap PaymentInstrument in a GarbageCollected class before passing to WTF::Bind

If you pass a placement only object to WTF::Bind, the Trace method will not be called.
It can result in the on-heap objects referenced from the object, collected prematurely.
In this case the backing for PaymentInstrument::icons_ had this problem.
In this CL we wrap the PaymentInstrument in a GarbageCollected class so we can use a Persistent on it.

Bug: 869887
Change-Id: I2ae75c3652f52a898dac422c2c867c388d170f88
Reviewed-on: https://chromium-review.googlesource.com/1158668
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580435}
[modify] https://crrev.com/b87da49f5ebba4a2b56e25395b4c541098302413/third_party/blink/renderer/modules/payments/payment_instruments.cc
[modify] https://crrev.com/b87da49f5ebba4a2b56e25395b4c541098302413/third_party/blink/renderer/modules/payments/payment_instruments.h

Sign in to add a comment