New issue
Advanced search Search tips

Issue 869879 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

chrome://crashes "crashes" header overlaps the snap icon

Project Member Reported by linds...@chromium.org, Aug 1

Issue description


App Version:70.0.3509/0
iOS Version: iOS11.4.1, iOS12 beta 5
Device: iPhone8, iPhoneX
URL: chrome://crashes

Steps to reproduce:
  1. Load the page chrome://crashes

Observed results:
Header "crashes" overlaps the aw snap file icon. This is new on canary in the last couple of days, it doesn't manifest on canary from last week.

Expected results:
There should be no overlap.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install:Yes
Bug reproducible after clearing cache and cookies:Yes
Observed behavior in Chrome Mobile on Android: No
Check for similar behavior on Firefox/Safari: n/a
Bug reproducible on current stable build (App Version, iOS Version): No
Bug reproducible on the current beta channel (dogfoody) build (App Version, iOS Version): No

Screenshot: https://drive.google.com/file/d/1FdRQoVsaGbR1dBJ_PSUpispkLa1L-akk/view
 
Components: UI>Browser>Interstitials
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
eugenebut@ could you PTAL or assign to the right person?
Cc: eugene...@chromium.org
Owner: rsesek@chromium.org
Robert, are you the right owner for this bug?
Cc: rsesek@chromium.org
Owner: obru...@igalia.com
Probably caused by https://chromium.googlesource.com/chromium/src/+/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42.
The linked screenshot is not public, but I guess for some reason this is not applied:

h1 {
  padding-inline-start: 75px;
}

It works well on my PC.
Public accessible screenshot.

Screen Shot 2018-08-06 at 9.51.45 AM.png
48.3 KB View Download
iOS can not use Blink and has to user WKWebView. WKWebView's behavior can be different from Blink.
Ah, this explains the problem, the standard logical properties are implemented in Blink but not in WebKit
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/616ce74069dc887668f5a6f5da461dbfdc6c82ea

commit 616ce74069dc887668f5a6f5da461dbfdc6c82ea
Author: Oriol Brufau <obrufau@igalia.com>
Date: Thu Aug 16 18:07:18 2018

[css-logical] Add back prefixed logical property in crashes.css

Most uses of the prefixed logical properties were replaced with the
standard ones, supported in Blink. However, they are not supported in
WebKit, this causes problems in iOS. This patch adds back the prefixed
property so that it's used as a fallback.

BUG= 869879 

Change-Id: Ic5076d10524f3e93994c72ff049d53daadea39d6
Reviewed-on: https://chromium-review.googlesource.com/1163887
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#583732}
[modify] https://crrev.com/616ce74069dc887668f5a6f5da461dbfdc6c82ea/components/crash/core/browser/resources/crashes.css

Can you confirm it's fixed after https://crrev.com/616ce74069dc887668f5a6f5da461dbfdc6c82ea ?
Also, do about:flags and about:version look good? According to Robert they may also be affected, but I don't have iOS to test.
Status: Fixed (was: Assigned)
Chrome Test team can retest this bug.
Status: Verified (was: Fixed)
Chrome crashes looks good now on canary 70.0.3525.0 iPhoneX iOS12 beta 9.

Screenshot - https://drive.google.com/file/d/1wYdm5zqnREpo2oxksnKvkz1OiMGM9VVI/view

chrome://version and about://flags look good as well.

Sign in to add a comment