[LayoutNG] vertical-align for table cells sometimes not working |
||
Issue descriptionfast/table/column-in-inline.html fast/table/empty-table-percent-height.html fast/table/vertical-align-baseline-readjust.html tables/mozilla/bugs/bug18440.html tables/mozilla/bugs/ bug30692 .html From dgrogan@: cells vertical-align works in other tests, something about these trigger a bug
,
Aug 1
I was looking into fast/table/vertical-align-baseline-readjust.html, but can't figure out what's expected. Is this test about cells don't have any line boxes, and that they should synthesize the baseline at the bottom, and table should align the synthesized baselines by default? I put some text to generate line boxes but didn't work expected, so my guess doesn't look correct.
,
Aug 17
fast/table/column-in-inline.html looks like an inline layout problem and nothing to do with tables. I'll take a look.
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/736345b4bf29bd8121985bf07c056810fda4aaf6 commit 736345b4bf29bd8121985bf07c056810fda4aaf6 Author: Koji Ishii <kojii@chromium.org> Date: Mon Aug 27 14:58:16 2018 Fix fast/table/column-in-inline.html not to rely on wrong behavior fast/table/column-in-inline.html says it tests "a table-column with a table-cell sibling are wrapped inside an inline-table when the parent is inline" but it also tests: 1. Anonymous inline box inherits non-inherited properties, which contradicts with the spec (crbug.com/877946). 2. If the above was fixed, it tests baseline alignment of inline tables. LayoutNG fails because it does not have crbug.com/877946. This patch changes the test to focus on what it says, and creates a separate test for crbug.com/869877 . Bug: 869877 , 877946 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0b53ec68d5ea59a93010d49891d6bfe3a6688158 Reviewed-on: https://chromium-review.googlesource.com/1179736 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#586261} [modify] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/linebox/anonymous-inline-inherit-001-ref.html [add] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/linebox/anonymous-inline-inherit-001.html [modify] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/fast/table/column-in-inline-expected.html [modify] https://crrev.com/736345b4bf29bd8121985bf07c056810fda4aaf6/third_party/WebKit/LayoutTests/fast/table/column-in-inline.html
,
Oct 12
All these got fixed apparently |
||
►
Sign in to add a comment |
||
Comment 1 by kojii@chromium.org
, Aug 1Cc: kojii@chromium.org dgro...@chromium.org
Labels: -Type-Bug Type-Task
Status: Available (was: Untriaged)