Help text in clear browsing data screen truncates in landscape mode |
|||||||||||
Issue descriptionApp Version: 69.0.3497.22 beta iOS Version: 10.3.3, 11.4.1, 12.0 beta 5 Device:iPhone 7 Plus, iPhone 6 Plus, iPad Air Prerequisite: Sign in to chrome Steps to reproduce: 1. Launch iOS Chrome 2. Go to Menu>History or Tap on ‘History’ icon in NTP 3. Change the device orientation to landscape 4. Tap on ‘Clear Browsing data’ Observed results: Help text is truncated on changing the device orientation to landscape Expected results: Help text should be displayed without any truncations under clear browsing data screen Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on the current beta channel build : M68, NA (Newly implementation in M69) Type-bug-regression? No Link to video/image: https://drive.google.com/open?id=1aOTIKhNsvxVw_tn54YA2Z_vAccfLTkyO
,
Aug 1
,
Aug 1
,
Aug 1
I think P1 sg, let me start taking a look
,
Aug 1
Sent https://chromium-review.googlesource.com/c/chromium/src/+/1159328 for review.
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e85a974e10c613fe8bf0523c4cd3ef3dfa696be commit 7e85a974e10c613fe8bf0523c4cd3ef3dfa696be Author: sczs <sczs@chromium.org> Date: Fri Aug 03 16:32:29 2018 [ios] Implements reloadCellsForItems on ChromeTableVC By calling reloadCellsForItems at the cell indexPath, the cell gets reconfigured and also redrawn since [tableView reloadRowsAtIndexPaths:withRowAnimation:] is called. This causes the cell height to adjust to the new content. Bug: 869838 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iadd0a7f9a80d321015f654bd51dfeb084861f2cf Reviewed-on: https://chromium-review.googlesource.com/1159328 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#580568} [modify] https://crrev.com/7e85a974e10c613fe8bf0523c4cd3ef3dfa696be/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm [modify] https://crrev.com/7e85a974e10c613fe8bf0523c4cd3ef3dfa696be/ios/chrome/browser/ui/table_view/chrome_table_view_consumer.h [modify] https://crrev.com/7e85a974e10c613fe8bf0523c4cd3ef3dfa696be/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
,
Aug 3
Fixed. Waiting for next Canary for verification
,
Aug 7
Verified in: App Version: 70.0.3515.0 canary Devices: iPhone 7 Plus, iPhone 8 Plus, iPad Air iOS Versions: 10.3.3, 11.4.1, 12.0 Beta 6 Help text in clear browsing data screen is displayed completely without any truncations
,
Aug 8
,
Aug 8
This bug requires manual review: Less than 23 days to go before AppStore submit on M69 Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 8
Thanks Mark! kariahda@ for cherrypick approval
,
Aug 8
Approved.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c59d0b47232b60bdbb50558a95ac74c2967f484 commit 9c59d0b47232b60bdbb50558a95ac74c2967f484 Author: sczs <sczs@chromium.org> Date: Wed Aug 08 22:13:06 2018 [ios] Implements reloadCellsForItems on ChromeTableVC By calling reloadCellsForItems at the cell indexPath, the cell gets reconfigured and also redrawn since [tableView reloadRowsAtIndexPaths:withRowAnimation:] is called. This causes the cell height to adjust to the new content. TBR=sczs@chromium.org (cherry picked from commit 7e85a974e10c613fe8bf0523c4cd3ef3dfa696be) Bug: 869838 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iadd0a7f9a80d321015f654bd51dfeb084861f2cf Reviewed-on: https://chromium-review.googlesource.com/1159328 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#580568} Reviewed-on: https://chromium-review.googlesource.com/1168183 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#512} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/9c59d0b47232b60bdbb50558a95ac74c2967f484/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm [modify] https://crrev.com/9c59d0b47232b60bdbb50558a95ac74c2967f484/ios/chrome/browser/ui/table_view/chrome_table_view_consumer.h [modify] https://crrev.com/9c59d0b47232b60bdbb50558a95ac74c2967f484/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by pschaffner@chromium.org
, Aug 1Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)