"CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget" is flaky |
||||||
Issue description"CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 13 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQgsSBUZsYWtlIjdDdXN0b21GcmFtZVZpZXdBc2hUZXN0LkFjdGl2ZVN0YXRlT2ZCdXR0b25NYXRjaGVzV2lkZ2V0DA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Aug 1
Assigning to the author of the test. I will disable it on ChromeOS bots
,
Aug 1
Upon closer look, Kinuko isn't the author.
,
Aug 1
Disabling is in progress https://chromium-review.googlesource.com/c/chromium/src/+/1158584
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/323e8611c23307e86667f0526af34cccb8b8cc8e commit 323e8611c23307e86667f0526af34cccb8b8cc8e Author: Christos Froussios <cfroussios@chromium.org> Date: Wed Aug 01 13:23:56 2018 Disable CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget on linux-chromeos-rel It is flaking. TBR=sky@chromium.org Bug: 869830 Change-Id: Id455349e683f1adda690457faffc40d12c977d38 Reviewed-on: https://chromium-review.googlesource.com/1158584 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#579789} [modify] https://crrev.com/323e8611c23307e86667f0526af34cccb8b8cc8e/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
,
Aug 1
,
Aug 2
As per a comment https://chromium-review.googlesource.com/1158584 the offending CL has already been reverted. and also, I disabled the wrong test 🤦
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3e838a6c0ca700baa9157f1826f852e0ff7af66 commit f3e838a6c0ca700baa9157f1826f852e0ff7af66 Author: Christos Froussios <cfroussios@chromium.org> Date: Thu Aug 02 08:45:59 2018 Revert "Disable CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget on linux-chromeos-rel" This reverts commit 323e8611c23307e86667f0526af34cccb8b8cc8e. Reason for revert: Disabled non-offending test Original change's description: > Disable CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget on linux-chromeos-rel > > It is flaking. > > TBR=sky@chromium.org > > Bug: 869830 > Change-Id: Id455349e683f1adda690457faffc40d12c977d38 > Reviewed-on: https://chromium-review.googlesource.com/1158584 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579789} TBR=cfroussios@chromium.org Change-Id: I1904d3f8febf2d9c0fcac0032e2622df2bdb009d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869830 Reviewed-on: https://chromium-review.googlesource.com/1160222 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#580115} [modify] https://crrev.com/f3e838a6c0ca700baa9157f1826f852e0ff7af66/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
,
Aug 8
should be good now after c948168648360bdffb |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by cfroussios@chromium.org
, Aug 1Labels: OS-Chrome