New issue
Advanced search Search tips

Issue 869829 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

"http/tests/media/video-cancel-load.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 1

Issue description

"http/tests/media/video-cancel-load.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMgsSBUZsYWtlIidodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLWNhbmNlbC1sb2FkLmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: OS-Mac
The test is flaking on mac_chromium_rel_ng.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0223898f16919ddfee0813c54f9ef3f327c43fc3

commit 0223898f16919ddfee0813c54f9ef3f327c43fc3
Author: Christos Froussios <cfroussios@chromium.org>
Date: Wed Aug 01 12:50:59 2018

Disable http/tests/media/video-cancel-load.html on mac_chromium_rel_ng

It is flaky

Bug:  869829 
No-try: True
No-presubmit: True
Change-Id: I9f49e4c6c7d3457e967e964ee1f8e5e36402a258
Reviewed-on: https://chromium-review.googlesource.com/1158624
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579781}
[modify] https://crrev.com/0223898f16919ddfee0813c54f9ef3f327c43fc3/third_party/WebKit/LayoutTests/TestExpectations

Components: Blink>Media
The test doesn't seem to have recommended owners or a component named in 
/third_party/WebKit/LayoutTests/http/tests/media/OWNERS
Maybe Blink>Media?
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
dalecurtis@ shot in the dark, but any chance http://crrev.com/579218 caused this? Flakes started appearing yesterday. Otherwise I think you might be the best person to triage this.

There's also a FindIt job running which doesn't have any results yet: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyswELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ9Y2hyb21pdW0ubWFjL01hYzEwLjEzIFRlc3RzLzQ0OTQvd2Via2l0X2xheW91dF90ZXN0cyBvbiBJbnRlbCBHUFUgb24gTWFjL2FIUjBjQzkwWlhOMGN5OXRaV1JwWVM5MmFXUmxieTFqWVc1alpXd3RiRzloWkM1b2RHMXMMCxITTWFzdGVyRmxha2VBbmFseXNpcxgCDA
No that's an Android only change. 
Will see if the job comes back with anything and look over the change log otherwise.
Labels: -Sheriff-Chromium
Test is disabled, bug is under investigation, dropping sheriff label.
Status: Started (was: Assigned)
Test has 6s timeout but should be in SlowTests due to usage of video-throttled-load.cgi
Labels: -Pri-1 Pri-3
Pri-1/2 must have a milestone. P3 since test disabled now.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e5bab0a2c26532215cb0b2f6a39ed64591c5d70

commit 5e5bab0a2c26532215cb0b2f6a39ed64591c5d70
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Mon Aug 06 19:15:49 2018

Mark tests which use throttled loading as slow.

There are a few more in TestExpectations which use video-throttled-load.cgi
with a low thorttle value and could probably be updated. However, they've
been disabled for some time, while these were just disabled, so to avoid
churn just re-enable these as slow for now.

BUG= 869829 ,  870259 
TBR=hubbe

Change-Id: I03a814e58e5ffb6a7f3d1040e636f16cded2c0f5
Reviewed-on: https://chromium-review.googlesource.com/1161196
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580944}
[modify] https://crrev.com/5e5bab0a2c26532215cb0b2f6a39ed64591c5d70/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/5e5bab0a2c26532215cb0b2f6a39ed64591c5d70/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Started)

Sign in to add a comment