For devices with render playout effects AEC3 sometimes leaks echoes |
||||||
Issue descriptionOn devices where render playout effects are active AEC3 sometimes leaks echoes. The reason for this is that the render effects constitute a highly time-varying component in the echo path as seen by the AEC.
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6b97f6b0b6137c6df70d131b463d74b7c807700 commit f6b97f6b0b6137c6df70d131b463d74b7c807700 Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Aug 01 17:55:18 2018 Roll src/third_party/webrtc 7a1c7f782a14..78026754a734 (2 commits) https://webrtc.googlesource.com/src.git/+log/7a1c7f782a14..78026754a734 git log 7a1c7f782a14..78026754a734 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 peah@webrtc.org AEC3: Utilize shadow filter output to respond to audio path changes 2018-08-01 oprypin@webrtc.org Explicitly add -mfpu=neon to all targets that use NEON Created with: gclient setdep -r src/third_party/webrtc@78026754a734 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= chromium:869821 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I50a4664af22308ac41d58db2390bf766493e546b Reviewed-on: https://chromium-review.googlesource.com/1158786 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579856} [modify] https://crrev.com/f6b97f6b0b6137c6df70d131b463d74b7c807700/DEPS
,
Aug 3
We would like to merge this issue into M69. It addresses an echo canceller issue that appears on devices that have render playout effects. The issue has surfaced due to recent improvements on transparency and was detected during testing of Chrome Canary. It has been tested in Chrome Canary and both the manual testing results and the metrics look good. The merge is considered to be very safe, as the feature is only active beneath an experiment flag, and also has a specific kill-switch. The CL that would be part of the merge is -https://webrtc-review.googlesource.com/91820
,
Aug 3
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3
Approving merge to M69 branch 3497 based on comment #3. Please merge ASAP. Thank you.
,
Aug 3
Thanks! This has now been merged to M69. The merging CL was: -https://webrtc-review.googlesource.com/c/src/+/92394
,
Aug 7
,
Aug 7
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 1