New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 869811 link

Starred by 3 users
Status: Fixed
Owner:
█ xiaoyinh@chromium.org
Last visit > 30 days ago
Closed: Aug 27
Cc:
ajha@chromium.org
wzang@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Regression: Unnecessary 'Add Person' option is seen where powerwash overlay is present

Project Member Reported by kebalaji@chromium.org, Aug 1 
Chrome Version: 70.0.3505.0/10927.0.0 dev-channel Peppy,Candy and Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)In Sign-out screen(Web UI login)>> Hit Ctrl+Alt+Shift+Reload for powerwash
(2)Restart and when powerwash overlay appears, observe unnecessary 'Add Person' option is seen 

Actual: Unnecessary 'Add Person' option is seen when powerwash overlay is present
Expected: 'Add Person' option should not be seen

This is a Regression issue as same is working fine in 70.0.3502.0/10910.0.0 dev

NOTE: Issue is not seen on Windows and Linux

Attaching screencasts for reference..
ActualAddPerson.mp4
4.4 MB View Download
ExpectedAddPerson.mp4
3.8 MB View Download

Comment 1 by jdufault@chromium.org, Aug 2

Owner: xiaoyinh@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by jdufault@chromium.org, Aug 21

Labels: ReleaseBlock-Stable
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51d19d3c6952f249250172ae9631002f3992fc63

commit 51d19d3c6952f249250172ae9631002f3992fc63
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Mon Aug 27 19:41:50 2018

Reland: cros: Update visibility of guest and apps button in the shelf.

PatchSet 1 is originally reviewed in
https://chromium-review.googlesource.com/c/chromium/src/+/1142384

On top of the original CL, this updates the following:
1. Notify oobe dialog state based on the visibility of the oobe dialog.
2. Send additional data SetShowGuestButtonForGaiaScreen to login shelf.

Bug:  857514 ,  869811 
Change-Id: Ic8baae2e31d2818f356e7fc79f172e4091053fec
Reviewed-on: https://chromium-review.googlesource.com/1168105
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586373}
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/login_screen_controller.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/login_screen_controller.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/login_screen_controller_observer.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/login_screen_controller_observer.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/shelf/login_shelf_view.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/resources/chromeos/login/md_header_bar.js
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h

Comment 4 by xiaoyinh@chromium.org, Aug 27

Status: Fixed (was: Assigned)

Comment 5 by jdufault@chromium.org, Sep 10 

Issue 848873 has been merged into this issue.
►

Sign in to add a comment