New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 869809 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

DCHECK failed in DrawingRecorder

Reported by ana...@yandex-team.ru, Aug 1

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.103 YaBrowser/18.7.1.514 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
1. Open https://www.wikipedia.org
2. Try print page

What is the expected behavior?
Correct creation of preview

What went wrong?
Crashes with check failed in DrawingRecorder::~DrawingRecorder: 0u == picture->size() (0 vs. 1)"LayoutBlockFlow A class='link link_theme_normal organic__url link_cropped_no i-bem'" 

Did this work before? Yes 

Chrome version: 67.0.3396.103  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 28.0 r0

I guess it doesn't work after CL: https://chromium.googlesource.com/chromium/src/+/dc7889d8b9027cc1b7ce22790fbf74bc0ab5d7a2%5E%21/#F0
 
Also, when we can catch another problem  when trying print page, another dcheck on some pages facebook(https://www.facebook.com/natgeo/) for example: 
PaintController::CheckDuplicatePaintChunkId: Check failed: false. New paint chunk id *** has duplicated id with previous chuck PaintChunk.

Labels: Needs-Bisect Needs-Triage-M67
Cc: krajshree@chromium.org
Components: Internals>Printing Internals>Skia
Labels: Triaged-ET Needs-Feedback
Unable to reproduce the issue on Win-10 using chrome latest stable #68.0.3440.84 and latest canary #70.0.3508.0.
Attached a screen cast for reference.

Following are the steps followed to reproduce the issue.
------------
1. Opened https://www.wikipedia.org
2. Printed page.
3. Observed correct creation of preview as expected and did not observe any error. 

anakir@ - Could you please check the issue on latest stable #68.0.3440.84 by creating a new profile without any apps and extensions and please let us know if the issue still persists or not. Also please check the attached screen cast and please let us know if anything missed from our end.

Thanks...!!
869809.mp4
604 KB View Download
Cc: wangxianzhu@chromium.org
Components: -Internals>Skia Blink
Labels: -Needs-Feedback -Needs-Bisect -Needs-Triage-M67
Components: -Blink Blink>Paint
Hello!
Sorry, I did not specify, that it's must be debug build. In stable and canary builds dcheck-s don't work.
Attach video with crash.
Thanks!

chromium_dcheck.mp4
7.4 MB View Download
Owner: vmp...@chromium.org
Status: Assigned (was: Unconfirmed)
vmpstr@, would you again care to be the wangxianzhu@ replacement?

I think it's fine to reassign to him if you're overloaded because this only affects debug builds and it can wait.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dd3f68274a4dc9e86398dae9d3e4862e644e543

commit 0dd3f68274a4dc9e86398dae9d3e4862e644e543
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Thu Aug 02 21:15:40 2018

Make PaintController::IsSkippingCache return true for transient types.

This patch ensures that IsSkippingCache, which is the only public
indicator that we might skip a cache, to return true if the paint
controller is transient. This ensures that DCHECKs that verify the
caches don't fire if they are guarded by IsSkippingCache checks.

R=pdr@chromium.org, chrishtr@chromium.org

Bug:  869809 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1051609f65588dbef31e6d2b81e77d16752d2982
Reviewed-on: https://chromium-review.googlesource.com/1161057
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580322}
[modify] https://crrev.com/0dd3f68274a4dc9e86398dae9d3e4862e644e543/third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
[modify] https://crrev.com/0dd3f68274a4dc9e86398dae9d3e4862e644e543/third_party/blink/renderer/platform/graphics/paint/paint_controller.h

Status: Fixed (was: Assigned)

Sign in to add a comment