New issue
Advanced search Search tips

Issue 869804 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

personal information can be find in chrome log

Reported by zhongmin...@hisense.com, Aug 1

Issue description

Steps to reproduce the problem:
1.connect your android phone to computer
2.make sure the adb is ok and start to catch adb log
3. launch www.google.fr/www.google.com in chrome
4. search something by key for sample "Yahoo"
5. you can find Yahoo in adb log

What is the expected behavior?
Remove all personal information in chrome log of android system

What went wrong?
we can find search key like "Yahoo" in adb log,This does not comply with European norms

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 65.0.3325.109  Channel: n/a
OS Version: 8.1
Flash Version: 

The latest version of chrome can also reproduce this issue
 
main.txt
761 KB View Download
Labels: Needs-triage-Mobile
Cc: chelamcherla@chromium.org
Components: UI>Browser>Mobile
Labels: Target-70 M-70 Triaged-Mobile FoundIn-70
Status: Untriaged (was: Unconfirmed)
Tested this issue on Android and able to reproduce this issue.

Steps Followed:
1. Connected device to pc, started to catch log using adb logcat -v time > destination path
2. Observed searched keyword is present in log

Chrome versions tested:
60.0.3072.0, 68.0.3440.70 ; 70.0.3509.0(canary)

OS:
Android 9

Android Devices:
Pixel 2 XL

This seems to be a Non-Regression issue as same behavior is seen from M-60 builds. Leaving the issue as Untriaged  for further input's on this issue.
 
Thanks!
Cc: yfried...@chromium.org
Components: Privacy
Anything logging to Chrome's console is logged to logcat, which is intended for helping diagnose issues with the site.  This behavior has been unchanged since launch, but I'll defer to privacy whether this matters.

In the event the logs are sent to Google for crash triage, we actually redact the PII on the client before ever sending to the user.

https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnable.java?l=27

+yfriedman for more context
Hi, yfriedman
due to the rule from Orange , this console log with personal information is not allowed,
is there an incoming version which disabled the console log 
or if we can set current chrome console log  disabled

Ya, this isn't chrome producing this output, really. We're relaying it from the site which is logging something. As Ted mentioned anything logged to the console ends up getting output to logcat and it's been that way since the very first version of chrome for android. We are careful not to log anything from chrome itself about visited websites and also redact PII before uploading any logs
Status: WontFix (was: Untriaged)
WontFix per comment #c5.
Issue 864998 has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f6d26a160ae21152cd1f4f1d89bed73ffa0f8d0

commit 1f6d26a160ae21152cd1f4f1d89bed73ffa0f8d0
Author: Yaron Friedman <yfriedman@chromium.org>
Date: Tue Oct 09 21:59:13 2018

[Android] Strip console.log output from USER builds.

Even though it's a website that's calling console.log and dumping text
to logcat, there's some sense in limiting this output just to debug
builds of android (USERDEBUG/ENG). This may limit some of the logging
information provided in crash reports but that should arguably be
reported some other way and not in globally-visible logcat on the
device.
BUG= 869804 

Change-Id: Ic7720bfe6c9ad24836b8f638a9eeffc91d861a40
Reviewed-on: https://chromium-review.googlesource.com/c/1264742
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598096}
[modify] https://crrev.com/1f6d26a160ae21152cd1f4f1d89bed73ffa0f8d0/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java
[modify] https://crrev.com/1f6d26a160ae21152cd1f4f1d89bed73ffa0f8d0/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

Status: Fixed (was: WontFix)

Sign in to add a comment