New issue
Advanced search Search tips

Issue 869757 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

The RelaunchNotification bubble and dialog are too aggressive on canary and dev

Project Member Reported by grt@chromium.org, Aug 1

Issue description

The notifications (either the recommended bubble or the required dialog) first appear when the UpgradeDetector announces that the "low" annoyance level has been reached. On canary and dev (the so-called "unstable channels"), this happens after an hour rather than after two days. While this makes sense for the coloration of the app menu, the notification is a bit too annoying at this pace. On top of that, this behavior is not documented, so it's surprising for everyone.

The notification schedule should not change based on the channel.

Additionally, it looks like the bubble reshows never happen for these channels since the "high" annoyance level is never announced by the UpgradeDetector.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60

commit e5a1e98b7c79f9ee81bd9aa28762394073dc1c60
Author: Greg Thompson <grt@chromium.org>
Date: Wed Aug 08 11:37:53 2018

Do not show relaunch notifications early on dev and canary.

Previously, the UpgradeDetector notified observers that the "low"
annoyance level had been reached after only one hour for canary and dev
channels (the so-called "unstable" channels). This was to entice users
of such to relaunch earlier than is the case for beta and stable (the
so-called "stable" channels). This is all well and good for the color
changes to the app menu, but is a bit too aggressive when it also
triggers the relaunch recommended bubble or the relaunch required
dialog.

This change makes the relaunch notifications follow the beta and stable
schedule for all channels. This is accomplished by the following
modifications:

- A new "very low" annoyance level has been introduced to the
  UpgradeDetector's "update avisory system". This fires for desktop
  Chrome one hour after an update is detected. It is unused on Chrome
  OS, where the "low" annoyance level is fired the moment an update is
  detected.

- There is no longer any notion of "unstable" channels in the desktop
  implementation of UpgradeDetector (UpgradeDetectorImpl), so "very low"
  is always issued after one hour, and "low" is always issued after two
  days (again, desktop Chrome only; barring use of the
  RelaunchNotificationPeriod policy setting).

- AppMenuIconController now takes care of updating the menu when it
  observes "very low" or "low" based on Chrome's channel.

BUG= 869757 

Change-Id: I1deef28b3986de239df00fe1e806d4404f28fd11
Reviewed-on: https://chromium-review.googlesource.com/1162162
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581520}
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/ash/public/interfaces/update.mojom
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/ash/system/update/tray_update.cc
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/metrics/upgrade_metrics_provider.cc
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/metrics/upgrade_metrics_provider.h
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/metrics/upgrade_metrics_provider_unittest.cc
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/ui/toolbar/app_menu_icon_controller.cc
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/ui/toolbar/app_menu_icon_controller.h
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller.cc
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller.h
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_unittest.cc
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/upgrade_detector.cc
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/upgrade_detector.h
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/upgrade_detector_impl.cc
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/upgrade_detector_impl.h
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/chrome/browser/upgrade_detector_impl_unittest.cc
[modify] https://crrev.com/e5a1e98b7c79f9ee81bd9aa28762394073dc1c60/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment