New issue
Advanced search Search tips

Issue 869749 link

Starred by 1 user
Status: Fixed
Owner:
chenghan@chromium.org
Closed: Aug 15
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

factory: `ectool usbpdpower` parse error

Project Member Reported by chenghan@chromium.org, Aug 1 
Chrome Version: ToT
OS: ChromeOS

The usbpd info reported by `ectool usbpdpower` does not necessarily have the power (mW) field, causing the regular expression in usb_c.py to fail. It is an expected behavior, since print_pd_power_info() only reports power when the value is not 0. We should change the regular expression to successfully parse it.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/757a05897126460f8ffcb33665389e6b8f979254

commit 757a05897126460f8ffcb33665389e6b8f979254
Author: Cheng-Han Yang <chenghan@google.com>
Date: Wed Aug 01 21:52:33 2018

device: usb_c: Fix usbpdpower parse error

BUG= chromium:869749 
TEST=make test, manually test on DUT

Change-Id: I27a4e740f3d1d4d133a01b93a2c5f2ff832af6d4
Reviewed-on: https://chromium-review.googlesource.com/1157960
Commit-Ready: Cheng-Han Yang <chenghan@chromium.org>
Tested-by: Cheng-Han Yang <chenghan@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/757a05897126460f8ffcb33665389e6b8f979254/py/device/usb_c.py

Comment 2 by hungte@chromium.org, Aug 15

Status: Fixed (was: Untriaged)
►

Sign in to add a comment