Issue metadata
Sign in to add a comment
|
Screen reader does not report title of find dialog |
||||||||||||||||||||||||
Issue descriptionVersion 70.0.3508.0 (Official Build) canary (64-bit) Version 69.0.3497.12 (Official Build) dev (64-bit) JAWS Version 2018.1807.29 ILM NVDA version 2018.2.1 Windows Version 1709 (OS Build 16299.547) Steps: Launch either JAWS or NVDA # Launch any of above versions of Chrome # press CTRL +F to invoke find dialog # invoke screen reader’s report title command (modifier + T) Expected: screen reader announces title of find dialog Actual: screen reader only announces title of page in focus Notes: Reproduces in Canary and Dev Reproduces with JAWS and NVDA
,
Aug 7
,
Aug 17
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/find_bar_view.h See also issue 775680 , but the find bar is different because it isn't actually implemented as a dialog.
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34ff47daecf34cc73d0fa4a062c5733eb2e2e6a5 commit 34ff47daecf34cc73d0fa4a062c5733eb2e2e6a5 Author: James Wallace-Lee <jamwalla@chromium.org> Date: Tue Sep 11 23:13:49 2018 GetFocusedChildWidgetForAccessibility should return any focused widget Modify ViewAccessibilityUtils::GetFocusedChildWidgetForAccessibility to return any widget that is visible and focused. Previously, this was limited to tab-modal dialogs. Other focused widgets, like the Find bar, should be treated in the same way. Bug: 869703 Change-Id: I720bdd1e9c8d665d839296aa9bfd4c9490805dbd Reviewed-on: https://chromium-review.googlesource.com/1208810 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#590523} [modify] https://crrev.com/34ff47daecf34cc73d0fa4a062c5733eb2e2e6a5/ui/views/accessibility/view_accessibility_utils.cc [modify] https://crrev.com/34ff47daecf34cc73d0fa4a062c5733eb2e2e6a5/ui/views/accessibility/view_accessibility_utils.h
,
Sep 12
The above commit doesn't fix this bug, but makes the find bar show up properly in the accessibility tree. Insert+B works correctly now; Insert+T now reads "Chrome". I think fixing the next part will involve changing FindBarView code, and should be similar to issue 867723.
,
Sep 18
,
Sep 18
,
Sep 18
,
Sep 18
,
Sep 25
,
Dec 13
,
Dec 13
CL will fix issues with NVDA, but the machinery for JAWS and Narrator seems to be broken at a lower level - see also issue #867723.
,
Dec 13
,
Dec 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c106ac5879a768a9a37f65e13977682ece96a6c commit 0c106ac5879a768a9a37f65e13977682ece96a6c Author: Dana Fried <dfried@chromium.org> Date: Sat Dec 15 00:28:56 2018 Fix find in page dialog title. Title should now be announced when CTRL+F is pressed as well as when the user presses ACCESSIBILITY_KEY+T. Bug: 869703 Change-Id: If94076cfb7a09aac1965950fcb43e3cde649872b Reviewed-on: https://chromium-review.googlesource.com/c/1376722 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#616891} [modify] https://crrev.com/0c106ac5879a768a9a37f65e13977682ece96a6c/chrome/browser/ui/views/dropdown_bar_host.cc [modify] https://crrev.com/0c106ac5879a768a9a37f65e13977682ece96a6c/chrome/browser/ui/views/dropdown_bar_host.h [modify] https://crrev.com/0c106ac5879a768a9a37f65e13977682ece96a6c/chrome/browser/ui/views/find_bar_host.cc [modify] https://crrev.com/0c106ac5879a768a9a37f65e13977682ece96a6c/chrome/browser/ui/views/find_bar_host.h [modify] https://crrev.com/0c106ac5879a768a9a37f65e13977682ece96a6c/components/find_in_page_strings.grdp
,
Dec 18
,
Dec 18
Version 73.0.3644.0 (Official Build) canary (64-bit) The issue does not repro in this version. Thanks |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by leberly@chromium.org
, Aug 7