New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Team-Accessibility


Participants' hotlists:
Hotlist-1


Sign in to add a comment
link

Issue 869703: Screen reader does not report title of find dialog

Reported by lprazdnik@google.com, Aug 1 Project Member

Issue description

Version 70.0.3508.0 (Official Build) canary (64-bit)
Version 69.0.3497.12 (Official Build) dev (64-bit)
JAWS Version 2018.1807.29 ILM
NVDA version 2018.2.1
Windows Version 1709 (OS Build 16299.547)

Steps:
Launch either JAWS or NVDA
# Launch any of above versions of Chrome
# press CTRL +F to invoke find dialog
# invoke screen reader’s report title command (modifier + T)
Expected: screen reader announces title of find dialog
Actual: screen reader only announces title of page in focus

Notes:
Reproduces in Canary and Dev
Reproduces with JAWS and NVDA
 

Comment 1 by leberly@chromium.org, Aug 7

Labels: Dialogs

Comment 2 by leberly@chromium.org, Aug 7

Labels: a11y-Dialogs

Comment 3 by jamwalla@chromium.org, Aug 17

Cc: jamwalla@chromium.org
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/find_bar_view.h

See also  issue 775680 , but the find bar is different because it isn't actually implemented as a dialog.

Comment 4 by bugdroid1@chromium.org, Sep 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34ff47daecf34cc73d0fa4a062c5733eb2e2e6a5

commit 34ff47daecf34cc73d0fa4a062c5733eb2e2e6a5
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Tue Sep 11 23:13:49 2018

GetFocusedChildWidgetForAccessibility should return any focused widget

Modify ViewAccessibilityUtils::GetFocusedChildWidgetForAccessibility to
return any widget that is visible and focused.

Previously, this was limited to tab-modal dialogs. Other focused
widgets, like the Find bar, should be treated in the same way.

Bug:  869703 
Change-Id: I720bdd1e9c8d665d839296aa9bfd4c9490805dbd
Reviewed-on: https://chromium-review.googlesource.com/1208810
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590523}
[modify] https://crrev.com/34ff47daecf34cc73d0fa4a062c5733eb2e2e6a5/ui/views/accessibility/view_accessibility_utils.cc
[modify] https://crrev.com/34ff47daecf34cc73d0fa4a062c5733eb2e2e6a5/ui/views/accessibility/view_accessibility_utils.h

Comment 5 by jamwalla@chromium.org, Sep 12

The above commit doesn't fix this bug, but makes the find bar show up properly in the accessibility tree. Insert+B works correctly now; Insert+T now reads "Chrome". I think fixing the next part will involve changing FindBarView code, and should be similar to issue 867723.

Comment 6 by lpalmaro@google.com, Sep 18

Labels: pm-markchang

Comment 7 by jamwalla@chromium.org, Sep 18

Labels: -a11y-Dialogs

Comment 8 by jamwalla@chromium.org, Sep 18

Labels: -dialogs

Comment 9 by jamwalla@chromium.org, Sep 18

Labels: --a11y-Dialogs

Comment 10 by robliao@chromium.org, Sep 25

Labels: Group-Secondary_UI

Comment 11 by dfried@chromium.org, Dec 13

Owner: dfried@chromium.org
Status: Assigned (was: Available)

Comment 12 by dfried@chromium.org, Dec 13

Status: Started (was: Assigned)
CL will fix issues with NVDA, but the machinery for JAWS and Narrator seems to be broken at a lower level - see also issue #867723.

Comment 13 by dfried@chromium.org, Dec 13

Labels: JAWS-specific

Comment 14 by bugdroid1@chromium.org, Dec 15

Project Member

Comment 15 by dfried@chromium.org, Dec 18

Status: Fixed (was: Started)

Comment 16 by lprazdnik@chromium.org, Dec 18

Status: Verified (was: Fixed)
Version 73.0.3644.0 (Official Build) canary (64-bit)
The issue does not repro in this version.
Thanks

Sign in to add a comment