New issue
Advanced search Search tips

Issue 869696 link

Starred by 2 users

Issue metadata

Status: ExternalDependency
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Clean up fdio_transfer_fd() error-case handling

Project Member Reported by w...@chromium.org, Aug 1

Issue description

fdio_transfer_fd() has two failure modes with (currently) differing behaviours:
1. The internal unwrap() operation fails. In this case the call fails and the descriptor is closed.
2. The descriptor shares the description with another descriptor, via dup(), preventing it from being transferred. In this case the call fails but the descriptor remains valid.

We don't handle these failure-modes correctly everywhere. The API itself should be made more consistent, e.g. by at least having a specific return code to look for to distinguish the failure cases.

 
We should also check whether we can make use of fdio_get_service_handle() in base::fuchsia::GetHandleFromFile().
Labels: -Pri-3 M-70 Pri-2
Owner: w...@chromium.org
Status: Assigned (was: Untriaged)
Status: ExternalDependency (was: Assigned)
Filed ZX-2445 for this.
Labels: -Pri-2 -M-70 Pri-3
De-prioritizing, as an external-dependency tracking bug.

Sign in to add a comment