New issue
Advanced search Search tips

Issue 869692 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Differentiate AccessEntryPoint OfflinePages.AccessEntryPoint UMA reported from clicking between notification and download home

Project Member Reported by jianli@chromium.org, Jul 31

Issue description

Currently we report all these cases as "Downloads home". We should separate them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe36308d16fd8db3149bfad82abbe83b03de43e2

commit fe36308d16fd8db3149bfad82abbe83b03de43e2
Author: Jian Li <jianli@chromium.org>
Date: Thu Aug 09 22:33:10 2018

Report different UMA enums when clicking async download notification

Currently it is reported as "Download Home". We now add the logic
to separate it out, together with the case that clicking from progress
bar.

Bug:  869692 
Change-Id: I9f2fcbbac20da9cf23176a00505fe10d04136b2f
Tbr: dgn@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1157644
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581930}
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/android/java/src/org/chromium/chrome/browser/download/home/glue/OfflineContentProviderGlue.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/android/java/src/org/chromium/chrome/browser/download/items/DownloadBlockedOfflineContentProvider.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/android/java/src/org/chromium/chrome/browser/download/items/OfflineContentAggregatorNotificationBridgeUi.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/browser/download/download_offline_content_provider.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/browser/download/download_offline_content_provider.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/browser/offline_pages/android/offline_page_bridge.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/browser/offline_pages/offline_page_request_handler.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/chrome/browser/offline_pages/offline_page_request_handler.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/BUILD.gn
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineContentAggregatorBridge.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineContentProvider.java
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/android/offline_content_aggregator_bridge.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/android/offline_content_aggregator_bridge.h
[add] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/launch_location.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/offline_content_aggregator.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/offline_content_aggregator.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/offline_content_aggregator_unittest.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/offline_content_provider.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/test_support/mock_offline_content_provider.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/throttled_offline_content_provider.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/throttled_offline_content_provider.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_items_collection/core/throttled_offline_content_provider_unittest.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_pages/core/downloads/download_ui_adapter.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_pages/core/request_header/offline_page_header.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_pages/core/request_header/offline_page_header.h
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/components/offline_pages/core/request_header/offline_page_header_unittest.cc
[modify] https://crrev.com/fe36308d16fd8db3149bfad82abbe83b03de43e2/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62

commit 4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Mon Aug 13 07:36:40 2018

Revert "Report different UMA enums when clicking async download notification"

This reverts commit fe36308d16fd8db3149bfad82abbe83b03de43e2.

Reason for revert: OfflinePageBridgeTest.testGetLoadUrlParamsForOpeningMhtmlFileUrl seems failing. This is the only CL relevant to offline pages, so let me revert this speculatively.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest%23testGetLoadUrlParamsForOpeningMhtmlFileUrl


Original change's description:
> Report different UMA enums when clicking async download notification
> 
> Currently it is reported as "Download Home". We now add the logic
> to separate it out, together with the case that clicking from progress
> bar.
> 
> Bug:  869692 
> Change-Id: I9f2fcbbac20da9cf23176a00505fe10d04136b2f
> Tbr: dgn@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/1157644
> Commit-Queue: Jian Li <jianli@chromium.org>
> Reviewed-by: Dmitry Titov <dimich@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581930}

TBR=peter@chromium.org,dimich@chromium.org,jianli@chromium.org,qinmin@chromium.org,dgn@chromium.org,holte@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  869692 
Change-Id: Ifaee7de7a978f3795a6cf701d4420aa04736b169
Reviewed-on: https://chromium-review.googlesource.com/1172182
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582522}
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/android/java/src/org/chromium/chrome/browser/download/home/glue/OfflineContentProviderGlue.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/android/java/src/org/chromium/chrome/browser/download/items/DownloadBlockedOfflineContentProvider.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/android/java/src/org/chromium/chrome/browser/download/items/OfflineContentAggregatorNotificationBridgeUi.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/browser/download/download_offline_content_provider.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/browser/download/download_offline_content_provider.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/browser/offline_pages/android/offline_page_bridge.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/browser/offline_pages/offline_page_request_handler.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/chrome/browser/offline_pages/offline_page_request_handler.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/BUILD.gn
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineContentAggregatorBridge.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineContentProvider.java
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/android/offline_content_aggregator_bridge.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/android/offline_content_aggregator_bridge.h
[delete] https://crrev.com/569df7dcc3fc79333c07c1b34b480f366ecf82a1/components/offline_items_collection/core/launch_location.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/offline_content_aggregator.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/offline_content_aggregator.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/offline_content_aggregator_unittest.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/offline_content_provider.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/test_support/mock_offline_content_provider.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/throttled_offline_content_provider.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/throttled_offline_content_provider.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_items_collection/core/throttled_offline_content_provider_unittest.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_pages/core/downloads/download_ui_adapter.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_pages/core/request_header/offline_page_header.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_pages/core/request_header/offline_page_header.h
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/components/offline_pages/core/request_header/offline_page_header_unittest.cc
[modify] https://crrev.com/4f3c0be4dd6bf52e4bf4edb5d81f09800bfaaa62/tools/metrics/histograms/enums.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d75b541a3d3607a3a95be116ecafed906b9de243

commit d75b541a3d3607a3a95be116ecafed906b9de243
Author: Jian Li <jianli@chromium.org>
Date: Tue Aug 14 00:05:44 2018

Reland: Report different UMA enums when clicking async download notification

Currently it is reported as "Download Home". We now add the logic
to separate it out, together with the case that clicking from progress
bar.

This was previously reviewed at
https://chromium-review.googlesource.com/c/chromium/src/+/1157644

It was landed and reverted due to test failure. I am relanding it to fix
the test failure.

Bug:  869692 
Change-Id: I9bfe0a2b1fc0e984fe258c3c28be3491fe6bca99
Tbr: dgn@chromium.org
Tbr: dimich@chromium.org
Tbr: peter@chromium.org
Tbr: holte@chromium.org
Tbr: qinmin@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1173268
Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582759}
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/java/src/org/chromium/chrome/browser/download/home/glue/OfflineContentProviderGlue.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/java/src/org/chromium/chrome/browser/download/items/DownloadBlockedOfflineContentProvider.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/java/src/org/chromium/chrome/browser/download/items/OfflineContentAggregatorNotificationBridgeUi.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/browser/download/download_offline_content_provider.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/browser/download/download_offline_content_provider.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/browser/offline_pages/android/offline_page_bridge.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/browser/offline_pages/offline_page_request_handler.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/chrome/browser/offline_pages/offline_page_request_handler.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/BUILD.gn
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineContentAggregatorBridge.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineContentProvider.java
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/android/offline_content_aggregator_bridge.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/android/offline_content_aggregator_bridge.h
[add] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/launch_location.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/offline_content_aggregator.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/offline_content_aggregator.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/offline_content_aggregator_unittest.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/offline_content_provider.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/test_support/mock_offline_content_provider.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/throttled_offline_content_provider.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/throttled_offline_content_provider.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_items_collection/core/throttled_offline_content_provider_unittest.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_pages/core/downloads/download_ui_adapter.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_pages/core/request_header/offline_page_header.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_pages/core/request_header/offline_page_header.h
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/components/offline_pages/core/request_header/offline_page_header_unittest.cc
[modify] https://crrev.com/d75b541a3d3607a3a95be116ecafed906b9de243/tools/metrics/histograms/enums.xml

Sign in to add a comment