[Findit] Flake Analyzer - Continue analysis without heuristic analysis if failure to obtain them |
||
Issue descriptionIn some rare cases, git_blame or the revision list is returned as None which can cause problems in heuristic analysis. Even if heuristic analysis fails, regular analysis can still continue without results.
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/4c32766be0d2777199bbe2f45ec61cd208dbcce8 commit 4c32766be0d2777199bbe2f45ec61cd208dbcce8 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Fri Aug 03 19:15:20 2018 [Findit] Flake Analyzer - Continue without heuristic results if failure to obtain them The analysis that surfaced this had an edge case where the revision list was None due to network error, causing an exception later down the line. Even if the analysis fails to find suspects, regular bisect should still have the chance to analyze the flaky test. Bug: 869685 Change-Id: Iadb1522d02d7e0aa094abf3f58d8018eafee9fa7 Reviewed-on: https://chromium-review.googlesource.com/1157555 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/4c32766be0d2777199bbe2f45ec61cd208dbcce8/appengine/findit/services/flake_failure/test/heuristic_analysis_test.py [modify] https://crrev.com/4c32766be0d2777199bbe2f45ec61cd208dbcce8/appengine/findit/services/flake_failure/heuristic_analysis.py
,
Aug 4
|
||
►
Sign in to add a comment |
||
Comment 1 by lijeffrey@chromium.org
, Aug 1