New issue
Advanced search Search tips

Issue 869662 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression

Blocked on:
issue 897520



Sign in to add a comment

virtual/threaded/fast/scrolling/overflow-scrollability.html are slow on mac 10.13

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 31

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of dpranke@google.com

virtual/outofblink-cors-ns/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html and 3 other(s) in webkit_layout_tests failing on chromium.mac/Mac10.13 Tests

Builders failed on: 
- Mac10.13 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests


 
Cc: -dpranke@google.com dpranke@chromium.org
The tests are:

virtual/outofblink-cors-ns/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html
virtual/outofblink-cors-ns/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html
virtual/outofblink-cors/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html
virtual/threaded/fast/scrolling/overflow-scrollability.html

I'm not sure if this is the result of switching to 10.13 or not, but I suspect it is.

Suppressing failures for now while investigating (pls don't revert the change).
Components: Blink
Summary: virtual/outofblink-cors-ns/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html and 3 other(s) are slow (was: virtual/outofblink-cors-ns/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html and 3 other(s) in webkit_layout_tests failing on chromium.mac/Mac10.13 Tests)
It looks like these tests are all really slow (but not marked as such) and were almost timing out before. Marking them as Slow should be sufficient.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5daa8048adfc79c170d639eeda8dc96eeab16fb7

commit 5daa8048adfc79c170d639eeda8dc96eeab16fb7
Author: Dirk Pranke <dpranke@chromium.org>
Date: Tue Jul 31 23:38:45 2018

Mark a few webkit_layout_tests as Slow.

The recent switch from running the webkit_layout_tests on 10.12 by default
to 10.13 has revealed a few tests that were almost timing out before and
are now timing out on 10.13 due to the slightly slower configurations.

This CL marks the four tests as Slow to avoid this.

virtual/outofblink-cors-ns/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html
virtual/outofblink-cors-ns/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html
virtual/outofblink-cors/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html
virtual/threaded/fast/scrolling/overflow-scrollability.html

TBR=fdegans
NOTRY=true
Bug: 869662

Change-Id: Ib22bc7c2aaca91ee8b699e99cbd22a8d419e9fe8
Reviewed-on: https://chromium-review.googlesource.com/1157536
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579622}
[modify] https://crrev.com/5daa8048adfc79c170d639eeda8dc96eeab16fb7/third_party/WebKit/LayoutTests/SlowTests

Components: -Blink Blink>Network>XHR Blink>SecurityFeature
Cc: yhirano@chromium.org toyoshim@chromium.org
Issue 869800 has been merged into this issue.
Labels: OOR-CORS
Owner: toyoshim@chromium.org
Status: Assigned (was: Available)
Components: -Blink>SecurityFeature -Blink>Network>XHR Blink
Labels: -OOR-CORS
Owner: ----
Status: Available (was: Assigned)
Summary: virtual/threaded/fast/scrolling/overflow-scrollability.html are slow on mac 10.13 (was: virtual/outofblink-cors-ns/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html and 3 other(s) are slow)
The bug was for mac 10.13 specific slow tests.

We are seeing slow results on outofblink-cors tests even on other bots. So, let me split it and remove CORS related flag again.
Components: -Blink Blink>Infra
Labels: OS-Mac Type-Bug-Regression
Labels: -Sheriff-Chromium
Owner: bokan@chromium.org
bokan@: PTAL
Status: Assigned (was: Available)
Components: Blink>Scroll
bokan@, this came up in https://foolip.github.io/ecosystem-infra-rotation/ today, is this something you're still working on?
It is, unfortunately we've got a really bad problem with input tests due to the highly async nature of our pipeline. Our testing infrastructure hasn't kept up with changes in the pipeline so we have a ton of flaky and slow tests like this. Unfortunately it's not possible to make these perfectly reliable and we've spent much time trying to fix tests but having them come back flaky.

I'm actively building out improved infrastructure so that we can make tests like this fast and reliable. Details are in https://docs.google.com/document/d/1B4hXTkEsvixMAB7xT1MSLlQtEEApZK5xzSMwNScQGKg/edit# if you're interested. The goal is to make it so we don't have to "guess" when a scroll/input might be finished and in that case we can make tests run faster and more reliably.

tl;dr Working on it but it'll be a while before I get to individual tests like this.


Blockedon: 883717
Blockedon: -883717 897520
sorry, not this one, it is the fractional_scrolling_threaded one that is timing out, will file another bug.

Sign in to add a comment