DXVAVideoDecodeAccelerator should report a visible size |
||
Issue descriptionCurrently DXVAVideoDecodeAccelerator reports a visible rect of (0, 0), which causes the VDA host to substitute in the config's size. This prevents correct handling of in-stream size changes, but also is incompatible with using MojoVideoDecoder for WebRTC decoding, where we don't know the correct size at the time that the decoder is initialized.
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e10dc3ec0cacd865cede77c59255c2bae2358d1f commit e10dc3ec0cacd865cede77c59255c2bae2358d1f Author: Dan Sanders <sandersd@chromium.org> Date: Mon Aug 13 21:27:24 2018 Report a visible_rect from DXVAVideoDecodeAccelerator. I was unable to find a MF/DXVA API to retrieve this, so the value is extracted by the config change detector. If there is a platform API, it would (probably) be better, since the behavior would be more likely to match decoder quirks. Bug: 869660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6802c682534f91499a27da7135acc74cbc61911f Reviewed-on: https://chromium-review.googlesource.com/1170096 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#582707} [modify] https://crrev.com/e10dc3ec0cacd865cede77c59255c2bae2358d1f/media/gpu/windows/dxva_picture_buffer_win.h [modify] https://crrev.com/e10dc3ec0cacd865cede77c59255c2bae2358d1f/media/gpu/windows/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/e10dc3ec0cacd865cede77c59255c2bae2358d1f/media/gpu/windows/dxva_video_decode_accelerator_win.h
,
Aug 17
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37eb921a67d7128422eb10abee4b1eefbbe75f1c commit 37eb921a67d7128422eb10abee4b1eefbbe75f1c Author: Dan Sanders <sandersd@chromium.org> Date: Tue Dec 11 21:59:17 2018 [media] Remove outdated TODO. The issue mentioned in this TODO was already completed in the associated bug. Bug: 869660 Change-Id: I57f35558770a0c56441a899371eff5d723d76a26 Reviewed-on: https://chromium-review.googlesource.com/c/1371076 Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615678} [modify] https://crrev.com/37eb921a67d7128422eb10abee4b1eefbbe75f1c/content/renderer/media/webrtc/rtc_video_decoder_adapter.cc |
||
►
Sign in to add a comment |
||
Comment 1 by benhenry@chromium.org
, Aug 2