New issue
Advanced search Search tips

Issue 869651 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 678128



Sign in to add a comment

IsUVPAA broken when Touch ID is enabled

Project Member Reported by martinkr@google.com, Jul 31

Issue description

9aa7c54540178d4bc52f6ffc87567d76beb99094 introduced a crash in UVPAA when Touch ID is flag enabled
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcfda9cfef7e65ecee20cd15f52f9a390f109923

commit bcfda9cfef7e65ecee20cd15f52f9a390f109923
Author: Martin Kreichgauer <martinkr@google.com>
Date: Thu Aug 02 00:47:07 2018

device/fido: fix a crash in IsUVPAA if Touch ID is flag-enabled.

In 9aa7c54540178d4bc52f6ffc87567d76beb99094
AuthenticatorImpl::IsUserVerifyingPlatformAuthenticatorAvailable was
changed to make Touch ID unavailable in Incognito and if the embedder
does not provide a configuration for the Touch ID authenticator. The
latter check dereferenced a nullptr in AuthenticatorImpl's
request_delegate_.  request_delegate_ only gets initialized for the
duration of a MakeCredential or GetAssertion request. It is
uninitialized during IsUVPAA.

This works around the issue by adding a
IsWebAuthenticationTouchIdAuthenticatorSupported instance method to
ContentBrowserClient, so that the feature support can be checked without
requiring a request delegate instance.

Bug:  869651 
Change-Id: Ib64a2278d63047d68876e224d44a9aab96f9cfea
Reviewed-on: https://chromium-review.googlesource.com/1157605
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#580014}
[modify] https://crrev.com/bcfda9cfef7e65ecee20cd15f52f9a390f109923/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/bcfda9cfef7e65ecee20cd15f52f9a390f109923/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/bcfda9cfef7e65ecee20cd15f52f9a390f109923/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/bcfda9cfef7e65ecee20cd15f52f9a390f109923/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/bcfda9cfef7e65ecee20cd15f52f9a390f109923/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/bcfda9cfef7e65ecee20cd15f52f9a390f109923/content/public/browser/content_browser_client.h

Status: Fixed (was: Started)

Sign in to add a comment