Issue 867132  has been merged into this issue.

Yes. I'm not sure how this is determined but can we limit to 50?

Yes, that's doable. However, the limiting factor in this case also appears to be the max width of the folder name which is responsible for truncating long folder names. E.g. A folder name with wider characters (O) will reach the truncation faster than folder names with thinner characters (l).

Should we change the max folder name width field to allow the user to reach the 50 character limit without truncation? And if so, what to?

Sure, let's try that

Hey,

The current label width is set to 204 which can accommodate ~28 characters (at least in our alphabet). I've attached a preview of an title matching the max width. If we make it bigger, the padding will look cramped in small groups.

My recommendation would be to limit it to 28 characters, still allowing some freedom for group naming while matching the limited width.

Shiba WDYT?

Deleted: name preview.png 29.3 KB

	name preview.png 29.3 KB View Download

Sounds good Sebastien. Thanks for the screenshot. 

One more question: This works for 28 English characters, but what about other languages?

What do we do now? 

I'd be inclined to maintain the limit consistent unless we have a clear understanding of how much character we can display in 204px for each language.

Some things to note:
Currently, the folder name does not keep track of how many characters you type, it will just truncate the final name to the character limit.

If we set the character limit to 28, long 28 character names will still have the portion that exceeds 204px be replaced with a "..."

Possible discussed solutions:
Remove folder label width and let characters be the determining factor. As sgabriel@ noted, other languages might have a much wider 28 character length than 204px.

Reduce character limit. Other languages still may have the last part of their labels replaced with "..." if they are longer than 204px.

Discussed offline:

We want to set a hard character limit so that long folder names can't occur.

We also want to set a hard character limit in the folder name textfield itself so that the user cannot physically type more than the character limit; This would indicate to the user that they are at their character limit. This would probably be implemented as maximum width (in px?) in the textfield class.

At the current moment, we've decided this bug is not a high priority for M-70. We will update the hard character limit from 80 -> 28, but hold off on changing the textfield limit until later.

Sounds good. Thanks for looking into this.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/870f84343355fe3b8d9bb9f5736c822c960cb2b4

commit 870f84343355fe3b8d9bb9f5736c822c960cb2b4
Author: Daniel Zhang <oxyflush@google.com>
Date: Thu Aug 16 17:45:45 2018

cros: Change character limit of folders.

Change character limit of folders from 80 to 28. 80 is considered too large.

Bug:  869643 
Change-Id: I05d88ea55094d9a9d175740c16ed429b1ad5a53b
Reviewed-on: https://chromium-review.googlesource.com/1176643
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#583715}
[modify] https://crrev.com/870f84343355fe3b8d9bb9f5736c822c960cb2b4/ash/public/cpp/app_list/app_list_constants.cc

Since this fix is good enough for now, removing it from the hotlist and giving it an M-71 label.

Bulk moving all M-71 <P-1's to M-72.

Related to the other bug you are working on?

Bulk moving <p-1's to the next milestone because we branched to M-73.

 Issue 877412  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0a42fcb8c05e2e9011c743cb69167db0aa0df14

commit a0a42fcb8c05e2e9011c743cb69167db0aa0df14
Author: Matthew Mourgos <mmourgos@chromium.org>
Date: Fri Dec 07 20:04:31 2018

cros: Puts a hard 28 char limit in folder name entry field

Bug:  869643 
Change-Id: I85cfff694f3ce43d822c0126906e9266b3c39e9c
Reviewed-on: https://chromium-review.googlesource.com/c/1363838
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614794}
[modify] https://crrev.com/a0a42fcb8c05e2e9011c743cb69167db0aa0df14/ash/app_list/views/folder_header_view.cc
[modify] https://crrev.com/a0a42fcb8c05e2e9011c743cb69167db0aa0df14/ash/app_list/views/folder_header_view.h
[modify] https://crrev.com/a0a42fcb8c05e2e9011c743cb69167db0aa0df14/ash/app_list/views/folder_header_view_unittest.cc