New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 869641 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

PIN setup numpad has weird material design ripple (old ripple)

Project Member Reported by mmalpani@chromium.org, Jul 31

Issue description


PIN setup numpad has weird material design ripple (old ripple)
 
Components: -UI UI>Shell>LockScreen
Cc: sammiequon@chromium.org tbuck...@chromium.org zalcorn@chromium.org
Labels: Pri-2 Type-Bug
Owner: jdufault@chromium.org
Status: Assigned (was: Untriaged)
Cc: jdufault@chromium.org
Owner: sammiequon@chromium.org
Sammie, do you have time to take a look?
Cc: -sammiequon@chromium.org
Status: Started (was: Assigned)
elizabethchiu - I uploaded a screencast of the current behaviour - I don't know how to only cast that window though.
cinnamon-20180813-3.webm
2.8 MB View Download
Cc: sammiequon@chromium.org
Owner: namratakannan@chromium.org
+Namrata owner of the Web UI design.

Would you mind to let us know what is the proper ripples for web-ui?
The ripple behavior on the numpad is not per spec.

1.The color should be similar to:
https://docs.google.com/presentation/d/1kXbnGrFln4CapA0bavU5zjZLALqeD4aQikVVKSJ0zFg/edit#slide=id.g364d7f9db1_0_0

2.Plus the ripple lasts only for pressed/focused state. Here there seems to be a lag. And it expands from the center.Example any icon button in webui.
Attaching gif
  
ripple.gif
28.1 KB View Download
Cc: -sammiequon@chromium.org namratakannan@chromium.org
Owner: sammiequon@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0e8e86f030d12688914f9b29f632542261682bc

commit f0e8e86f030d12688914f9b29f632542261682bc
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Aug 14 21:04:21 2018

settings: Update ripples on setup PIN keyboard.

Also fix a bug where continue button was still enabled after tabbing to
and pressing backspace with the keyboard.

Test: manual
Bug:  855014 ,  869641 
Change-Id: I0f3e570fc87b1a2e60de112de47558885f5d4847
Reviewed-on: https://chromium-review.googlesource.com/1173139
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583030}
[modify] https://crrev.com/f0e8e86f030d12688914f9b29f632542261682bc/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/f0e8e86f030d12688914f9b29f632542261682bc/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html

Status: Fixed (was: Started)

Sign in to add a comment