New issue
Advanced search Search tips

Issue 869622 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

homecher opacity overlay does not resize on rotate if you start on portrait

Project Member Reported by newcomer@chromium.org, Jul 31

Issue description

Jul 23rd.
 
Cc: newcomer@chromium.org
Owner: weidongg@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f64b423a073fe17d9ba71d3d065dece1676fcc8e

commit f64b423a073fe17d9ba71d3d065dece1676fcc8e
Author: Weidong Guo <weidongg@chromium.org>
Date: Mon Aug 06 22:52:53 2018

Fix app list background shield issue for screen rotation

Background:
When screen is rotated to portrait, only half of the background shield
is shown because mask layer bounds is incorrectly updated.

1. Remove mask layer used to create corner radius for background
   shield and, instead, draw rounded corner background on Canvas.
2. As a side effect, this improves dragging smoothness.

Bug:  869622 
Change-Id: Ia3b8ce30e0f76f27cdc90ab674504915a79cfb99
Reviewed-on: https://chromium-review.googlesource.com/1164178
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581027}
[modify] https://crrev.com/f64b423a073fe17d9ba71d3d065dece1676fcc8e/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/f64b423a073fe17d9ba71d3d065dece1676fcc8e/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/f64b423a073fe17d9ba71d3d065dece1676fcc8e/ash/app_list/views/app_list_view.h

Status: Fixed (was: Started)

Sign in to add a comment