New issue
Advanced search Search tips

Issue 869614 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Aug 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

Chrome tab reparent windowing issue

Project Member Reported by mmalpani@chromium.org, Jul 31 
Open a bunch of Chrome tabs. Fling a tab downwards (so it opens a new window). Close the new window. Now you see the previous window 80% size of screen
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7da1451d38e5ddf35bcd711c19801a9ad9020251

commit 7da1451d38e5ddf35bcd711c19801a9ad9020251
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Thu Aug 02 17:06:36 2018

Tab dragging: Fix the wrong window size for the source window.

When the drag ends, the source window might still be in bounds animation,
thus we should compare the expected bounds to its target bounds.

Bug:  869614 , 823769
Change-Id: Ied81296fed19d16d3c833430860f9b20d2623431
Reviewed-on: https://chromium-review.googlesource.com/1159526
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580218}
[modify] https://crrev.com/7da1451d38e5ddf35bcd711c19801a9ad9020251/ash/wm/tablet_mode/tablet_mode_window_state.cc

Comment 2 by x...@chromium.org, Aug 2

Labels: Merge-Request-69
Status: Fixed (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 3

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 3

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecf75dc547cbc156e69d3250bc3483d9c47637d1

commit ecf75dc547cbc156e69d3250bc3483d9c47637d1
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Fri Aug 03 17:14:02 2018

[Merge to M69]Tab dragging: Fix the wrong window size for the source window.

When the drag ends, the source window might still be in bounds animation,
thus we should compare the expected bounds to its target bounds.

Bug:  869614 
TBR=oshima@chromium.org

Change-Id: Ied81296fed19d16d3c833430860f9b20d2623431
Reviewed-on: https://chromium-review.googlesource.com/1159526
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580218}(cherry picked from commit 7da1451d38e5ddf35bcd711c19801a9ad9020251)
Reviewed-on: https://chromium-review.googlesource.com/1162205
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#380}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/ecf75dc547cbc156e69d3250bc3483d9c47637d1/ash/wm/tablet_mode/tablet_mode_window_state.cc
►

Sign in to add a comment