GeolocationServiceTest.PermissionGranted*PolicyViolation tests fail if both 1) VizDisplayCompositor and 2) site-per-process are enabled |
|||||
Issue descriptionREPRO: DISPLAY=:20 out/rel/content_unittests --gtest_filter=*GeolocationServiceTest.PermissionGrantedNoPolicyViolation* --enable-features=VizDisplayCompositor --site-per-process [236824:236824:0731/153823.024413:628061287673:ERROR:render_widget_host_view_base.cc(177)] Not implemented reached in virtual uint32_t content::RenderWidgetHostViewBase::GetCaptureSequenceNumber() const [236824:236824:0731/153823.030294:628061293427:FATAL:host_frame_sink_manager.cc(296)] Check failed: frame_sink_manager_impl_. #0 0x7f8d9ccbefac base::debug::StackTrace::StackTrace() #1 0x7f8d9cbed3fb logging::LogMessage::~LogMessage() #2 0x7f8d9e2ee026 viz::HostFrameSinkManager::CreateCompositorFrameSinkSupport() #3 0x7f8d9af6ba54 content::RenderWidgetHostViewChildFrame::CreateCompositorFrameSinkSupport() #4 0x7f8d9af6b97c content::RenderWidgetHostViewChildFrame::RenderWidgetHostViewChildFrame() #5 0x7f8d9af6b742 content::RenderWidgetHostViewChildFrame::Create() #6 0x7f8d9ad0c4be content::RenderFrameHostImpl::CreateRenderFrame() #7 0x7f8d9b0b287b content::WebContentsImpl::CreateRenderFrameForRenderManager() #8 0x7f8d9ad2b536 content::RenderFrameHostManager::InitRenderFrame() #9 0x7f8d9ad2b0a4 content::RenderFrameHostManager::CreateRenderFrame() #10 0x7f8d9ad282a2 content::RenderFrameHostManager::CreateSpeculativeRenderFrameHost() #11 0x7f8d9ad27861 content::RenderFrameHostManager::GetFrameHostForNavigation() #12 0x7f8d9ad275aa content::RenderFrameHostManager::DidCreateNavigationRequest() #13 0x7f8d9acd00c2 content::FrameTreeNode::CreatedNavigationRequest() #14 0x7f8d9acfaee9 content::NavigatorImpl::OnBeginNavigation() #15 0x7f8d9ad11c99 content::RenderFrameHostImpl::BeginNavigation() #16 0x000001b28503 content::NavigationSimulator::SimulateRendererInitiatedStart() #17 0x000001b27c10 content::NavigationSimulator::Start() #18 0x000001b28e89 content::NavigationSimulator::ReadyToCommit() #19 0x000001b2936a content::NavigationSimulator::Commit() #20 0x000000b72c9d content::(anonymous namespace)::GeolocationServiceTest::CreateEmbeddedFrameAndGeolocationService() #21 0x000000b72e9d content::GeolocationServiceTest_PermissionGrantedNoPolicyViolation_Test::TestBody() #22 0x000001a45b92 testing::Test::Run() #23 0x000001a46670 testing::TestInfo::Run() #24 0x000001a46b87 testing::TestCase::Run() #25 0x000001a52597 testing::internal::UnitTestImpl::RunAllTests() #26 0x000001a5210d testing::UnitTest::Run() #27 0x000001b6e261 base::TestSuite::Run() #28 0x000001b75fbd base::(anonymous namespace)::LaunchUnitTestsInternal() #29 0x000001b75e11 base::LaunchUnitTests() #30 0x000001922856 main #31 0x7f8d924132b1 __libc_start_main #32 0x00000069202a _start
,
Aug 3
fsamuel@, could you PTAL and help assign to the right person? I am not sure how to properly initialize HostFrameSinkManager in unit tests (in such a way that it continues to work in presence of --site-per-process). I am also not sure where the initialization should take place (in the 2 individual tests VS in the GeolocationServiceTest suite VS in a more generic place like TestBrowserContext or TestBrowserThreadBundle).
,
Aug 13
The problem is this test overrides what's pass into the command line. I think this test should be updated to avoid doing this.
,
Aug 13
Passing along to mohsen@. Please let me know if you have further questions.
,
Aug 25
I'm unable to repro this. Doing a bisect, it seems that it is fixed as a side-effect of r584677.
,
Aug 27
CL to re-enable tests sent for review: https://crrev.com/c/1188695...
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7746e5874fd1f7131617995251ef9c6096dbe8ed commit 7746e5874fd1f7131617995251ef9c6096dbe8ed Author: Mohsen Izadi <mohsen@chromium.org> Date: Mon Aug 27 18:06:12 2018 Re-enable GeolocationServiceTest.PermissionGranted*PolicyViolation These tests were disabled when both Viz display compisitor and site-per-process are enabled. The issue seems to be fixed as a side-effect of r584677. BUG= 869613 Change-Id: I9ba7c48027da705b8f8056ebf9acb96b857b1b8c Reviewed-on: https://chromium-review.googlesource.com/1188695 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#586316} [modify] https://crrev.com/7746e5874fd1f7131617995251ef9c6096dbe8ed/content/browser/geolocation/geolocation_service_impl_unittest.cc
,
Aug 27
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by lukasza@chromium.org
, Jul 31