Reduce margin above Google logo on NTP |
|||||||
Issue descriptionIn the absence of the top toolbar on the NTP, there appears to be too much space above the google logo. We should reduce this when Duet is enabled.
,
Aug 1
,
Aug 6
Marking P1 as per request from Grace.
,
Aug 8
Thanks, Matt. Do we need UX support on this?
,
Aug 8
We shouldn't but I'll chat with @austinknight. I was going to reduce the top margin by the top toolbar's height.
,
Aug 8
Maybe also the padding of doodle area?
,
Aug 9
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a commit 00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a Author: Matthew Jones <mdjones@chromium.org> Date: Fri Aug 10 16:02:42 2018 Fix padding issues on Duet NTP This patch reduces the padding above the logo on the NTP to reduce the unneeded whitespace and adds padding to the bottom so that the footer is not obscured by the bottom toolbar. Bug: 870748 , 869612 Change-Id: I9e003149d32d54b2652e20e1a45524724985abff Reviewed-on: https://chromium-review.googlesource.com/1169587 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#582185} [modify] https://crrev.com/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java [modify] https://crrev.com/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
,
Aug 10
,
Aug 13
Thanks for fixing this. It seems we still have some extra padding. The latest Canary, https://drive.google.com/open?id=1FG1PsYC_fuvVeVIR-IFDzEVnzH6CBbCV, which has doodle. Here is Google app at the same day with the doodle, https://drive.google.com/open?id=1FG1PsYC_fuvVeVIR-IFDzEVnzH6CBbCV |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mdjones@chromium.org
, Aug 1