New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 869612 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task



Sign in to add a comment

Reduce margin above Google logo on NTP

Project Member Reported by mdjones@chromium.org, Jul 31

Issue description

In the absence of the top toolbar on the NTP, there appears to be too much space above the google logo. We should reduce this when Duet is enabled.
 
Labels: -Pri-3 Pri-2
Labels: M-70
Labels: -Pri-2 Pri-1
Marking P1 as per request from Grace.
Cc: klo...@chromium.org
Thanks, Matt.

Do we need UX support on this?
Cc: -mdjones@chromium.org austinknight@chromium.org
Owner: mdjones@chromium.org
We shouldn't but I'll chat with @austinknight. I was going to reduce the top margin by the top toolbar's height.
Maybe also the padding of doodle area?
Screenshot_20180805-092242.png
247 KB View Download
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a

commit 00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri Aug 10 16:02:42 2018

Fix padding issues on Duet NTP

This patch reduces the padding above the logo on the NTP to reduce
the unneeded whitespace and adds padding to the bottom so that the
footer is not obscured by the bottom toolbar.

Bug:  870748 , 869612 
Change-Id: I9e003149d32d54b2652e20e1a45524724985abff
Reviewed-on: https://chromium-review.googlesource.com/1169587
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582185}
[modify] https://crrev.com/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
[modify] https://crrev.com/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Status: Fixed (was: Started)
Thanks for fixing this. It seems we still have some extra padding.

The latest Canary, https://drive.google.com/open?id=1FG1PsYC_fuvVeVIR-IFDzEVnzH6CBbCV, which has doodle.

Here is Google app at the same day with the doodle, https://drive.google.com/open?id=1FG1PsYC_fuvVeVIR-IFDzEVnzH6CBbCV

Sign in to add a comment