Move OGB when browser is in RTL mode |
||||||||||||
Issue descriptionChrome Version: 69.0.3453.3 (Official Build) canary (64-bit) OS: MacOS 10.13.4 What steps will reproduce the problem? (1) Change browser language / set language for google.com account to something RTL. Observe that on google.com, the One Google Bar is positioned on the top left. On the local NTP, it is in RTL mode, but positioned on the top right. Related: crbug.com/869341
,
Aug 1
,
Aug 2
,
Aug 6
,
Aug 7
,
Aug 7
Please see https://bugs.chromium.org/p/chromium/issues/detail?id=871162#c3 for reference
,
Aug 7
,
Aug 8
,
Aug 8
,
Aug 8
For tracking: I think this is addressed in https://chromium-review.googlesource.com/c/chromium/src/+/1165534 ?
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81684566d2778f74e9d07d4e3ac9a8cc320100a1 commit 81684566d2778f74e9d07d4e3ac9a8cc320100a1 Author: Weilun Shi <sweilun@chromium.org> Date: Wed Aug 08 01:46:35 2018 [NTP] One Google Bar align to left when using rtl language Change the one-google bar css setting from align to right to width:100%, which consistent with the google.com setting. OGB can now automatically align to left or right based on the language preference setting. Also, the profile icon will not be invisible on rtl mode. Please see https://bugs.chromium.org/p/chromium/issues/detail?id=871162#c3 for reference. Bug: 869610 , 869341 Change-Id: Iac7e015a5506cd8bcd82ef94d237790210a5fba8 Reviewed-on: https://chromium-review.googlesource.com/1165534 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581434} [modify] https://crrev.com/81684566d2778f74e9d07d4e3ac9a8cc320100a1/chrome/browser/resources/local_ntp/local_ntp.css
,
Aug 8
,
Aug 22
,
Aug 22
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by ramyan@chromium.org
, Jul 3153.4 KB
53.4 KB View Download