New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 869602 link

Starred by 1 user
Status: Fixed
Owner:
perezju@chromium.org
Closed: Aug 13
Cc:
█ nednguyen@chromium.org
csharrison@chromium.org
jonr...@chromium.org
█ wangge@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

PerfBenchmarkTest.testVariationArgsCompatibilityMode fails with any other feature

Project Member Reported by jonr...@chromium.org, Jul 31 
OS: Linux
Test: telemetry_perf_unittests
Extra browser args: --enable-features=VizDisplayCompositor

PerfBenchmarkTest.testVariationArgsCompatibilityMode was recently added: https://chromium-review.googlesource.com/c/chromium/src/+/1150032

However it has a hard coded expectation on the number of features present.

This prevents running the telemtery_perf_unittests with any new feature that is in development behind command line flags.

We are currently running such a configuration on a linux FYI bot, and it has begun seeing this test fail as of: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Viz/6530

This is similar to issue 844863, where PerfBenchmarkTest.testVariationArgs was updated to account for other command line flags being present.

wangge@, since you landed this new test, could you take a look at updating it? Thanks!

Comment 1 by jonr...@chromium.org, Jul 31 

Assigned to Ned for now as wangge@ is not listed as a project member currently, so they cannot be made an owner.

Comment 2 by nednguyen@chromium.org, Jul 31

Cc: -nedngu...@google.com nednguyen@chromium.org
Components: Speed>Telemetry
Owner: perezju@chromium.org
Make Juan the key owner since he's owning the compatibilityMode work

Comment 3 by wangge@google.com, Aug 1 

Thanks for reporting this issue, I will take a look as soon as possible.

Comment 4 by wangge@google.com, Aug 1 

I have uploaded a CL to try fix this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e9ceb73177ea0c8dfe2c33627930a6c6f6e6a54

commit 1e9ceb73177ea0c8dfe2c33627930a6c6f6e6a54
Author: Leonard Ge <wangge@google.com>
Date: Wed Aug 01 11:14:45 2018

Integrate `testVarationArgsCompatibilityMode` Into `testVarationArgs`

This CL tries to fix the test failure introduced by testVarationArgsCompatibi-
lityMode. We replaced the hardcoded number with a reliable check of the exact
arguments added. This CL mimcs the change in CL:1151447.

Bug:  869602 
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I79579ae403066a410b477920a7fd1e29777aaf8a
Reviewed-on: https://chromium-review.googlesource.com/1158229
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Leonard Ge <wangge@google.com>
Cr-Commit-Position: refs/heads/master@{#579758}
[modify] https://crrev.com/1e9ceb73177ea0c8dfe2c33627930a6c6f6e6a54/tools/perf/core/perf_benchmark_unittest.py

Comment 6 by perezju@chromium.org, Aug 1 

This should be fixed now, but let us know if any problems persist.

Comment 7 by perezju@chromium.org, Aug 13

Status: Fixed (was: Assigned)

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 9 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
►

Sign in to add a comment