New issue
Advanced search Search tips

Issue 869588 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename browser_backend.pid to browser_backend.GetPid

Project Member Reported by nednguyen@chromium.org, Jul 31

Issue description

For some browser_backend like android_browser_backend, getting the pid requires exuecute a query against the android OS. So naming this method pid() and make it a property method is misleading because it have side effects and not a light weight lookup.
 
I have no objections with this. But would some of the concerns be alleviated if we cache the pid so the cost to obtain it is only paid once?
#1: yes, we can add that
Can I take this issue if there is no one working on this?
Yes, feel free to go ahead!
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dccb960c26dac18c6e0daf71b93d5a8146639b7

commit 5dccb960c26dac18c6e0daf71b93d5a8146639b7
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Sep 24 01:51:24 2018

Roll src/third_party/catapult 218f46686f2f..45ed33924d94 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/218f46686f2f..45ed33924d94


git log 218f46686f2f..45ed33924d94 --date=short --no-merges --format='%ad %ae %s'
2018-09-23 sapzape@gmail.com Change pid to GetPid


Created with:
  gclient setdep -r src/third_party/catapult@45ed33924d94

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:869588
TBR=sullivan@chromium.org

Change-Id: I6165920cbe7f75423f9177aafa72e66b596fceab
Reviewed-on: https://chromium-review.googlesource.com/1240073
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593469}
[modify] https://crrev.com/5dccb960c26dac18c6e0daf71b93d5a8146639b7/DEPS

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Sign in to add a comment