Rename browser_backend.pid to browser_backend.GetPid |
|||
Issue descriptionFor some browser_backend like android_browser_backend, getting the pid requires exuecute a query against the android OS. So naming this method pid() and make it a property method is misleading because it have side effects and not a light weight lookup.
,
Aug 2
#1: yes, we can add that
,
Sep 10
Can I take this issue if there is no one working on this?
,
Sep 10
Yes, feel free to go ahead!
,
Sep 23
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/45ed33924d94afd1b188cb639fd0c511e5b90603 commit 45ed33924d94afd1b188cb639fd0c511e5b90603 Author: Jongheon Kim <sapzape@gmail.com> Date: Sun Sep 23 17:34:58 2018 Change pid to GetPid This patch rename pid to GetPid and remove @propery annotation Bug: chromium:869588 Change-Id: I739b56951a36e100bef5a46c44b4fd9e6d8b55f1 Reviewed-on: https://chromium-review.googlesource.com/1219369 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/45ed33924d94afd1b188cb639fd0c511e5b90603/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py [modify] https://crrev.com/45ed33924d94afd1b188cb639fd0c511e5b90603/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py [modify] https://crrev.com/45ed33924d94afd1b188cb639fd0c511e5b90603/telemetry/telemetry/internal/backends/browser_backend_unittest.py [modify] https://crrev.com/45ed33924d94afd1b188cb639fd0c511e5b90603/telemetry/telemetry/internal/browser/browser.py [modify] https://crrev.com/45ed33924d94afd1b188cb639fd0c511e5b90603/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py [modify] https://crrev.com/45ed33924d94afd1b188cb639fd0c511e5b90603/telemetry/telemetry/internal/backends/app_backend.py
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dccb960c26dac18c6e0daf71b93d5a8146639b7 commit 5dccb960c26dac18c6e0daf71b93d5a8146639b7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Sep 24 01:51:24 2018 Roll src/third_party/catapult 218f46686f2f..45ed33924d94 (1 commits) https://chromium.googlesource.com/catapult.git/+log/218f46686f2f..45ed33924d94 git log 218f46686f2f..45ed33924d94 --date=short --no-merges --format='%ad %ae %s' 2018-09-23 sapzape@gmail.com Change pid to GetPid Created with: gclient setdep -r src/third_party/catapult@45ed33924d94 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:869588 TBR=sullivan@chromium.org Change-Id: I6165920cbe7f75423f9177aafa72e66b596fceab Reviewed-on: https://chromium-review.googlesource.com/1240073 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593469} [modify] https://crrev.com/5dccb960c26dac18c6e0daf71b93d5a8146639b7/DEPS
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by perezju@chromium.org
, Aug 2