New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 869580: Recently closed tabs appearing in browser history even when SavingBrowserHistoryDisabled is enabled

Reported by andrewim...@gmail.com, Jul 31 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.84 Safari/537.36

Steps to reproduce the problem:
1. Enable "SavingBrowserHistoryDisabled" via Group Policy or Registry
2. Open browser and open multiple web sites in different tabs
3. Close browser
4. Reopen browser and select "History" and view list of items under "Recently Closed". Entry or entries for "# tabs" (where # is a number) appear and can be selected. 
5. When "# tabs" is selected, it opens recently closed sites. 

What is the expected behavior?
When "SavingBrowserHistoryDisabled" is enabled, no sites should be saved in the history after the browser is closed. 

What went wrong?
Groupings of sites recently closed are appearing in the browser history even after the browser is closed. 

Did this work before? N/A 

Chrome version: 68.0.3440.84  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 30.0 r0
 

Comment 1 by andrewim...@gmail.com, Jul 31 2018

Showing setting is enabled and applied to the browser
PolicySetting.png
2.6 KB View Download

Comment 2 by andrewim...@gmail.com, Jul 31 2018

Example showing what appears after browser is closed when setting is enabled.
HistoryExample.png
9.0 KB View Download

Comment 3 by pastarmovj@chromium.org, Aug 3

Cc: georgesak@chromium.org pastarmovj@chromium.org
Owner: privard@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to Phil for prioritization. Maybe the history team can help us fix this.

Comment 4 by nicolaso@chromium.org, Oct 31

Labels: Hotlist-Enterprise-Fixit

Comment 5 by nicolaso@chromium.org, Dec 10

Cc: nicolaso@chromium.org

Comment 6 by mad@chromium.org, Dec 10

Cc: privard@chromium.org
Owner: mad@chromium.org
Status: Started (was: Assigned)
I'll give this a shot.

Comment 7 by mad@chromium.org, Dec 11

So I have a fix, but I want to confirm that we are OK with a small difference of behavior with regular history.

The regular history stops adding elements to the history as soon as the policy is set to disable. Which means, even within a session (i.e., without closing the browser), the history elements are not available. Although this is not quite true, since they are available for backward and forward navigation in the tab history. But once the tab is closed, these history elements are not available anymore... Well... Unless the tab is restored with either <Ctrl><Shift>T, or the Recently closed tabs option of this history sub-menu.

So with my current fix, the Recently closed tabs are only flushed when the browser is closed, but are not prevented during the session.

Since the description of the issue mentionned closing the browser, I guess it's OK... Right?

Comment 8 by pastarmovj@chromium.org, Dec 11

Sounds good to me. It can even be seen as a benefit for the running session to allow "undo".

Comment 9 by andrewim...@gmail.com, Dec 13

I'm fine with a fix that clears the history when the browser is closed. The expectation is that the history isn't carried over to the next browsing session.

Comment 10 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8969859eaeb089644760a9ccd09b2014a38de45

commit d8969859eaeb089644760a9ccd09b2014a38de45
Author: Marc-André (MAD) Decoste <mad@chromium.org>
Date: Fri Dec 14 13:48:32 2018

Move kSavingBrowserHistoryDisabled to components.

This is in preperation for another change to use it in the tab restore service.

Bug:  869580 
Change-Id: I217277b012f03337c57328435319d56ff0fbba49
Reviewed-on: https://chromium-review.googlesource.com/c/1377505
Commit-Queue: Marc-André Decoste <mad@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616653}
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/chrome/browser/history/history_browsertest.cc
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/chrome/browser/history/history_service_factory.cc
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/chrome/browser/sync/test/integration/sync_errors_test.cc
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/chrome/common/pref_names.cc
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/chrome/common/pref_names.h
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/components/history/core/common/BUILD.gn
[add] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/components/history/core/common/pref_names.cc
[add] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/components/history/core/common/pref_names.h
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/components/sessions/BUILD.gn
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/components/sessions/DEPS
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/ios/chrome/browser/DEPS
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/ios/web_view/BUILD.gn
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/ios/web_view/internal/DEPS
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/ios/web_view/internal/sync/web_view_sync_client.mm
[modify] https://crrev.com/d8969859eaeb089644760a9ccd09b2014a38de45/ios/web_view/internal/web_view_browser_state.mm

Comment 11 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3

commit 2e14c65ea3219173009dfd7a4c3ae3c73814d2d3
Author: Marc-André (MAD) Decoste <mad@chromium.org>
Date: Fri Dec 14 17:52:48 2018

Renamed persistent tab restore service.

In preparation for another CL which makes persitence dependent on a policy pref.

Bug:  869580 
Change-Id: I5fa64297c9c6dbddf121703686c41f1a52bae1d8
Reviewed-on: https://chromium-review.googlesource.com/c/1378229
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Marc-André Decoste <mad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616733}
[rename] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/chrome/browser/sessions/tab_restore_service_browsertest.cc
[modify] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/chrome/browser/sessions/tab_restore_service_factory.cc
[rename] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/chrome/browser/sessions/tab_restore_service_unittest.cc
[modify] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm
[modify] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/chrome/test/BUILD.gn
[modify] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/components/sessions/BUILD.gn
[modify] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/components/sessions/content/content_live_tab.h
[modify] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/components/sessions/core/tab_restore_service_helper.h
[rename] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/components/sessions/core/tab_restore_service_impl.cc
[rename] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/components/sessions/core/tab_restore_service_impl.h
[modify] https://crrev.com/2e14c65ea3219173009dfd7a4c3ae3c73814d2d3/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.cc

Comment 12 by mad@chromium.org, Dec 17

Status: Fixed (was: Started)

Comment 13 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/318ef2885ad9fbedb2492c4442b9e50e6257bb02

commit 318ef2885ad9fbedb2492c4442b9e50e6257bb02
Author: Marc-André (MAD) Decoste <mad@chromium.org>
Date: Mon Dec 17 18:15:40 2018

Don't persist recently closed tabs when policy disables history save.

Bug:  869580 
Change-Id: I0b45a9feca593d4443067ae92fc1004c549625f0
Reviewed-on: https://chromium-review.googlesource.com/c/1370490
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Marc-André Decoste <mad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617162}
[modify] https://crrev.com/318ef2885ad9fbedb2492c4442b9e50e6257bb02/chrome/browser/sessions/tab_restore_service_factory.cc
[modify] https://crrev.com/318ef2885ad9fbedb2492c4442b9e50e6257bb02/chrome/browser/sessions/tab_restore_service_unittest.cc
[modify] https://crrev.com/318ef2885ad9fbedb2492c4442b9e50e6257bb02/chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm
[modify] https://crrev.com/318ef2885ad9fbedb2492c4442b9e50e6257bb02/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/318ef2885ad9fbedb2492c4442b9e50e6257bb02/components/sessions/core/tab_restore_service_helper.cc
[modify] https://crrev.com/318ef2885ad9fbedb2492c4442b9e50e6257bb02/components/sessions/core/tab_restore_service_helper.h
[modify] https://crrev.com/318ef2885ad9fbedb2492c4442b9e50e6257bb02/components/sessions/core/tab_restore_service_impl.cc
[modify] https://crrev.com/318ef2885ad9fbedb2492c4442b9e50e6257bb02/components/sessions/core/tab_restore_service_impl.h
[modify] https://crrev.com/318ef2885ad9fbedb2492c4442b9e50e6257bb02/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.cc

Sign in to add a comment