New issue
Advanced search Search tips

Issue 869579 link

Starred by 1 user
Status: Fixed
Owner:
ehmaldonado@chromium.org
Closed: Jul 31
Cc:
petermarshall@chromium.org
clemensh@chromium.org
aga...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression


Previous locations:
v8:7976


Sign in to add a comment

Clang-format presubmit check not working

Project Member Reported by clemensh@chromium.org, Jul 24 
I just uploaded this CL without any complain locally, and also the "v8_presubmit" bot is happy: https://crrev.com/c/1148574

We probably already landed a number of changes which "break" clang-format, so we should make sure to reenable that check soon.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/58b98c0e9801e760818914636bafea0499841199

commit 58b98c0e9801e760818914636bafea0499841199
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Tue Jul 24 20:41:52 2018

[arm] Fix status line to skip flaky test

TBR=mstarzinger@chromium.org

No-Try: true
Bug: v8:7976
Change-Id: I12585016afbf86e3d50bacb45a57ab20b6be72ff
Reviewed-on: https://chromium-review.googlesource.com/1148728
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54667}
[modify] https://crrev.com/58b98c0e9801e760818914636bafea0499841199/test/unittests/unittests.status

Comment 2 by clemensh@chromium.org, Jul 24 

Oops, wrong bug :/

Comment 3 by machenb...@chromium.org, Jul 25

Cc: aga...@chromium.org
+agable: Did anything change in depot_tools how the clang-format presubmit check is hooked up?

Comment 4 by clemensh@chromium.org, Jul 26 

Ping :)

Comment 5 by machenb...@chromium.org, Jul 26

Cc: ehmaldonado@chromium.org

Comment 6 by clemensh@chromium.org, Jul 31

Cc: -ehmaldonado@chromium.org
Owner: ehmaldonado@chromium.org
Status: Assigned (was: Untriaged)
The error still exists.

I just bisected on depot-tools, and got 5ba1e9caeecb40a6ec7cc045e6850dbe65f79446 (git cl: Start reporting metrics.).

Before that CL, on "git cl presubmit" on the CL linked in #0 I get:
** Presubmit Warnings **
The v8 directory requires source formatting. Please run: git cl format 

After that CL, this warning disappears.

Comment 7 by machenb...@chromium.org, Jul 31

Project: chromium
Moved issue v8:7976 to now be  issue chromium:869579 .

Comment 8 by machenb...@chromium.org, Jul 31

Components: Infra>SDK
Labels: -Type-Bug -Priority-1 Pri-1 Type-Bug-Regression

Comment 10 by clemensh@chromium.org, Aug 1 

Thanks, seems to work again!
►

Sign in to add a comment